Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: (1 inline comment) we still have kill and launch .. but not in a functi

Change in vdsm[master]: blocksd: skip broken images in getAllVolumes

2013-02-11 Thread agl
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: Looks good to me, but someone else must approve Yes please! We are actually seeing this in a productio

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) once up

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http:/

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Looks good to me, approved Dan's comment is not relevant as whatever names device mapper

Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1205/ : SUCCES

Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1205/ (2/3) -- To

Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/351/ (3/3)

Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.

2013-02-11 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Adding monitorPoolDomains replacing connectStoragePool. Spliting the share storage and host views of the po

Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1240/ (1/3)

Change in vdsm[master]: blocksd: skip broken images in getAllVolumes

2013-02-11 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: I would prefer that you didn't submit this getAllVolumes() should not work in malformed storage domains fr

Change in vdsm[master]: Don't crash on libvirt network re-definition.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't crash on libvirt network re-definition. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1204/ : SUCCESS http://

Change in vdsm[master]: Don't crash on libvirt network re-definition.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't crash on libvirt network re-definition. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1204/ (2/3) -- To view, visi

Change in vdsm[master]: Don't crash on libvirt network re-definition.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't crash on libvirt network re-definition. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1239/ (1/3) -- To view

Change in vdsm[master]: Don't crash on libvirt network re-definition.

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't crash on libvirt network re-definition. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/350/ (3/3) -- To vi

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Verified Removed changes to unit test. And also checked special characters manually.

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1203/ : SU

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/349/ (

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1238/ (1/

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1203/ (3/3) --

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerr

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/12

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_ger

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_ger

Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

2013-02-11 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: After fail to connect to supervdsm more than 3 time restart the process .. After fail to connect to supervdsm more than 3 time restart the process When connec

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1201/ : SUCCESS http://j

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11913 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1201/ (3/3) -- To view, visit

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/347/ (1/3) -- To vie

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1236/ (2/3) -- To view,

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: migration log messages spelling .. vdsm: migration log messages spelling Signed-off-by: Peter V. Saveliev Change-Id: I209172af06c0d6d91968a6aa27

Change in vdsm[master]: Removing vdsm configuration when removing vdsm service

2013-02-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing vdsm configuration when removing vdsm service .. Removing vdsm configuration when removing vdsm service Before we removed that section only ov

Change in vdsm[master]: make misc.pgrep for general usage

2013-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: make misc.pgrep for general usage .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments) ..

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread paikov
Daniel Paikov has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11852 To unsubscribe, visit http:/

Change in vdsm[master]: Removing vdsm configuration when removing vdsm service

2013-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing vdsm configuration when removing vdsm service .. Patch Set 5: Verified I probably have something wrong with my fedora vm. It works great over other ma

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11912 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: stats: compute the iso prefix asynchronously

2013-02-11 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: stats: compute the iso prefix asynchronously .. Patch Set 2: (1 inline comment) File vdsm/storage/sp.p

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: I would prefer that you didn't submit this I suppose you can ignore my opinion and n

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11912 To unsubscribe, visit http://ge

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1199/ : SUCCESS http://jenkins.

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1200/ : SU

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1200/ (3/3) --

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1235/ (2/

Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/346/ (

Change in vdsm[master]: vdsm: Move all files for the VDSM module to a separate folde...

2013-02-11 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: vdsm: Move all files for the VDSM module to a separate folder .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit htt

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1199/ (2/3) -- To view, visit http:/

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1234/ (3/3) -- To view, visit

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: No score Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/345/ (1/3) -- To v

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1198/ : SUCCESS http://j

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1197/ : SUCCESS http://jenkin

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/344/ (3/3) -- To vie

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1233/ (2/3) -- To view,

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration status structure refactoring .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1198/ (1/3) -- To view, visit

Change in vdsm[master]: vdsm: migration status structure refactoring

2013-02-11 Thread peet
Peter V. Saveliev has uploaded a new change for review. Change subject: vdsm: migration status structure refactoring .. vdsm: migration status structure refactoring Signed-off-by: Peter V. Saveliev Change-Id: I72af06c0d6d91

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1197/ (2/3) -- To view, visit http:/

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1232/ (3/3) -- To view, visit

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration log messages spelling .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/343/ (1/3) -- To view, visi

Change in vdsm[master]: vdsm: migration log messages spelling

2013-02-11 Thread peet
Peter V. Saveliev has uploaded a new change for review. Change subject: vdsm: migration log messages spelling .. vdsm: migration log messages spelling Signed-off-by: Peter V. Saveliev Change-Id: I209172af06c0d6d91968a6aa27780e1

Change in vdsm[master]: [WIP] Changing startup and rpc for vdsm and supervdsm

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Changing startup and rpc for vdsm and supervdsm .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1196/ : SUCCES

Change in vdsm[master]: change startup process for vdsm and supervdsm

2013-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: change startup process for vdsm and supervdsm .. Patch Set 11: http://gerrit.ovirt.org/#/c/11910 - is based on your changes here and adds the use in rpyc -- T

Change in vdsm[master]: [WIP] Changing startup and rpc for vdsm and supervdsm

2013-02-11 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: [WIP] Changing startup and rpc for vdsm and supervdsm .. [WIP] Changing startup and rpc for vdsm and supervdsm This patch runs vdsm as root, start external pro

Change in vdsm[master]: [WIP] Changing startup and rpc for vdsm and supervdsm

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Changing startup and rpc for vdsm and supervdsm .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1196/ (3/3) -- To vi

Change in vdsm[master]: [WIP] Changing startup and rpc for vdsm and supervdsm

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Changing startup and rpc for vdsm and supervdsm .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/342/ (1/3)

Change in vdsm[master]: [WIP] Changing startup and rpc for vdsm and supervdsm

2013-02-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Changing startup and rpc for vdsm and supervdsm .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1231/ (2/3) --