Change in vdsm[master]: WIP: Multiple Gateways Feature

Giuseppe Vallarelli has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 10: (1 inline comment) File vdsm/sourceRoute.py Line 90:

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

Giuseppe Vallarelli has posted comments on this change. Change subject: gluster: new vdsm verb glusterHostUUIDGet .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13785

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 2: (3 inline comments) File

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: Updated the commit message to clarify a bit the situation. -- To view, visit

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2719/ : SUCCESS

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

Michal Skrivanek has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: I think we should address the fact that the whole thread exits on uncaught exception. I think

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: Well I agree that we should do that, however I rather think that should be addressed as a

Change in vdsm[master]: NetReload: netmodels for delNetwork

Dan Kenigsberg has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 12: (1 inline comment) File vdsm/netmodels.py Line 195:

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor and product id .. Patch Set 11: Build Successful

Change in vdsm[master]: vm: check disk alignment using virt-alignment-scan

Dan Kenigsberg has posted comments on this change. Change subject: vm: check disk alignment using virt-alignment-scan .. Patch Set 10: I would prefer that you didn't submit this I'm a bit confused by this PatchSet 10. It

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/15506 to review the following change. Change subject: gluster: fix remove disabled hook exception handling error

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

Timothy Asir has posted comments on this change. Change subject: gluster: fix remove disabled hook exception handling error .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15506 To unsubscribe, visit

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

Aravinda VK has posted comments on this change. Change subject: gluster: fix remove disabled hook exception handling error .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsm-tool: extend service module to check existence of a s...

Aravinda VK has posted comments on this change. Change subject: vdsm-tool: extend service module to check existence of a service .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...

Aravinda VK has posted comments on this change. Change subject: vdsm-tool: extend service module to cover alternative service names .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsm-tool: avoid service action redirections

Aravinda VK has posted comments on this change. Change subject: vdsm-tool: avoid service action redirections .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15099 To

Change in vdsm[master]: multipath.py: use vdsm.tool.service to restart multipathd

Aravinda VK has posted comments on this change. Change subject: multipath.py: use vdsm.tool.service to restart multipathd .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

Aravinda VK has posted comments on this change. Change subject: gluster: new vdsm verb glusterHostUUIDGet .. Patch Set 6: No score Gluster team is planning to introduce new cli command to read uuid and avoids reading uuid

Change in vdsm[master]: Improve __prefetch logging.

oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve __prefetch logging. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2721/ : SUCCESS

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix remove disabled hook exception handling error .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2722/ :

Change in vdsm[master]: Improve __prefetch logging.

Dan Kenigsberg has posted comments on this change. Change subject: Improve __prefetch logging. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15483 To unsubscribe, visit

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Antoni Segura Puimedon has uploaded a new change for review. Change subject: fix testBuildCmdLine not to be Fedora specific. .. fix testBuildCmdLine not to be Fedora specific. Change-Id:

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Giuseppe Vallarelli has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Improve __prefetch logging.

Eduardo has posted comments on this change. Change subject: Improve __prefetch logging. .. Patch Set 2: Verified Before this patch: knownSDs: {'54dbdbe1-6875-4af2-979f-91a073f2baf2': function findDomain at 0xf33578 With

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 2: Build Successful

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Antoni Segura Puimedon has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 2: Fails the product is wrong. -- To view, visit http://gerrit.ovirt.org/15507 To

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Giuseppe Vallarelli has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: Looks good to me, but someone else must approve Hopefully! :-) -- To view, visit

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Giuseppe Vallarelli has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15507 To unsubscribe, visit

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Giuseppe Vallarelli has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: Tried on f18. -- To view, visit http://gerrit.ovirt.org/15507 To unsubscribe, visit

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Eyal Edri has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15507 To

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Antoni Segura Puimedon has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: Verified verified on rhel 6.4 -- To view, visit http://gerrit.ovirt.org/15507 To

Change in vdsm[master]: Improve __prefetch logging.

Dan Kenigsberg has submitted this change and it was merged. Change subject: Improve __prefetch logging. .. Improve __prefetch logging. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=967296 Change-Id:

Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

Dan Kenigsberg has posted comments on this change. Change subject: fix testBuildCmdLine not to be Fedora specific. .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) This is *so* my own fault.

Change in vdsm[master]: fix testBuildCmdLine not to be upstream-specific

Dan Kenigsberg has posted comments on this change. Change subject: fix testBuildCmdLine not to be upstream-specific .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/15507 To unsubscribe, visit

Change in vdsm[master]: fix testBuildCmdLine not to be upstream-specific

Antoni Segura Puimedon has posted comments on this change. Change subject: fix testBuildCmdLine not to be upstream-specific .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: fix testBuildCmdLine not to be upstream-specific

Dan Kenigsberg has submitted this change and it was merged. Change subject: fix testBuildCmdLine not to be upstream-specific .. fix testBuildCmdLine not to be upstream-specific A certain downstream product would like to change

Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: Looks good to me, approved Finally the unregister was called twice? question is resolved! Thanks!

Change in vdsm[master]: caps.py: osversion() providing product short info

Douglas Schilling Landgraf has posted comments on this change. Change subject: caps.py: osversion() providing product short info .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/15431 To

Change in vdsm[master]: fix testBuildCmdLine not to be upstream-specific

Dan Kenigsberg has posted comments on this change. Change subject: fix testBuildCmdLine not to be upstream-specific .. Patch Set 4: Looks good to me, approved Thanks, Toni. -- To view, visit http://gerrit.ovirt.org/15507 To

Change in vdsm[master]: Add service-reload command to vdsm-tool service module

Dan Kenigsberg has posted comments on this change. Change subject: Add service-reload command to vdsm-tool service module .. Patch Set 4: Looks good to me, approved Thanks -- To view, visit http://gerrit.ovirt.org/14727 To

Change in vdsm[master]: Add service-reload command to vdsm-tool service module

Dan Kenigsberg has submitted this change and it was merged. Change subject: Add service-reload command to vdsm-tool service module .. Add service-reload command to vdsm-tool service module vdsm-tool service-reload XXXd will

Change in vdsm[master]: caps.py: osversion() providing product short info

Dan Kenigsberg has posted comments on this change. Change subject: caps.py: osversion() providing product short info .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix remove disabled hook exception handling error .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: multipath.py: use vdsm.tool.service to restart multipathd

Dan Kenigsberg has submitted this change and it was merged. Change subject: multipath.py: use vdsm.tool.service to restart multipathd .. multipath.py: use vdsm.tool.service to restart multipathd multipath.py restart and reload

Change in vdsm[master]: introducing virtio-scsi support

Federico Simoncelli has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 5: (1 inline comment) File vdsm/vm.py Line 1488:

Change in vdsm[master]: infra: Add logging in case PoolHandler crashes

Saggi Mizrahi has posted comments on this change. Change subject: infra: Add logging in case PoolHandler crashes .. Patch Set 3: (2 inline comments) File

Change in vdsm[master]: Make IRS methods bypass API.py

Saggi Mizrahi has posted comments on this change. Change subject: Make IRS methods bypass API.py .. Patch Set 7: (1 inline comment) File vdsm/BindingXMLRPC.py Line 513:

Change in vdsm[master]: vm: check disk alignment using virt-alignment-scan

Federico Simoncelli has posted comments on this change. Change subject: vm: check disk alignment using virt-alignment-scan .. Patch Set 10: For one's, do we really need/want to expose virtAlignScan in vdsm-python? No idea, I

Change in vdsm[master]: introducing virtio-scsi support

Dan Kenigsberg has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 5: (1 inline comment) File vdsm/vm.py Line 1488:

Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...

Assaf Muller has uploaded a new change for review. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Multiple Gateways: Use SourceRoute when adding/removing networks - Created DHCP hook

Change in vdsm[master]: Multiple Gateways: SourceRoute now uses a configurator

Assaf Muller has abandoned this change. Change subject: Multiple Gateways: SourceRoute now uses a configurator .. Patch Set 4: Abandoned Squashed into another patch in the series. -- To view, visit

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

Doron Fediuck has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 6: Hi, Any reason why not to take this patch? -- To view, visit

Change in vdsm[master]: iproute2 binary wrapper

Assaf Muller has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 9: To Mark, Guiseppe and all reviewers: I haven't ignored your reviews, but I am first laying down the design and then I'll

Change in vdsm[master]: WIP: Multiple Gateways Feature

Assaf Muller has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 11: To Guiseppe and all reviewers: I haven't ignored your reviews, but I am first laying down the design and then

Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...

Assaf Muller has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 1: To all reviewers: This is the final patch in the series. I squashed two previous

Change in vdsm[master]: NetReload: netmodels for delNetwork

Assaf Muller has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 13: My patch set is a result of rebasing so that my Multiple Gateways series of patches depends on this patch.

Change in vdsm[master]: iproute2 binary wrapper

oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2729/ : SUCCESS

Change in vdsm[master]: WIP: Multiple Gateways Feature

oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2728/ : SUCCESS

Change in vdsm[master]: NetReload: netmodels for delNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2730/ : SUCCESS

Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 1: Fails Build Failed

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

Dan Kenigsberg has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 6: I would prefer that you didn't submit this (8 inline comments) Thanks, Mei Liu for your

Change in vdsm[master]: caps.py: osversion() providing product short info

Douglas Schilling Landgraf has posted comments on this change. Change subject: caps.py: osversion() providing product short info .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: caps.py: osversion() providing product short info

Douglas Schilling Landgraf has abandoned this change. Change subject: caps.py: osversion() providing product short info .. Patch Set 1: Abandoned Thanks for the SMBIOS catch Dan. There is no more rhev-advanced image at

Change in vdsm[master]: introducing virtio-scsi support

Ayal Baron has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 5: (1 inline comment) File vdsm/vm.py Line 1488:

Change in vdsm[master]: NetReload: netmodels for delNetwork

Dan Kenigsberg has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 13: I would prefer that you didn't submit this (5 inline comments) Toni, once ready, would you verify this

Change in vdsm[master]: iproute2 binary wrapper

Dan Kenigsberg has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment) please add some basic unit tests for input parsing, so

Change in vdsm[master]: vdsm-tool: avoid service action redirections

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: avoid service action redirections .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15099 To unsubscribe, visit

Change in vdsm[master]: NetReload: netmodels for delNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2732/ : SUCCESS

Change in vdsm[master]: NetReload: netmodels for delNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 13: (5 inline comments) File

Change in vdsm[master]: NetReload: netmodels for delNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 14: Fails (1 inline comment) File

Change in vdsm[master]: NetReload: netmodels for delNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 15: Fails (2 inline comments) File

Change in vdsm[master]: NetReload: netmodels for delNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2733/ : SUCCESS

Change in vdsm[master]: NetReload: netmodels for delNetwork

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 16: Verified -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit

Change in vdsm[master]: NetReload: netmodels for delNetwork

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2734/ : SUCCESS