Change in vdsm[master]: RAM snapshots feature

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2793/ : SUCCESS

Change in vdsm[master]: New getChildrenList implementation.

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2794/ : SUCCESS

Change in vdsm[master]: Reimplement hsm.getVolumesList().

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reimplement hsm.getVolumesList(). .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2795/ : SUCCESS

Change in vdsm[master]: RAM snapshots feature

2013-06-17 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: (3 inline comments) File vdsm/hooks.py Line 188: Line 189: Line 190:

Change in vdsm[master]: RAM snapshots feature

2013-06-17 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: functional test: boot VM with network interface device

2013-06-17 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: functional test: boot VM with network interface device .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) -1 Asking a

Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.

2013-06-17 Thread gvallare
Giuseppe Vallarelli has uploaded a new change for review. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Fix param name in vdsmapi-schema: naming issue. Data type for inbound and outbound params should be

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-17 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 1: (7 inline comments)

Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2796/ : SUCCESS

Change in vdsm[master]: Add code coverage support

2013-06-17 Thread lbednar
Lukas Bednar has posted comments on this change. Change subject: Add code coverage support .. Patch Set 9: Verified generated rpms on rhel. installed vdsm cat /etc/sysconfig/vdsm export

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2798/

Change in vdsm[master]: constants: unify the BLANK_UUID definition

2013-06-17 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15442 To

Change in vdsm[master]: volume: add the BLOCK_SIZE constant

2013-06-17 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve I think it could a great start for externalizing the block

Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...

2013-06-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: extend service module to cover alternative service names .. vdsm-tool: extend service module to cover alternative service names Service

Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: extend service module to cover alternative service names .. Patch Set 9: Looks good to me, approved -- To view, visit

Change in vdsm[master]: gluster: verbs for managing services

2013-06-17 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 21: Verified Rebased since all dependent patches got merged. -- To view, visit http://gerrit.ovirt.org/11094

Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo

2013-06-17 Thread msivak
Martin Sivák has uploaded a new change for review. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. [WIP] Add balloon_min to VM.getVmBalloonInfo The balloon_min key will take it's value from memGuaranteedSize

Change in vdsm[master]: gluster: verbs for managing services

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2799/ : SUCCESS

Change in vdsm[master]: Declare a broken test as such

2013-06-17 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: Declare a broken test as such .. Declare a broken test as such jsonRpcTests.JsonRpcServerTests.testMethodCallArgList tends to fail when run on Jenkins, such

Change in vdsm[master]: Declare a broken test as such

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Declare a broken test as such .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2801/ : SUCCESS

Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2800/ : SUCCESS

Change in vdsm[master]: tests: Adding functional tests for networking

2013-06-17 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 20: Verified Related to the failure you've experienced ( testFailWithInvalidBondingName) I'm

Change in vdsm[master]: tests: Adding functional tests for networking

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2803/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2804/ : SUCCESS

Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo

2013-06-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2805/ : SUCCESS

Change in vdsm[master]: vm: add the live diskSizeExtend method

2013-06-17 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: add the live diskSizeExtend method .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Looks good to me, approved We should really add a unit test to catch such schema failures. --

Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15787 To unsubscribe, visit

Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.

2013-06-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Fix param name in vdsmapi-schema: naming issue. Data type for inbound and outbound params should be

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: I would prefer that you didn't submit this (4 inline comments) Thanks for your

Change in vdsm[master]: Storage Domain V3 Functional Tests

2013-06-17 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Storage Domain V3 Functional Tests .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) If it's not too hard let's try to keep

Change in vdsm[master]: WIP vm payload: cloud-init - multiple files, custom volume l...

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: WIP vm payload: cloud-init - multiple files, custom volume label .. Patch Set 1: I would prefer that you didn't submit this (8 inline comments)

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-17 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: (4 inline comments) Dan, it's not a big deal for me to use minidom but I

Change in vdsm[master]: constants: unify the BLANK_UUID definition

2013-06-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Add code coverage support

2013-06-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add code coverage support .. Patch Set 9: Looks good to me, but someone else must approve (I'd like to verify this with systemd, too.) -- To view, visit

Change in vdsm[master]: constants: unify the BLANK_UUID definition

2013-06-17 Thread hchiramm
humble devassy has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15442 To