Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3: Code-Review-1
(3 comments)
reminder: -1 does not mean "I hate your patch". It means: "I read
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1:
> However, note that the package for fedora 18 has not hit updates-testing yet.
https:/
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 24: Code-Review+1
(1 comment)
File li
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
Fist, I'm not sure this patch solves the bug attached, for me it was a request
for an api chang
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [2/4] Respond to
setSafeNetworkConfig
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [2/4] Respond to
setSafeNetworkConfig
..
Patch Set 8:
(1 comment)
File lib/vd
Yaniv Bronhaim has posted comments on this change.
Change subject: java_bindings: Minor imporovements
..
Patch Set 11:
(4 comments)
minor comments. please response
Commit M
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3:
(4 comments)
File lib/vdsm/libvirtconne
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3:
(1 comment)
File lib/vdsm/libvirtconnec
Yaniv Bronhaim has posted comments on this change.
Change subject: java_binding: Simplify bindings by using object mappers
..
Patch Set 6: Code-Review-1
(2 comments)
you did here much more than just simplify bindings. please a
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Add SSL support to asyncore transport
..
Patch Set 8: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/15426
To unsubscribe, visit http://gerri
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 11: Code-Review-1
(4 comments)
.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4573/ : SUCCE
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
(2 comments)
Commit Message
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [3/4] - Restore network
configuration
..
Patch Set 9: Code-Review-1
(2 comments)
.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4574/ : SUCCE
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
I would expect supervdsmProxy.call to explode with an exception if it receives
unexpected argum
Yaniv Bronhaim has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
..
Patch Set 2:
(1 comment)
File client/vd
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
(3 comments)
File lib/vdsm/libvirtconne
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
According to Saggi on IRC, what I want already happens - but nobody noticed it
until now.
10:4
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
(2 comments)
File tests/libvirtconnecti
Saggi Mizrahi has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
https://bugzilla.redhat.com/show_bug.cgi?id=1006203#c2
--
To view, visit http://gerrit.ovirt.or
Yaniv Bronhaim has abandoned this change.
Change subject: ignore this patch - for testing
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/18422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Dan Kenigsberg has posted comments on this change.
Change subject: Removing redundant code that reads the pools list
..
Patch Set 1: Code-Review-1
(1 comment)
File vdsm/stor
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1:
(1 comment)
File vdsm/caps.py
Line 331:
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
I stand corrected. Now only waiting for V+1.
--
To view, visit http://gerrit.ovirt.org/19250
T
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 3: Code-Review-1
(2 comments)
File vdsm/vm.py
L
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4575/ : SUCCESS
http:
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 24:
(1 comment)
File lib/vdsm/netconfpe
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [3/4] - Restore network
configuration
..
Patch Set 9:
(1 comment)
File lib/vdsm
Ayal Baron has posted comments on this change.
Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets
..
Patch Set 1: Code-Review+2
Saggi, filtering at hsm level is useless and incorrect as it would imply
mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
(2 comments)
File lib/vdsm/libvirtconnecti
Yaniv Bronhaim has uploaded a new change for review.
Change subject: respawn script fix: Adding -- after logger arguments
..
respawn script fix: Adding -- after logger arguments
Without using -- the usage of $@ in the string can
oVirt Jenkins CI Server has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4576/ : SUC
Dan Kenigsberg has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments
..
Patch Set 1: Code-Review-1
how about using $* instead? it would be safer.
it shoud be just like $@, but
Alon Bar-Lev has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments
..
Patch Set 1:
this will have no effect, what we need is to tell logger to stop parsing
parameters.
/me lo
Alon Bar-Lev has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments
..
Patch Set 1: Code-Review+1
we can do either $@ or $*, but adding -- is healthy to stop parsing args.
--
Yaniv Bronhaim has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments
..
Patch Set 1:
both can be used.
/me start to like shell
--
To view, visit http://gerrit.ovirt.org/1946
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests
mooli tayer has uploaded a new change for review.
Change subject: minor changes in libvirt connection
..
minor changes in libvirt connection
change logging levels and use functools.wraps
Change-Id: I5b4b1ddea998adc3003255593dc1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 7: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests
Yaniv Bronhaim has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19462
To unsubscribe, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19250
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: minor changes in libvirt connection
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4580/ :
Saggi Mizrahi has posted comments on this change.
Change subject: minor changes in libvirt connection
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19463
To unsubscribe, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 24: Code-Review+1
(1 comment)
File lib/vdsm/
Dan Kenigsberg has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19462
To unsubscribe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4582/ : SUCCE
Yaniv Bronhaim has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19462
To unsubscribe, v
Yaniv Bronhaim has posted comments on this change.
Change subject: minor changes in libvirt connection
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19463
To unsubscribe, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19348
To uns
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing redundant code that reads the pools list
..
Patch Set 1:
(1 comment)
File vdsm/storage/hsm.py
Lin
Alon Bar-Lev has posted comments on this change.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19462
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: minor changes in libvirt connection
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4583/ : SUCCESS
http://jenk
Dan Kenigsberg has submitted this change and it was merged.
Change subject: respawn script fix: Adding -- after logger arguments and using
$*
..
respawn script fix: Adding -- after logger arguments and using $*
Without using -
Greg Padgett has uploaded a new change for review.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
vdsm: prevent stale vm stats if qemu process exits
If the qemu process stops, releaseVm() is called, but th
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4584/ : SUCCE
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19470
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4585/ : SUCCE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsmServer was not passing kwargs to fuser
..
supervdsmServer was not passing kwargs to fuser
Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 2:
Thanks, Yaniv!
--
To view, visit http://gerrit.ovirt.org/19250
To unsubscribe, visit http://ge
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Adding ppc64 handling to getVdsCaps
..
Patch Set 8:
(2 comments)
File lib/vdsm/utils.py
Line 66:
Lin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4586/ : SUCC
Dan Kenigsberg has submitted this change and it was merged.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
packaging: spec: selinux-policy-targeted requirements
fixed selinux policy-targeted requiremen
mooli tayer has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1:
(1 comment)
File vdsm/caps.py
Line 331:
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1: Code-Review+2
That's the least of our issues with F18..
--
To view, visit http://gerrit.
On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote:
> Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/
> Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/
> Build Number: 683
> Build Status: Still Failing
> Triggered By: Starte
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4587/ : SUCCESS
h
Dan Kenigsberg has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 2: Verified+1
in patchset1 I was plainly lazy. both in writing the two-liner and in not
verifying it
already fixed:
http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/
thanks,
Eyal
- Original Message -
> From: "Dan Kenigsberg"
> To: ee...@redhat.com
> Cc: vdsm-patches@lists.fedorahosted.org, sbona...@redhat.com
> Sent: Monday, September 23, 2013 8:16:50 PM
> Subject: Re: [
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1: Code-Review-2
Vdsm must not release the Vm resources automatically. It must give Engine the
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://
Thanks!
On Mon, Sep 23, 2013 at 03:11:40PM -0400, Eyal Edri wrote:
> already fixed:
>
> http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/
>
> thanks,
>
> Eyal
>
> - Original Message -
> > From: "Dan Kenigsberg"
> > To: ee...@redhat.com
> > Cc: vdsm-patches@lists.fedoraho
Saggi Mizrahi has posted comments on this change.
Change subject: jsonrpc: Add SSL support to asyncore transport
..
Patch Set 6:
(2 comments)
File lib/yajsonrpc/betterAsynco
Greg Padgett has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1:
@Dan - thanks, makes sense. I was thinking about it from the hosted engine
context, where we
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19295
To unsubscribe, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4588/ : SUCCESS
http://jenki
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Line 3384:
Timothy Asir has posted comments on this change.
Change subject: gluster: bug fix for listing and adding hook
..
Patch Set 8:
(3 comments)
File vdsm/gluster/hooks.py
Line 24
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Load softdog if hardware watchdog is not available
..
Patch Set 4:
Bug is reported to Ubuntu at
https://bugs.launchpad.net/ubuntu/+source/sanlock/+bug
Alon Bar-Lev has posted comments on this change.
Change subject: deployUtil: Remove null character from the id on IBM POWER
..
Patch Set 1:
Please merge or close...
--
To view, visit http://gerrit.ovirt.org/17423
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: Support bridgeless ovirt node in vdsm-reg
..
Patch Set 2:
please close
--
To view, visit http://gerrit.ovirt.org/17728
To unsubscribe, visit http://gerrit.ovirt
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 24:
(1 comment)
File lib/vdsm
Antoni Segura Puimedon has abandoned this change.
Change subject: Support bridgeless ovirt node in vdsm-reg
..
Abandoned
The other alternative to solve this got merged.
--
To view, visit http://gerrit.ovirt.org/17728
To unsub
86 matches
Mail list logo
