oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 3: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4: Verified-1
Build Failed
Petr Šebek has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4: Verified+1 Code-Review+1
Installed without errors, getVdsStats returns statistics as expected.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4404/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17:
Build Successful
Allon Mureinik has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
(3 comments)
Commit Message
Line 3:
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 3: Code-Review-1
(5 comments)
I like the patch a lot. There's some things that
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
(7 comments)
Commit Message
Line 8:
Line 9:
Juan Hernandez has posted comments on this change.
Change subject: Avoid M2Crypto races
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has uploaded a new change for review.
Change subject: Fix ballooning rules for computing the minimum available memory
..
Fix ballooning rules for computing the minimum available memory
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17: Code-Review-1
(2 comments)
sorry, I still do not understand how this fix works.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix ballooning rules for computing the minimum available memory
..
Patch Set 1:
Build Successful
Sergey Gotliv has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17:
(1 comment)
Commit Message
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid M2Crypto races
..
Patch Set 1: Verified+1
(1 comment)
Verified that Vdsm still works with this. I have not experienced the race
condition, though.
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
(1 comment)
Commit Message
Line 3:
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes
..
Patch Set 4:
Changes:
- Fix typo in commit message
- Refine commit message
- Add new flags to the invariant part
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4407/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
..
Patch Set 14: Code-Review+1
looks good to me, but a review of storage oriented developer also required here.
please verify as
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes
..
Patch Set 4:
And update lvm2 version to last release version for 6.5.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20812
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 6:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 6:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: lvm: ignore skipped clustered vgs
..
Patch Set 2: Code-Review+1
Looks good, not sure how we can deal with the Fedora 19 dependency.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+1
Looks fine. It's ok for me if we'll address the parameters-passing in
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+1
I agree with Michal's last comment. We can take this now, but I really
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 7:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 15: Code-Review-1
Needs a rebase now that 19331 is merged.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4409/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 6:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 16: Verified+1
rebased
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Code-Review+2
I join the I agree with Ayal, but.. sentiment.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 7:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
vdsm: move balloon logic out of buildConfDevices
Encapsulates empty balloon creation logic outside
Dan Kenigsberg has posted comments on this change.
Change subject: Removal of needless base class StatsThread
..
Patch Set 1: Verified+1
verified with http://gerrit.ovirt.org/#/c/20812/
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removal of needless base class StatsThread
..
Removal of needless base class StatsThread
From this base class inherit only class HostStatsThread,
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoid M2Crypto races
..
Patch Set 1: Code-Review-1
(1 comment)
Just for getting all the answers I need before that merge.
don't we want it for ovirt-3.3. If
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit
Assaf Muller has uploaded a new change for review.
Change subject: Fix minor network functional tests issues
..
Fix minor network functional tests issues
Some tests were asserting that networks existed based on out
of date
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 5: Verified+1
verified with http://gerrit.ovirt.org/#/c/20812/
--
To view, visit http://gerrit.ovirt.org/16227
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Monitor bridges using vdsStats
..
Monitor bridges using vdsStats
Changes in vdsm/sampling.py are neccessary because previously no new
interfaces would
Dan Kenigsberg has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4: Code-Review+2
Thanks for the review and verification!
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1: Verified+1
Touched functional tests still work.
--
To view, visit http://gerrit.ovirt.org/20859
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Patch Set 1: Code-Review-1
sorry, I leaded you wrong. you should not remove the verb from supervdsm , and
Saggi Mizrahi has posted comments on this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Patch Set 1: Code-Review-1
You are reverting, why?
commit e9caf1f1f98b226a984a4f126a20440835cc7bad
Author: Saggi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4410/ : SUCCESS
Eduardo has abandoned this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Abandoned
We need to unify this functions anyway.
--
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20859
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 12: Verified+1
rebased and locally tested, migration should not cause problems unless hwrng VM
is
Nir Soffer has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 7:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4411/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 13: Verified+1
pushing 1st seems like a good idea...
rebased and locally tested, migration should not
Moti Asayag has posted comments on this change.
Change subject: libvirt is happy with redefinition of an existing nwfilter
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20788
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20859
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1:
Even though the commit msg should say: were asserting that the operations
succeeded, since
Dan Kenigsberg has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20859
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix minor network functional tests issues
..
Fix minor network functional tests issues
Some tests were asserting that networks existed based on out
of
Dan Kenigsberg has submitted this change and it was merged.
Change subject: libvirt is happy with redefinition of an existing nwfilter
..
libvirt is happy with redefinition of an existing nwfilter
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt is happy with redefinition of an existing nwfilter
..
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.ovirt.org/20788
To
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
..
Patch Set 1:
then it would be the engine's problem. from vdsm point of view the code is
backward compatible.
Saggi Mizrahi has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/19256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
..
Patch Set 14: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19256
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 3: Code-Review-1
(2 comments)
Commit
Saggi Mizrahi has posted comments on this change.
Change subject: utils: Create AsyncProcessOperation
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/19254
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Don't fail hotplugNic operation when after hook fails
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4412/
Amador Pahim has uploaded a new change for review.
Change subject: Allow disable MOM KSM control.
..
Allow disable MOM KSM control.
This patch add ksmEnabled var to enable/disable mom ksm control.
Now users can use vdsClient to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow disable MOM KSM control.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4413/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4414/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20721
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Allow disable MOM KSM control.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20879
To unsubscribe, visit
Amador Pahim has posted comments on this change.
Change subject: Allow disable MOM KSM control.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/20879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17:
(3 comments)
I think that this fix is correct. The only thing holding this now is more
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4416/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4415/ : SUCCESS
Doron Fediuck has posted comments on this change.
Change subject: Allow disable MOM KSM control.
..
Patch Set 1:
This requires engine support as well, the same way ballooning
can be toggled from the UI.
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Patch Set 1: Code-Review+1
Thanks Yaniv!
--
To view, visit http://gerrit.ovirt.org/20876
To
Dan Kenigsberg has posted comments on this change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
Patch Set 3: Code-Review+2
same as ps2.
--
To view, visit http://gerrit.ovirt.org/20721
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
upgrade: fix v3ResetMetaVolSize argument
In commit c072945 (one shot prepare) the v3ResetMetaVolSize
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Do not use udev cache for obtaining device list
..
lvm: Do not use udev cache for obtaining device list
lvm is obtaining the device list from udev. When
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Do not use udev cache for obtaining device list
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4417/ :
Nir Soffer has posted comments on this change.
Change subject: lvm: Do not use udev cache for obtaining device list
..
Patch Set 1: Verified+1
Change was verified using stress test script, simulating vdsm calls while
creating
Dan Kenigsberg has posted comments on this change.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Don't fail hotplugNic operation when after hook fails
..
Don't fail hotplugNic operation when after hook fails
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Create AsyncProcessOperation
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19254
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Create AsyncProcessOperation
..
utils: Create AsyncProcessOperation
This is an object to wrap a process so it can be treated as an
Dan Kenigsberg has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17:
(2 comments)
Commit Message
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Allow disable MOM KSM control.
..
Allow disable MOM KSM control.
This patch add ksmEnabled var to enable/disable mom ksm control.
Now users can use
Dan Kenigsberg has posted comments on this change.
Change subject: Allow disable MOM KSM control.
..
Patch Set 1: Code-Review+2
Escalating Martin's score.
--
To view, visit http://gerrit.ovirt.org/20879
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Do not use udev cache for obtaining device list
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20890
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/20891
to review the following change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
upgrade: fix
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
Patch Set 1: Verified+1
Same as master.
--
To view, visit http://gerrit.ovirt.org/20891
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1:
Assaf, frankly, I would like *you* to use the upgrade mechanism for this (if
and when we have such a
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid M2Crypto races
..
Patch Set 1:
(1 comment)
A BZ may be required only for the stable branch. Master branch should have no
such requirement.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-activation of vdsm logical volumes
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4418/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 16: Code-Review-1
needs another manual rebase..
--
To view, visit http://gerrit.ovirt.org/18047
To
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 17:
(1 comment)
The missing piece?
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-activation of vdsm logical volumes
..
Patch Set 5:
Changes:
- Improve commit message per Dan request, as the problem and solution were not
1 - 100 of 107 matches
Mail list logo
