Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 32: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4515/ :

Change in vdsm[ovirt-3.3]: stats: return domain lockspace status

2013-11-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: stats: return domain lockspace status .. Patch Set 2: Any chance to have this in oVirt 3.3.2 ? -- To view, visit http://gerrit.ovirt.org/20193 To unsubscrib

Change in vdsm[ovirt-3.3]: Adding [start|stop]MonitoringDomain().

2013-11-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 2: Any chance to have this in oVirt 3.3.2 ? -- To view, visit http://gerrit.ovirt.org/20194 To unsubscri

Change in vdsm[master]: gluster: Add force option to Volume Create command

2013-11-10 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 2: Verified+1 Added force as additional option instead of using as dictionary. -- To view, visit

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: (2 comments) +1 on the approach Dan suggested

Change in vdsm[master]: gluster: Add force option to Volume Create command

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4514/ : SU

Change in vdsm[master]: iproute2 ip link wrapper

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 8: (1 comment) File lib/vdsm/ipwrapper.py Line 88:

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4513/ : SUCCESS http://

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 4: Remove unused imports, typos. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://ge

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: (3 comments) I think the direction that Dan suggested, displaying list of all missing devices in t

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4512/ : FAILURE

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 3: Spelling and whitespace. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 2: Early draft missing build, packaging, pre-start, and tests. I put this here mainly for backup, review if you l

Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/451

Change in vdsm[ovirt-3.3]: configuring selinux allowing qemu-kvm to generate coredumps.

2013-11-10 Thread mtayer
mooli tayer has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 1: I'm having build issues. I'll try again tomorrow and will probably ping you about it y

Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 31: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerri

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: (2 comments) File vdsm/storage/hsm.py Line

Change in vdsm[master]: : Add NetworkTest.testAddDelNetworkDhcp

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: : Add NetworkTest.testAddDelNetworkDhcp .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/781/ : SUCCESS h

Change in vdsm[master]: : Add NetworkTest.testAddDelNetworkDhcp

2013-11-10 Thread pbenas
Petr Benas has uploaded a new change for review. Change subject: : Add NetworkTest.testAddDelNetworkDhcp .. : Add NetworkTest.testAddDelNetworkDhcp Tests adding and deletion of network with dynamically assigned address. The dhcp

Change in vdsm[master]: Add ut to supervdsmServer zombie reaper

2013-11-10 Thread iheim
Itamar Heim has abandoned this change. Change subject: Add ut to supervdsmServer zombie reaper .. Abandoned -- To view, visit http://gerrit.ovirt.org/9354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageT

Change in vdsm[ovirt-3.3]: spec: declare we provide an existing python-cpopen

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: declare we provide an existing python-cpopen .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21058 To unsubscribe, visit http://g

Change in vdsm[ovirt-3.3]: spec: declare we provide an existing python-cpopen

2013-11-10 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: declare we provide an existing python-cpopen .. spec: declare we provide an existing python-cpopen Currently, vdsm-python-cpopen claims to provid

Change in vdsm[ovirt-3.3]: spec: declare we provide an existing python-cpopen

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: declare we provide an existing python-cpopen .. Patch Set 1: Code-Review+1 Thanks! -- To view, visit http://gerrit.ovirt.org/21058 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: spec: declare we provide an existing python-cpopen

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: declare we provide an existing python-cpopen .. Patch Set 1: Thanks! -- To view, visit http://gerrit.ovirt.org/21058 To unsubscribe, visit http://gerrit

Change in vdsm[ovirt-3.3]: Override python-cpopen package

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Override python-cpopen package .. Patch Set 3: (1 comment) thanks for noticing.. File vdsm.spec.in Line 3

Change in vdsm[ovirt-3.3]: configuring selinux allowing qemu-kvm to generate coredumps.

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 1: Mooli, please verify -- To view, visit http://gerrit.ovirt.org/21045 To unsubscri

Change in vdsm[master]: Add ut to supervdsmServer zombie reaper

2013-11-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Add ut to supervdsmServer zombie reaper .. Patch Set 3: not relevant, can be abandoned. thanks -- To view, visit http://gerrit.ovirt.org/9354 To unsubscribe,

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: > Nir, I disagree. The name no longer (or was ever) fits the content and IMO > has to change within

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: (3 comments) Commit Message Line 3: AuthorDate

Change in vdsm[master]: netconf: Improve unified persistence's rollback in memory.

2013-11-10 Thread wudxw
Mark Wu has posted comments on this change. Change subject: netconf: Improve unified persistence's rollback in memory. .. Patch Set 3: (4 comments) Thanks a lot for your insightful review! I will post a new patch in a few day

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4509/ : SUCCE

Change in vdsm[master]: Improve err msg when multipath cant access a pv

2013-11-10 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: Verified+1 Addressed comments on previous patch. -- To view, visit http://gerrit.ovirt.org/210

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

2013-11-10 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

2013-11-10 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed

Change in vdsm[master]: iproute2 ip link wrapper

2013-11-10 Thread amuller
Assaf Muller has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 8: (1 comment) File lib/vdsm/netinfo.py Line 78: Line 79: fakeNic

Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop

2013-11-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: sp: stop monitoring on detach storage domain

2013-11-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: sp: stop monitoring on detach storage domain .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21065 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: hsm: Fix race when checking visible devices readability

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: hsm: Fix race when checking visible devices readability .. Patch Set 1: (1 comment) Commit Message Line 33

Change in vdsm[master]: sp: stop monitoring on detach storage domain

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: sp: stop monitoring on detach storage domain .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21065 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

2013-11-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed acc

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

2013-11-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed