Federico Simoncelli has posted comments on this change.
Change subject: spec: require libvirt 0.10.2-29.el6_5.4
..
Patch Set 1: Verified+1
Verified: generated rpms are requiring libvirt 0.10.2-29.el6_5.4 on el6.
--
To view,
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 2: Code-Review-1
after seeing discussion after 3.4 rc release. changing the score.
we'll try to continue more carefully
Yaniv Bronhaim has posted comments on this change.
Change subject: threadLocal: Cleanup thread local storage
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/25123
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Ensure that XMLRPC threads do not delay shutdown
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/25122
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Ensure that XMLRPC threads do not delay shutdown
..
Patch Set 2: Code-Review+1
it looks to me as purely helpful patch. I agree for this change in
Yaniv Bronhaim has posted comments on this change.
Change subject: threadLocal: Cleanup thread local storage
..
Patch Set 2:
please get ack on this for ovirt-3.4 by federico
--
To view, visit http://gerrit.ovirt.org/25123
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: require libvirt 0.10.2-29.el6_5.4
..
spec: require libvirt 0.10.2-29.el6_5.4
A libvirt race condition caused the volume watermark to be reported
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_scale: Allow NetInfo update just the devices
..
net_scale: Allow NetInfo update just the devices
When deleting networks there was a lot of NetInfo
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 6: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: net_scale: Don't instantiate NetInfo needlessly
..
Patch Set 8: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/23576/8/vdsm/configNetwork.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: require libvirt 0.10.2-29.el6_5.4
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/361/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_scale: Don't instantiate NetInfo needlessly
..
net_scale: Don't instantiate NetInfo needlessly
network validation used to instantiate full-blown
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: # dropbox
Alon Bar-Lev has posted comments on this change.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line
Federico Simoncelli has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: #
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/25124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 2: Code-Review+1
In my opinion, this patch is very beneficial and not really dangerous. We left
a quick retreat path
Dan Kenigsberg has posted comments on this change.
Change subject: threadLocal: Cleanup thread local storage
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25123
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Ensure that XMLRPC threads do not delay shutdown
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25122
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Use same constants for configuring and check configure of
sanlock
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24011
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 6:
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsm: API extension to improve the communication with the
Engine
..
Patch Set 7:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 7: Verified+1
Only rebased. Copying verification score
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: report speed of underlying device as that of vlan
device
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24990
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: report speed of underlying device as that of vlan
device
..
netinfo: report speed of underlying device as that of vlan device
netinfo.py was
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 7:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Fix wrong filtering of dummy devices
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7324/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: Do not take bond/nic down when removing one of their
multiple nets
..
Patch Set 6:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 10:
Build Successful
Francesco Romani has uploaded a new change for review.
Change subject: vm: consider 'action' when handling I/O errors
..
vm: consider 'action' when handling I/O errors
When VDSM receives an I/O error event from libvirt,
it does
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7327/ : SUCCESS
Vered Volansky has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 4:
For what it's worth, verified storage functional tests -localfs and nfs only,
versions 0 and 3 on RHEL
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Francesco Romani has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 13: Verified+1
Generic Error split will be handled enterily in separate patches.
Verified.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 13: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7328/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 13: -Verified
--
To view, visit http://gerrit.ovirt.org/22631
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 10: Code-Review-1
(1 comment)
minor comment.
Yaniv Bronhaim has posted comments on this change.
Change subject: Use same constants for configuring and check configure of
sanlock
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/24011
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixing ssl config validation
..
Patch Set 3:
verified over rhel and fedora. please ack
--
To view, visit http://gerrit.ovirt.org/24500
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Use same constants for configuring and check configure of
sanlock
..
Use same constants for configuring and check configure of sanlock
Both DISKIMAGE_GROUP
Yaniv Bronhaim has posted comments on this change.
Change subject: Use same constants for configuring and check configure of
sanlock
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25162
To unsubscribe,
Francesco Romani has uploaded a new change for review.
Change subject: vm: report exit reason for migration failed
..
vm: report exit reason for migration failed
this patch add reporting for an explicit exit
reason when
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: Do not take bond/nic down when removing one of their
multiple nets
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25003
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7329/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing ssl config validation
..
Patch Set 3: Code-Review+2
Understanding that moving from ssl=True to False and vice versa was verified,
I'm giving my ack.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7330/ : SUCCESS
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Fixing ssl config validation
..
Fixing ssl config validation
Currently we verify only the config of livbirtd.conf and qemu.conf
when ssl=False in
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
testSetupNetworksAddDelDhcp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: Do not take bond/nic down when removing one of their
multiple nets
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/25003
Daniel Erez has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25006
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot transient disk check should be per disk
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25007
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: add missing requirement for sanlock on el7
..
spec: add missing requirement for sanlock on el7
In the el7 section we were missing the sanlock and
Federico Simoncelli has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 2: Verified+1
Verified: el7 now requires sanlock and sanlock-python
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7332/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7334/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7333/ :
Nir Soffer has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 2:
Verified on RHEL 6.5 host and ovirt-engine 3.4.0-0.9.beta3.fc19:
- starting and stopping vms
- create and delete snapshot
Nir Soffer has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vm: fix migration progress calculation
..
Patch Set 2: Verified+1
verification: verified using vdsClient and with both failed (timeout) and
sucesfull
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1: Code-Review-1
(2 comments)
The functional test was fixed and extended to become
Antoni Segura Puimedon has posted comments on this change.
Change subject: net tests: more combinations mtu combinations
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19230
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net tests: more combinations mtu combinations
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7335/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 8:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py
Dan Kenigsberg has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 2: Code-Review+2
We should probably split the requirement section to smaller per-package ones
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1: Code-Review-1
(2 comments)
Francesco Romani has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 14: Verified+1
ok, *now* actually verified (previously I had some remnants of what then
evolved in
mooli tayer has posted comments on this change.
Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/constants.py.in
File
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Line 4582:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7337/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 3:
That's fine, too. Thogh I'd drop the obvious comment.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25173
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 7:
(2 comments)
I think we can improve the code even more by get rid of some function
arguments, if -as code
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7338/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7339/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: add missing requirement for sanlock on el7
..
spec: add missing requirement for sanlock on el7
In the el7 section we were missing the sanlock
Dan Kenigsberg has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 4: Verified+1 Code-Review+2
Not verified, but I'm tired of this one.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
..
Patch Set 1:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: add missing requirement for sanlock on el7
..
Patch Set 4:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: vm: fix migration progress calculation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25038
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
..
Patch Set 1: Code-Review-1
oh sorry. we have more locations were we load logging.config , modify
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 11:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Reload daemon file after each install
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/17/ : FAILURE
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
..
Patch Set 2:
Build Successful
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1:
(2 comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 2:
Build Successful
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: sos: Support to SOS 3
..
sos: Support to SOS 3
This patch will add support to sos 3 API and keep compatible
with old API.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support to SOS 3
..
Patch Set 1: Verified+1
Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sos: Support to SOS 3
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7344/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: Support to SOS 3
..
Patch Set 1:
Going to fix the jenkins alarm. new patch soon
--
To view, visit http://gerrit.ovirt.org/25188
To
Federico Simoncelli has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 1: Verified+1
Same as master.
--
To view, visit http://gerrit.ovirt.org/25006
To unsubscribe, visit
1 - 100 of 104 matches
Mail list logo
