Nir Soffer has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4: Code-Review-1
(5 comments)
The implementation is too complex and can be simplified to one line change.
There ar
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26112/2/vdsm/vdsm
File vdsm/vdsm:
Line 77: cif = clientIF.getInsta
Nir Soffer has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2:
Adding Eli - is is safe to allow 60 seconds timeout when stopping vdsm,
regarding engine timeouts?
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 2: -Code-Review
prepareForShutdown was false alarm - this is an internal method of the rpc
servers that shutdown t
Alon Bar-Lev has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2: Code-Review+1
I would even extend this more... no reason to limit 10 seconds, I would have go
to 60 seconds.
I
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 4:
Rebased over dependent patch. Verified on RHEL 6.5 and Fedora 19.
--
To view, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6895/ : SUCCESS
http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6893/ : SUCCESS
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6894/ : SUCCESS
h
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 2:
Rebase over dependent patch. Verified on RHEL 6.5 and Fedora 19.
Note: prepareForShutdown API currently broken.
Nir Soffer has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2: Verified+1
Add systemd and upstart support. Verified on RHEL 6.5 and Fedora 19.
--
To view, visit http://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/24495/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Li
Eduardo has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Code-Review-1
(1 comment)
Modern engines never try to call deactivateSD in order to migrate MSD.
P
Eduardo has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Code-Review-1
(2 comments)
How this patch solves the canDoAction engine warning logged in the BZ?
ht
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro
..
Patch Set 2: Verified+1
I could register a ovirt-node into engine.
--
To view, visit http://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 3: Verified+1
Verified running with and without profiling.
--
To view, visit http://gerrit.ovirt.org/26113
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: update sanlock dependencies
..
Patch Set 1: Code-Review-1
requires rebase and verify.
--
To view, visit http://gerrit.ovirt.org/12292
To uns
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 3:
Added profile_format option.
--
To view, visit http://gerrit.ovirt.org/26113
To unsubscribe, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6892/ : SUCCESS
h
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
Ah I got. Yes, I would prefer small and separate steps.
--
To view, visit http://gerrit.ov
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Patch Set 2: Verified+1
I have tested under ovirt-node the change, it generate the log under
/var/log/vdsm-reg
Dan Kenigsberg has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/26070/4/tests/utilsTests.py
File tests/utilsTests.py:
Line 469:
Li
Dan Kenigsberg has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/26070/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Li
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4: Code-Review+1
needs to be verified.
--
To view, visit http://gerrit.ovirt.org/2
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/25877/6/tests/samplingTests.py
File tests/sam
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6891/ : SUCCESS
htt
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 4:
patch set 4: fixed packaging
--
To view, visit http://gerrit.ovirt.org/26149
To unsubscribe, vi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: remove unused properties
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6890/ : SUCCESS
http://jenkins
Yeela Kaplan has uploaded a new change for review.
Change subject: oop: remove unused properties
..
oop: remove unused properties
As part of the plan to move from the use of oop
in vdsm to ioprocess, starting cleaning up.
Chang
Yaniv Bronhaim has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/26070/4/tests/utilsTests.py
File tests/utilsTests.py:
Line 464:
Li
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
i gave it +1. i just wanted more of this patch to also test this sanlock
configure class.. maybe later
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(5 comments)
hope that during next week http://gerrit.ovirt.org/#/c/25263/
Dan Kenigsberg has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24495/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
will do some testing again before to re-tick verified, even though changes in
last revision where
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6889/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
patch set 7: Dan kindly pointed me to a solution which should make everyone
happy
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6888/ : SU
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26121/3//COMMIT_MSG
Commit Message:
Line 11: or removin
Eduardo has posted comments on this change.
Change subject: Create storage domain using command type 1
..
Patch Set 7: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23646/7/vdsm/storage/blockSD.py
File vdsm/storage/bl
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sampl
mooli tayer has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 20:
(2 comments)
http://gerrit.ovirt.org/#/c/25263/20/lib/vdsm/tool/configurator.py
File lib/vdsm
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sampl
Yaniv Bronhaim has posted comments on this change.
Change subject: vm iface stats: fix arithmetic
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26088
To unsubscribe, visit http://gerrit.ovirt.org/sett
Yaniv Bronhaim has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2: -Code-Review
removing my score. i suggest to start the packaging procedure anyway
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 1: Verified+1
This is a backport for gss.
--
To view, visit http://gerrit.ovirt.org/26158
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 20:
(2 comments)
http://gerrit.ovirt.org/#/c/25263/20/lib/vdsm/tool/configurator.py
File lib/v
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1: Verified+1
This is a backport for gss.
--
To view, visit http://gerrit.ovirt.org/26157
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1: Verified+1
This is a backport for gss.
--
To view, visit http://gerrit.ovirt.org/26156
To unsubsc
Dan Kenigsberg has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26121/3//COMMIT_MSG
Commit Message:
Line 11: or rem
Nir Soffer has uploaded a new change for review.
Change subject: clientIF: Clean up shutdown process
..
clientIF: Clean up shutdown process
clientIF.serve used to check if shutdown process has started once every
3 seconds, leadi
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Add an application wide profile
..
profiling: Add an application wide profile
The built in Python profilers are good for single thread profile but
given
Nir Soffer has uploaded a new change for review.
Change subject: sysvinit: Give vdsm enough time to write profile
..
sysvinit: Give vdsm enough time to write profile
Previously vdsm was killed brutally if it did exit 2 seconds a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6881/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7590/ : SUCCESS
http:
Eduardo has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 362:
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Li
Vinzenz Feenstra has posted comments on this change.
Change subject: drop ominous log for libvirt errors
..
Patch Set 1:
If we wouldn't swallow so many exceptions all over the place, I wouldn't have a
problem with that. But vd
Omer Frenkel has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 362: if
Dan Kenigsberg has posted comments on this change.
Change subject: drop ominous log for libvirt errors
..
Patch Set 1:
Was this log line helpful in its 11 months of existence? To me it causes only
confusion and lost heart beat
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2: Code-Review-1
-1 until what Vinzenz noted is addressed.
--
To view, visit http://gerrit.ovirt.
Vinzenz Feenstra has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26142/1//COMMIT_MSG
Commit Message:
Line 8:
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 3:
(2 comments)
Commit message needs more love.
http://gerrit.ovirt.org/#/c/26121/3//COMMIT_MSG
Co
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2:
There is no such package, and it will take ages until we can get it into
Fedora/EL. So either we ship it
Francesco Romani has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26142/1//COMMIT_MSG
Commit Message:
Line 8:
Nir Soffer has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1:
We don't have such configuration (2 seconds timeout) the systemd and upstart
configuration, so we
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6887/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6886/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1: Code-Review-1
I'm fine with extending the grace period to 10 seconds - if that's tested to be
Yaniv Bronhaim has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/26070/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 674:
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26149/1/vdsm/caps.py
File vdsm/caps.py:
Line 181:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6885/ : SU
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/9//COMMIT_MSG
Commit Message:
Line 12: There
> I wonder what u
Michal Skrivanek has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26149/1/vdsm/caps.py
File vdsm/caps.py:
Line 181:
Yaniv Bronhaim has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2: Code-Review-1
you must to have yappi package on your local setup when running vdsm, and then
we need
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1: Code-Review-1
Yaniv found that there is a prepareForShutdown API - this will not work now.
Need to check if thi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6884/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 1:
This is the implementation of
https://bugzilla.redhat.com/show_bug.cgi?id=1009100#c11
--
To vi
Francesco Romani has uploaded a new change for review.
Change subject: caps: report if QEMU supports live snapshots
..
caps: report if QEMU supports live snapshots
Depending on QEMU version and configuration, live snapshotting
m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6883
Vinzenz Feenstra has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 9:
(2 comments)
http://gerrit.ovirt.org/#/c/25927/9/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm
Barak Azulay has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/9/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_hook
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6882/ : SUCCESS
http://jenkins.ov
Martin Peřina has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Barak Azulay has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/9/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_hook
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6881/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: drop ominous log for libvirt errors
..
Patch Set 1: Code-Review-1
Well as michal said we need this for post mortem debugging.
--
To view, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6880/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6879/ :
Nir Soffer has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26121/2//COMMIT_MSG
Commit Message:
Line 12:
Line 13: Alt
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Create GuestAgent instance in __init__ and connect later
This is not only a cosmetic improvement.
Nir Soffer has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26121/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6878/ : SUCCE
Yaniv Bronhaim has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26112/1/vdsm/vdsm
File vdsm/vdsm:
Line 77: cif = clientIF.getI
Martin Peřina has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 5:
> This should not be reported as a part of the stats, but as a part of
> capabilities. once configured it is rare
Yaniv Bronhaim has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1: Code-Review+1
dan, 10 seconds before sigkill is totally fine. 2 secs are way too fast. i
don't
Yaniv Bronhaim has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26113
To unsubscribe, visit http://gerrit.ov
Antoni Segura Puimedon has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://ge
1 - 100 of 115 matches
Mail list logo
