Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

Yaniv Bronhaim has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34639 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: netinfo:nicSpeed(): fix nicSpeed condition

Yaniv Bronhaim has submitted this change and it was merged. Change subject: netinfo:nicSpeed(): fix nicSpeed condition .. netinfo:nicSpeed(): fix nicSpeed condition In `if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s > 0` first par

Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

Yaniv Bronhaim has submitted this change and it was merged. Change subject: volume: Log the correct error when creating a volume fails .. volume: Log the correct error when creating a volume fails When a volume creation failed

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

Yaniv Bronhaim has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34617 To unsubscribe, visit http://gerrit.o

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

Yaniv Bronhaim has submitted this change and it was merged. Change subject: caps: Additional ppc64 hardware information .. caps: Additional ppc64 hardware information Includes extra information (manufacturer and product name) a

Change in vdsm[ovirt-3.5]: netinfo:nicSpeed(): fix nicSpeed condition

oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo:nicSpeed(): fix nicSpeed condition .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/67/

Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x8

Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13317/ : SUCCESS

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/69/

Change in vdsm[master]: vdsm: refactored new functional tests

Yoav Kleinberger has posted comments on this change. Change subject: vdsm: refactored new functional tests .. Patch Set 1: there's some merit to Nir's comments. Maybe this refactoring should be reverted. -- To view, visit htt

Change in vdsm[master]: signals: Handle signals to non-main threads

oVirt Jenkins CI Server has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13318/ : SUCCES

Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13319/ : FAILURE

Change in vdsm[master]: signals: Handle signals to non-main threads

oVirt Jenkins CI Server has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13320/ : FAILUR

Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28915 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

Saggi Mizrahi has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28915 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: signals: Handle signals to non-main threads

Nir Soffer has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/29392/18/lib/vdsm/sigutils.py File lib/vdsm/sigutils.py: Line

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47

mooli tayer has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33771/5/vdsm.spec.in File vdsm.spec.in: Line 26

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47

Eyal Edri has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 5: Code-Review-1 putting -1 until all jenkins slaves will be upgraded to 6.6, otherwise it wil

Change in vdsm[master]: vm: sync device update during creation of a vm

Saggi Mizrahi has posted comments on this change. Change subject: vm: sync device update during creation of a vm .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34599 To unsubscribe, visit http://gerrit

Change in vdsm[master]: cache: Add caching decorator with invalidation

Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 1: Code-Review-1 There is already a memoized() in utils.py. There should only be one. Please either u

Change in vdsm[master]: cache: Add caching decorator with invalidation

Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 1: Just noticed that future patches unify memoized(). So just fix the other sutff. -- To view, visi

Change in vdsm[master]: cache: Add caching decorator with invalidation

Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 1: Also have your memozied work parameterless as well. -- To view, visit http://gerrit.ovirt.org/34

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

Saggi Mizrahi has posted comments on this change. Change subject: qemuimg: Memoize _supports_qcow2_compat .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34711 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: spec: remove redundant 'Requires(X): policycoreutils-python'.

mooli tayer has uploaded a new change for review. Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'. .. spec: remove redundant 'Requires(X): policycoreutils-python'. Having an rpm as both 'Required' an

Change in vdsm[master]: spec: remove redundant check.

oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13321/ : FAILURE http://jenki

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1

Change in vdsm[master]: signals: Handle signals to non-main threads

Saggi Mizrahi has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 18: Code-Review-1 (2 comments) Move to /lib/vdsm/infra/ http://gerrit.ovirt.org/#/c/29392/18/lib/vdsm/

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

mooli tayer has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 6: Verified-1 Waiting on integration, See Eyal's comment. -- To view, visit http://gerrit

Change in vdsm[master]: spec: remove redundant 'Requires(X): policycoreutils-python'.

oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_create

Change in vdsm[master]: Convert VM from external source to Data Domain

Shahar Havivi has posted comments on this change. Change subject: Convert VM from external source to Data Domain .. Patch Set 13: Verified-1 Do not review -- To view, visit http://gerrit.ovirt.org/34294 To unsubscribe, visit

Change in vdsm[master]: Convert VM from external source to Data Domain

oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert VM from external source to Data Domain .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13324/ : SUC

Change in vdsm[master]: cache: Add caching decorator with invalidation

Nir Soffer has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 2: Verified+1 Version 2 address Saggi comments: - Beautify the api - Add missing tests for memoizing fun

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

oVirt Jenkins CI Server has posted comments on this change. Change subject: qemuimg: Memoize _supports_qcow2_compat .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13326/ : SUCCESS ht

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

Nir Soffer has posted comments on this change. Change subject: cache: Replace utils.memoized with cache.memoized() .. Patch Set 2: Version 2 is rebased and minimize the change in utils.py. -- To view, visit http://gerrit.ovir

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

Nir Soffer has posted comments on this change. Change subject: qemuimg: Memoize _supports_qcow2_compat .. Patch Set 2: Version 2 clarify the code using the new memoize api. -- To view, visit http://gerrit.ovirt.org/34711 To u

Change in vdsm[master]: cache: Add caching decorator with invalidation

oVirt Jenkins CI Server has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13327/ : SUCC

Change in vdsm[master]: cache: Add caching decorator with invalidation

Nir Soffer has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 2: Saggi, I'm not sure how do you want to move this into the infra package, so lets do this later. --

Change in vdsm[master]: External hypervisor VMs integration

Nir Soffer has posted comments on this change. Change subject: External hypervisor VMs integration .. Patch Set 16: (4 comments) http://gerrit.ovirt.org/#/c/33309/16/vdsm/v2v.py File vdsm/v2v.py: Line 63: return size

Change in vdsm[master]: netinfo, tool: Make the bonding defaults a proper Python file

Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Make the bonding defaults a proper Python file .. Patch Set 4: Toni, ls -Z for bonding_defaults.py shows system_u:object_r:lib_t:s0 (the same as

Change in vdsm[master]: External hypervisor VMs integration

Nir Soffer has posted comments on this change. Change subject: External hypervisor VMs integration .. Patch Set 16: (3 comments) http://gerrit.ovirt.org/#/c/33309/16/tests/v2vTests.py File tests/v2vTests.py: Line 82: @Mon

Change in vdsm[master]: gluster: geo replication status and status detail

Sahina Bose has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18414 To unsubscribe, visit http://gerri

Change in vdsm[master]: virt: move vm.GraphicsDevice -> vmdevices.Graphics

Francesco Romani has posted comments on this change. Change subject: virt: move vm.GraphicsDevice -> vmdevices.Graphics .. Patch Set 1: (1 comment) I see your point. Let's take a bit of time to discuss how to make this code n