Change in vdsm[master]: supervdsm: use os.path instead of string concatenation

2015-01-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: supervdsm: use os.path instead of string concatenation .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/37226/2/vdsm/supervdsmServer

Change in vdsm[master]: hostdev: add support for reporting pci addresses

2015-01-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add support for reporting pci addresses .. Patch Set 10: Code-Review+1 looks OK - +1 -- To view, visit http://gerrit.ovirt.org/35651 To

Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

2015-01-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 6: Code-Review+1 thought about naming (shellcmds? shell?) but can't find anything valuable

Change in vdsm[master]: protocoldetector: Make cleanup more deterministic

2015-01-23 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: protocoldetector: Make cleanup more deterministic .. protocoldetector: Make cleanup more deterministic Protocol detector was setting the next cleanup time on each

Change in vdsm[master]: protocoldetector: Make cleanup more deterministic

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Make cleanup more deterministic .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37248 To unsubscribe, visit

Change in vdsm[master]: tests: Fix too delicate tests

2015-01-23 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Fix too delicate tests .. tests: Fix too delicate tests protocoldector tests were assuming that another thread will wake up exactly after 2.0 seconds, and

Change in vdsm[master]: tests: Fix too delicate tests

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix too delicate tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37249 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Fix too delicate tests

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix too delicate tests .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15380/ : SUCCESS

Change in vdsm[master]: protocoldetector: Make cleanup more deterministic

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Make cleanup more deterministic .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15379/ :

Change in vdsm[master]: protocoldetector: Make cleanup more deterministic

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Make cleanup more deterministic .. Patch Set 1: These brittle tests never fail on my laptop, but running them on fedora 21 vm revealed this

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15382/ : SUCCESS

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15383/ : FAILURE

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15381/ : SUCCESS

Change in vdsm[master]: utils: add CommandStream class

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/33909/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 356: #

Change in vdsm[master]: executor: introduce the executor library

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: executor: introduce the executor library .. Patch Set 31: (1 comment) http://gerrit.ovirt.org/#/c/29191/31/lib/vdsm/executor.py File lib/vdsm/executor.py:

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15364/ : SUCCESS

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Verified+1 Built OK, passed network's functional tests and netlinkTests. Plus manually tested -- To view,

Change in vdsm[master]: supervdsm: use os.path instead of string concatenation

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: supervdsm: use os.path instead of string concatenation .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37226/2/vdsm/supervdsmServer File

Change in vdsm[master]: vm: Support LSM in mixed storage domains

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Support LSM in mixed storage domains .. Patch Set 11: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS

Change in vdsm[master]: gluster: volume snapshot create and delete verbs.

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 14: Build Failed

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 2: Verified+1 Built OK, passed network's functional tests. -- To view, visit http://gerrit.ovirt.org/37239 To

Change in vdsm[master]: vm: Support LSM in mixed storage domains

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Support LSM in mixed storage domains .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15373/ : SUCCESS

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 5: Code-Review+1 Very clean, amazing work (including the already merged patches). -- To view, visit

Change in vdsm[master]: vm: Update device after migration

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Update device after migration .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15374/ : SUCCESS

Change in vdsm[master]: vm: Support LSM in mixed storage domains

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Support LSM in mixed storage domains .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15376/ : SUCCESS

Change in vdsm[master]: vm: Monitor replicated file based drive

2015-01-23 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: vm: Monitor replicated file based drive .. Abandoned Seems to be the wrong approach. -- To view, visit http://gerrit.ovirt.org/37235 To unsubscribe, visit

Change in vdsm[master]: vm: Update device after migration

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Update device after migration .. Patch Set 4: Verified-1 -- To view, visit http://gerrit.ovirt.org/37236 To unsubscribe, visit

Change in vdsm[master]: vm: Update device after migration

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Update device after migration .. Patch Set 4: Code-Review-1 It does not work, keeping here for discussion. -- To view, visit http://gerrit.ovirt.org/37236 To

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15375/ : SUCCESS

Change in vdsm[master]: vm: Update device after migration

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Update device after migration .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15377/ : SUCCESS

Change in vdsm[master]: gluster: volume snapshot create and delete verbs.

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 13: (4 comments) http://gerrit.ovirt.org/#/c/34535/13//COMMIT_MSG Commit Message: Line 16:

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: -Code-Review -Verified Build Failed

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/37239/2/tests/functional/networkTests.py File

Change in vdsm[master]: executor: introduce the executor library

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: executor: introduce the executor library .. Patch Set 31: (1 comment) http://gerrit.ovirt.org/#/c/29191/31/lib/vdsm/executor.py File lib/vdsm/executor.py: Line

Change in vdsm[master]: gluster: Added geo-replication session list and session status

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: Added geo-replication session list and session status .. Patch Set 18: Verified+1 -- To view, visit http://gerrit.ovirt.org/18414 To unsubscribe, visit

Change in vdsm[master]: gluster: Added geo-replication session list and session status

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: Added geo-replication session list and session status .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/18414/17/vdsm/gluster/cli.py File

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: netlink: replace ipwrapper monitor .. netlink: replace ipwrapper monitor Change-Id: Ife2ee7d16c79eea7c8ed1f0780aafbaa00356978 Signed-off-by: Petr Horáček

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15363/ : SUCCESS

Change in vdsm[master]: network: synced configs

2015-01-23 Thread phoracek
Petr Horáček has abandoned this change. Change subject: network: synced configs .. Abandoned -- To view, visit http://gerrit.ovirt.org/35031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon

Change in vdsm[master]: executor: introduce the executor library

2015-01-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: executor: introduce the executor library .. Patch Set 31: (2 comments) http://gerrit.ovirt.org/#/c/29191/31/lib/vdsm/executor.py File lib/vdsm/executor.py:

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15366/ : SUCCESS

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 3: Verified+1 Passed netlink tests -- To view, visit http://gerrit.ovirt.org/37241 To unsubscribe, visit

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 4: Verified+1 Built OK, passed network's functional tests. -- To view, visit http://gerrit.ovirt.org/37239 To

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: handy monitor context manager .. netlink: handy monitor context manager Change-Id: I1065e4cffc8612c2448bb08c80ac3cc255ca883c Signed-off-by:

Change in vdsm[master]: gluster: Added geo-replication session list and session status

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added geo-replication session list and session status .. Patch Set 18: Build Failed

Change in vdsm[master]: virt: add ExpiringSet

2015-01-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringSet .. Patch Set 4: (5 comments) http://gerrit.ovirt.org/#/c/36716/4//COMMIT_MSG Commit Message: Line 7: virt: add ExpiringSet Line 8:

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: netlink: handy monitor context manager .. netlink: handy monitor context manager Change-Id: I1065e4cffc8612c2448bb08c80ac3cc255ca883c Signed-off-by: Petr

Change in vdsm[master]: extra_ipv4_addrs_hook: Add a hook for configuring secondary ...

2015-01-23 Thread dcaroest
David Caro has posted comments on this change. Change subject: extra_ipv4_addrs_hook: Add a hook for configuring secondary addrs .. Patch Set 2: Code-Review+1 Looks good to me, haven't tested it yet though -- To view, visit

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15369/ : SUCCESS

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 4: Verified+1 Passed netlink tests -- To view, visit http://gerrit.ovirt.org/37241 To unsubscribe, visit

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15370/ : SUCCESS

Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/34638 To unsubscribe, visit

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15371/ : SUCCESS

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37239 To unsubscribe, visit

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37239/4/tests/functional/networkTests.py File

Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 7: Build Failed

Change in vdsm[master]: gluster: volume snapshot list and snapshot list verbs.

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: volume snapshot list and snapshot list verbs. .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36087/10//COMMIT_MSG Commit Message: Line 26:

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 2: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: netlink: handy monitor context manager

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: handy monitor context manager .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37241 To unsubscribe, visit

Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

2015-01-23 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34638/6/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line

Change in vdsm[master]: netlink: event monitor with timeout

2015-01-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: event monitor with timeout .. netlink: event monitor with timeout Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Signed-off-by: Petr

Change in vdsm[master]: utils: add CommandStream class

2015-01-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/33909/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 341: Line 342:

Change in vdsm[master]: networkTests: order VDSM modules after its libraries

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: order VDSM modules after its libraries .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37036 To unsubscribe, visit

Change in vdsm[master]: networkTests: stop NetworkManager from managing ifaces using...

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing ifaces using NM_CONTROLLED=no .. Patch Set 3: (2 comments)

Change in vdsm[master]: networkTests: order VDSM libraries after system libraries

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: order VDSM libraries after system libraries .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37035 To unsubscribe, visit

Change in vdsm[master]: netlink: replace ipwrapper monitor

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netlink: replace ipwrapper monitor .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37239/5/tests/functional/networkTests.py File

Change in vdsm[master]: networkTests: do not confuse dhclient with invalid configura...

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: do not confuse dhclient with invalid configuration .. Patch Set 1: Code-Review-1 (1 comment)

Change in vdsm[master]: networkTests: stop NetworkManager from managing ifaces using...

2015-01-23 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing ifaces using NM_CONTROLLED=no .. Patch Set 3: (1 comment) Further comments.

Change in vdsm[master]: networkTests: stop NetworkManager from managing ifaces using...

2015-01-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing ifaces using NM_CONTROLLED=no .. Patch Set 3: Code-Review-1 (2 comments)

Change in vdsm[master]: utils: NoIntr* references moved from misc to utils

2015-01-23 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: utils: NoIntr* references moved from misc to utils .. Patch Set 4: Code-Review-1 (1 comment) Nice, but please move the sorting of imports to a patch of (on?)

Change in vdsm[master]: vm: Support LSM in mixed storage domains

2015-01-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Support LSM in mixed storage domains .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15378/ : SUCCESS