Dan Kenigsberg has posted comments on this change.
Change subject: zombiereaper: Raise if used incorrectly
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37260
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: Fix extend size calculation
..
Patch Set 1:
(4 comments)
a few initial comments
http://gerrit.ovirt.org/#/c/37274/1/vdsm/virt/vm.py
File
Nir Soffer has posted comments on this change.
Change subject: vm: Fix extend size calculation
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/37274/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1411:
Line 1412:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Fix extend size calculation
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15399/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vm: LSM between mixed domain types
..
Patch Set 15:
This version addresses Francesco comments.
--
To view, visit http://gerrit.ovirt.org/37095
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: vm: Fix extend size calculation
..
Patch Set 2:
This version addresses Francesco comments.
--
To view, visit http://gerrit.ovirt.org/37274
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: LSM between mixed domain types
..
Patch Set 15: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15402/ : FAILURE
Adam Litke has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36923
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 2:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36923
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: rename _getVmNumaNodesCpuMap for clarity
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6349/
Adam Litke has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36924
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: Retry sync on recoverable errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36922/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4952:
Adam Litke has abandoned this change.
Change subject: Live Merge: Retry sync on recoverable errors
..
Abandoned
Based on review, this is not needed.
--
To view, visit http://gerrit.ovirt.org/36922
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: DRAFT: v2v: Convert VM from external source to Data Domain
..
Patch Set 41: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: rename variables for clarity
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6350/ :
SUCCESS
Shahar Havivi has posted comments on this change.
Change subject: DRAFT: v2v: Convert VM from external source to Data Domain
..
Patch Set 41: Verified-1
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 12: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/36263/12/vdsm/rpc/vdsmapi-schema.json
File
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/36263
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15401/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Revert hba: Run fc-scan in supervdsm
..
Patch Set 2: Code-Review+2
big oopsy.
--
To view, visit http://gerrit.ovirt.org/37261
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: LSM between mixed domain types
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/37095/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1471:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: numa: reformat to be pep8-friendlier
..
numa: reformat to be pep8-friendlier
reformat and make the code more pep8 compliant
to improve readability,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: numa: avoid needless list comprehension
..
numa: avoid needless list comprehension
A generator expression fits better and achieves
the same result.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: numa: use defaultdict to simplify the code
..
numa: use defaultdict to simplify the code
Leverage defaultdict(set) instead of reinventing it
locally
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 2:
(5 comments)
Mostly ok, but will have to invest more time in this. Added few comments and
questions.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: use defaultdict to simplify the code
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15406/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: reformat to be pep8-friendlier
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15404/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: avoid needless list comprehension
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15405/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: numa: use defaultdict to simplify the code
..
Patch Set 5: Verified+1
verified again with tests both on RHEL6.6 and on Fedora 21.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: numa: avoid needless list comprehension
..
Patch Set 6:
rebased.
--
To view, visit http://gerrit.ovirt.org/36663
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: numa: reformat to be pep8-friendlier
..
Patch Set 4:
rebased.
--
To view, visit http://gerrit.ovirt.org/37160
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: numa: use defaultdict to simplify the code
..
Patch Set 6:
rebased.
--
To view, visit http://gerrit.ovirt.org/36662
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: numa: use defaultdict to simplify the code
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6368/ :
Timothy Asir has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 2: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/37281/2//COMMIT_MSG
Commit Message:
Line 6:
Timothy Asir has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 2: -Verified Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37281
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37281
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/37281/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15407/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15408/ :
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 12:
(2 comments)
http://gerrit.ovirt.org/#/c/36263/12/vdsm/rpc/vdsmapi-schema.json
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: separate top level vm information to a method
..
v2v: separate top level vm information to a method
for a clearer code separate general vm
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: separate top level vm information to a method
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36784
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: LSM between mixed domain types
..
Patch Set 14:
(6 comments)
few initial comments to put my foot in the water
Francesco Romani has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 11: Code-Review-1
(1 comment)
I stumbled in an error on the tests.
Vinzenz Feenstra has posted comments on this change.
Change subject: vmchannels: downgrade logs about expected flows
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34357
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: mark testRunningStats as broken
..
tests: mark testRunningStats as broken
tests/vmApiTests was an early attempt to test that
the output of API verbs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: mark testRunningStats as broken
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15394/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: mark testRunningStats as broken
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15396/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36923/1/vdsm/virt/vm.py
File
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 1:
(1 comment)
Thanks for the answer!
Do you plan for a tighter integration of this code with followup
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: mark testRunningStats as broken
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15395/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: mark testRunningStats as broken
..
Patch Set 2: Verified+1
version 2 improves the commit message.
Verified running 'make check' - the new test is no
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: add debug log for getStats()
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36732
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/36263/11/tests/v2vTests.py
File tests/v2vTests.py:
Line 78: def
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: mark testRunningStats as broken
..
tests: mark testRunningStats as broken
tests/vmApiTests was an early attempt to test that
the output of API
Dan Kenigsberg has posted comments on this change.
Change subject: tests: mark testRunningStats as broken
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37275
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 1:
(1 comment)
Only looked at Francesco comment, will review later.
Dan Kenigsberg has posted comments on this change.
Change subject: Handle iscsi iface.net_ifacename for existing iface
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35976
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Handle iscsi iface.net_ifacename for existing iface
..
Handle iscsi iface.net_ifacename for existing iface
Using a new version of engine which
Nir Soffer has posted comments on this change.
Change subject: vm: LSM between mixed domain types
..
Patch Set 14:
(6 comments)
Thanks for the review!
http://gerrit.ovirt.org/#/c/37095/14//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Add geo-replication start and stop session
..
gluster: Add geo-replication start and stop session
This patch adds two new verbs to start and
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 14: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/17766/14/vdsm.spec.in
File
Dan Kenigsberg has uploaded a new change for review.
Change subject: schema test: limit line length in gluster schema
..
schema test: limit line length in gluster schema
Change-Id: I90b3a758dfea6c285d440d684dc2cde9f984f4d4
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema test: limit line length in gluster schema
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15397/ :
66 matches
Mail list logo
