Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 4: Verified-1
We do not send heartbeats anymore.
--
To view, visit https://gerrit.ovirt.org/38451
To
Dima Kuznetsov has posted comments on this change.
Change subject: Adding Vdsm cron job check for available packages update
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/38401/4/vdsm/updater-tool
File
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 5:
Using engine 3.5 to host install vdsm and seeing no communication issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Fetch disperse count and redundacy count for volume
..
Patch Set 5: Code-Review+1
Schema change looks good
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1388:
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 6: Verified-1
We do not send heartbeats anymore.
--
To view, visit https://gerrit.ovirt.org/36368
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: contrib: Add tool for getting repoStats statistics
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16682/ :
Piotr Kliczewski has posted comments on this change.
Change subject: API: honor onlyUUID only if short status is asked
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 7: Verified+1
Using engine 3.5 to host install vdsm and seeing no communication issues.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Adding Vdsm cron job check for available packages update
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
oVirt Jenkins CI Server has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 12:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 3:
Build Successful
Fred Rolland has posted comments on this change.
Change subject: hsm: Add refresh device command
..
Patch Set 1:
Draft version, not test yet
--
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 13:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 4:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: convert print statements to functions
..
Patch Set 3: Verified+1
Verified by passing unit tests, running funtion network tests, running
vdsClient, and running
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: enhanced storageDevicesList function
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: introduce the services infrastracture
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 27:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: _get_gateway: allow duplicated gateways if they are in fact the
same routes
..
Patch Set 2:
* Update tracker::#1186330::OK
* Check Bug-Url::OK
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 26:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: bootstrap services using updateVolume
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 1:
* Update tracker::#1176673::OK
* Check Bug-Url::OK
* Check Public Bug::#1176673::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: _bridges_ should be among devices with active DHCP
leases
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: storageServer: Add log when isSession fails.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: _bridges_ should be among devices with active DHCP
leases
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Ido Barkan has uploaded a new change for review.
Change subject: no need for quotes in supervdsmd service file
..
no need for quotes in supervdsmd service file
systemd interprets them as part of the string
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: report a gateway for statically configured networks
..
Patch Set 7:
* Update tracker::#1186330::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: Comment out broken partial code
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: sdm: createVolumeV2 does not return a task
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make MBPS_TO_BPS a module constant
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: sdm: add the allocateVolume command
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make _getNicStats a function
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: ipwrapper: remove the unused function 'routeList'
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: restore cpu tuning samples
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/37327
To
automat...@ovirt.org has posted comments on this change.
Change subject: _get_gateway: reformat a list comprehension for readability
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: sdm: fix the getHostId interface to DomainMonitor
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37097/5/lib/yajsonrpc/stompReactor.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 4: Code-Review+1
api and schema related changes look good
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 5: Verified+1
I verified this patch together with all other patches in events topic. I have
seen
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37056/5/lib/yajsonrpc/stomp.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 4: Verified+1
I verified this patch together with all other patches in events topic. I have
seen not issues
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD
..
Patch Set 4: Verified+1
I verified this patch together with all other patches in events topic. I have
seen
Piotr Kliczewski has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Code-Review+1
Please take a look at comment of Host_getVMList_Call method:
This call
Piotr Kliczewski has posted comments on this change.
Change subject: broker_support
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36368/1/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 27:
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 3:
I fixed my own comments and moved some pieces of the code from later patches in
order to make the
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Remove AsyncChat
..
Patch Set 4: Verified+1
I verified this patch together with all other patches in events topic. I have
seen not issues with it.
Piotr Kliczewski has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29817
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 20: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35498/20/vdsm/rpc/vdsmapi-gluster-schema.json
File
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Add memoized invalidation
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37788
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37056/5/lib/yajsonrpc/stomp.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP] EVENTS
..
Patch Set 1: Code-Review-1
(14 comments)
http://gerrit.ovirt.org/#/c/38069/1/lib/stompClient.py
File lib/stompClient.py:
Line 74:
Line 75:
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 5: Verified+1
I verified this patch together with all other patches in events topic. I have
seen
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/37051/5/lib/vdsm/infra/eventfd/__init__.py
File
Madhu Pavan has uploaded a new change for review.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
tests: InterfaceSampleTests are failing with IOError
Both testHostSampleHandlesDisappearingVlanInterfaces
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 4: Verified+1
I verified this patch together with all other patches in events topic. I have
Madhu Pavan has abandoned this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Abandoned
I have opened another review. Please ignore this.
--
To view, visit http://gerrit.ovirt.org/38105
To
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/35498/17/vdsm/rpc/vdsmapi-gluster-schema.json
File
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/37098/3/lib/yajsonrpc/betterAsyncore.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 5: Verified+1
I verified this patch together with all other patches in events topic. I have
seen not issues with
Madhu Pavan has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35936
To
Piotr Kliczewski has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 3: Verified+1
Verified both protocols with engine with and without the patch. For both tests
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 7: Verified+1
I built it and updated existing version of vdsm. After starting vdsmd
communication
Piotr Kliczewski has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 2: Verified+1
Tested following scenarios:
- running the engine without the fix
- running the
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 7: Verified+1
Fixing Federico's comment. Verified change by running tests during build
process. Copying verify
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 6: Verified+1
I built it and updated existing version of vdsm. After starting vdsmd
communication with the
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 8:
Will move
--
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: subscriptions
..
subscriptions
Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
---
M
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/37051/6/lib/vdsm/infra/eventfd/__init__.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/38449/2//COMMIT_MSG
Commit Message:
Line 9:
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 7:
Will resubmit the patches soon. I have been working on subscriptions recently.
--
To view, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: api: introducing short parameter for getVMList verb
..
api: introducing short parameter for getVMList verb
Due to vdsm sending only an array of vmids in a
Piotr Kliczewski has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
It is a revert so marking verify flag
--
To view, visit https://gerrit.ovirt.org/38433
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/37056/6/lib/yajsonrpc/stomp.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: [WIP] EVENTS
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38069/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 212:
Line 213: def
Madhu Pavan has uploaded a new change for review.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
tests: InterfaceSampleTests are failing with IOError
Both testHostSampleHandlesDisappearingVlanInterfaces
Madhu Pavan has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 5:
Rebased and moved spec change. No other changes.
--
To view, visit https://gerrit.ovirt.org/37051
To
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 20: Code-Review+1
api and schema related changes looks good
--
To view, visit
Madhu Pavan has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/37057/8/lib/yajsonrpc/betterAsyncore.py
File
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/betterAsyncore.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 4: Verified+1
I built it and updated existing version of vdsm. After starting vdsmd
communication
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 6: Verified+1
I built it and updated existing version of vdsm. After starting vdsmd
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 5: Verified+1
I verified this patch together with all other patches in events topic. I have
seen
Piotr Kliczewski has posted comments on this change.
Change subject: Have the protocol detector use the Reactor
..
Patch Set 2: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/37098/2/vdsm/protocoldetector.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: forbid tabs in schema
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37697
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: betterAsyncore: Bind the dispatcher implementation
..
Patch Set 6: Verified+1
I verified this patch together with all other patches in events topic. I have
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 8:
Good point will move betterAsyncore changes around AsyncoreEvent to this patch.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 7: Verified+1
I built it and updated existing version of vdsm. After starting vdsmd
communication
701 - 800 of 3042 matches
Mail list logo