Change in vdsm[master]: net: simplify _find_nets_with_available_devices algorithm.

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: simplify _find_nets_with_available_devices algorithm. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url fo

Change in vdsm[master]: network: do not try to clean running configuration

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: network: factor out method from unified restoration logic.

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url fo

Change in vdsm[master]: net: factor out _find_bonds_with_available_nics

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: factor out _find_bonds_with_available_nics .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: clearer log for unavailable bonds .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, ma

Change in vdsm[master]: net: factor out _find_nets_with_available_devices.

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: factor out _find_nets_with_available_devices. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode

2015-05-06 Thread ibarkan
Ido Barkan has abandoned this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Abandoned this is not needed atm -- To view, visit https://gerrit.ovirt.org/40573 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40573 To un

Change in vdsm[master]: net: remove el6 support for libnl binding

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: vdsm: implement NUMA aware KSM policy

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#840114::ERROR, private bug * Check Pub

Change in vdsm[master]: network: Recognize macvlans as fake devices

2015-05-06 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: gluster: Refactor GlusterFSConnection class

2015-05-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40575/3/vdsm/storage/storageServer.py File vdsm/storage/stora

Change in vdsm[master]: network: Recognize macvlans as fake devices

2015-05-06 Thread fabiand
Fabian Deutsch has uploaded a new change for review. Change subject: network: Recognize macvlans as fake devices .. network: Recognize macvlans as fake devices macvlans are yet another type of virtual NICs. This patch allows vds

Change in vdsm[master]: network: Recognize macvlans as fake devices

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: network: persist sriov devices number of vfs

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...

2015-05-06 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Code-Review+1 yes. you are right. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WA

Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Ido, I don't think this patch depends on the later one. It does one

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: clearer log for unavailable bonds .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40542 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: net: simplify _find_nets_with_available_devices algorithm.

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: simplify _find_nets_with_available_devices algorithm. .. Patch Set 1: Code-Review+1 (1 comment) One comment (not introduced in this patch) seems wrong to

Change in vdsm[master]: net: factor out _find_nets_with_available_devices.

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: factor out _find_nets_with_available_devices. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40540 To unsubscribe, visit https:/

Change in vdsm[master]: net: factor out _find_bonds_with_available_nics

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: factor out _find_bonds_with_available_nics .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40539 To unsubscribe, visit https://ge

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40538 To unsubscribe, visit https:

Change in vdsm[master]: network: do not try to clean running configuration

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 1: Code-Review-1 (2 comments) Much clearer! Just fix the typos for me :-) https://gerrit.ovirt

Change in vdsm[master]: network: factor out method from unified restoration logic.

2015-05-06 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 1: Code-Review+1 Nice :-) -- To view, visit https://gerrit.ovirt.org/40536 To unsubscr

Change in vdsm[master]: spec: Drop el6 support

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: spec: Drop el6 support

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.

2015-05-06 Thread dnarayan
Darshan N has uploaded a new change for review. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. gluster: Modified volumeReplaceBrickCommit verb. This patch modifies volumeReplaceBrickCommit verb, this verb wa

Change in vdsm[master]: hooks: ovs

2015-05-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs .. Patch Set 18: Code-Review-1 (1 comment) very partial review... https://gerrit.ovirt.org/#/c/40312/18/vdsm_hooks/ovs/ovs_before_device_create.py

Change in vdsm[master]: hooks: ovs

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: Add support for specifying vm maximum memory

2015-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: Add support for specifying vm maximum memory .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/40547/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi

Change in vdsm[master]: gluster: Refactor GlusterFSConnection class

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: Refactor GlusterFSConnection class

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: Refactor GlusterFSConnection class

2015-05-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: gluster: Refactor GlusterFSConnection class .. gluster: Refactor GlusterFSConnection class Refactor GlusterFSConnection class to delegate calls to MountConnection in

Change in vdsm[master]: network: restore sriov devices number of vfs

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, n

Change in vdsm[master]: gluster: Refactor GlusterFSConnection class

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 1: * Update tracker::#117::OK * Check Bug-Url::OK * Check Public Bug::#117::OK, public bu

Change in vdsm[master]: hooks: ovs

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: * Update tracker::#1216900::OK * Check Bug-Url::OK * Check Public Bug::#1216900::OK, public bug * Check

Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...

2015-05-06 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, v

Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode

2015-05-06 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: Teach utils.rmFile to handle ovirtNode .. Teach utils.rmFile to handle ovirtNode We need to handle files in other places in vdsm so moving it down the file hierarc

Change in vdsm[master]: net: remove el65 support for libnl binding

2015-05-06 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 3: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug

Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support

2015-05-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Code-Review+1 code and code path should be the same as master -- To view, visit https://gerrit.ovirt.org/4

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-05-06 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-05-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: (3 comments) a few questions inside https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py Fil

Change in vdsm[master]: net: remove el65 support for libnl binding

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: net: remove el65 support for libnl binding

2015-05-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

<    1   2