Fabian Deutsch has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/29770
To unsubscri
Timothy Asir has posted comments on this change.
Change subject: gluster: fix vg create failed first time during brick create
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41392/8//COMMIT_MSG
Commit Message:
Line 1
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: refresh lvm devices after brick create
..
Patch Set 4:
* Update tracker::#1227742::OK
* Check Bug-Url::OK
* Check Public Bug::#1227742::OK, publi
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: refresh lvm devices after brick create
..
Patch Set 3:
* Update tracker::#1227742::OK
* Check Bug-Url::OK
* Check Public Bug::#1227742::OK, publi
Ido Barkan has posted comments on this change.
Change subject: net: tests: also add line number in test that called
setupNetworks
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42196
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: also add line number in test that called
setupNetworks
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no b
Ido Barkan has uploaded a new change for review.
Change subject: net: tests: also add line number in test that called
setupNetworks
..
net: tests: also add line number in test that called setupNetworks
This is useful when there
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Ido Barkan has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42195
To unsubscribe, visit https://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Ido Barkan has uploaded a new change for review.
Change subject: net: missing Exception formatting value
..
net: missing Exception formatting value
Change-Id: I1e3bb7067c5c7ec70c7120515c7fb1231e9cabdc
Signed-off-by: Ido Barkan
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Ido Barkan has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/41973/4/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Ido Barkan has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42115/5/vdsm/network/configurators/ifcfg.py
File vdsm/network/conf
Dan Kenigsberg has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 5: Code-Review-1
(1 comment)
ERROR: testBuildBondOptionsBadParams (configNetworkTests.TestConfigNetwork)
Dan Kenigsberg has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 4: Code-Review-1
(5 comments)
incomplete review
https://gerrit.ovirt.org/#/c/41973/4/lib/vdsm/netconfpersistence.py
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Require ceph-common package
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Clear only ovirt secrets
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Add libvirt secret testing infrastructure
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 25:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Undefine existing secret if usage changed
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Support authentication using libvirt secrets
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Clear all secrets during startup and shutdown
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Add vdsClient secrets verbs
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 3: Code-Review-1
Must be rebased on ceph patches, adding new diskType.
--
To view, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: multipath: Fix "HITACHI"/"DF.* configuration
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41243/4//COMMIT_MSG
Commit Message:
Line 9: The multipath co
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Fix "HITACHI"/"DF.* configuration
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Fix "COMPELNT"/"Compellent Vol" configuration
..
Patch Set 5:
* Update tracker::#1225162::OK
* Check Bug-Url::OK
* Check Public Bug::#1225162::
automat...@ovirt.org has posted comments on this change.
Change subject: multipath-conf: Add (disabled) overrides section
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has uploaded a new change for review.
Change subject: multipath-conf: Add (disabled) overrides section
..
multipath-conf: Add (disabled) overrides section
Upstream multipath is supporting new "overrides" section, allo
Daniel Erez has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 15:
The add/remove/set design might seem a bit superfluous and would require extra
work in engine side, but,
Allon Mureinik has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 15:
Having a clear=True or flush=True parameter in the add API sounds peculiar to
me (it makes it do somet
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
After discussing with Nir I realize the VmDiskDevice is already polluted with
'connection' information (ie.
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15: Code-Review+2
After talking with Nir I agree that the VmDiskDevice is already polluted with
'connection' in
Adam Litke has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 15: -Code-Review
Francesco and Nir,
How about this:
registerSecrets(secrets, flush=False)
If flush is True,
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/15/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move getLeasesFilePath
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/41995/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.p
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: introduce class heirarchy
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/blockSD.py
File vdsm/storage/blockS
Adam Litke has posted comments on this change.
Change subject: ceph: Clear only ovirt secrets
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41302
To unsubscribe, visit https://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: ceph: Clear all secrets during startup and shutdown
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40968
To unsubscribe, visit https://ge
Adam Litke has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40853
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: ceph: Undefine existing secret if usage changed
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40967
To unsubscribe, visit https://gerrit
Adam Litke has posted comments on this change.
Change subject: ceph: Add vdsClient secrets verbs
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40735
To unsubscribe, visit https://gerrit.ovirt.org/se
Adam Litke has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: ceph: Add libvirt secret testing infrastructure
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40789
To unsubscribe, visit https://gerri
Adam Litke has posted comments on this change.
Change subject: ceph: Support authentication using libvirt secrets
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/40505/13/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vd
Adam Litke has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 12: Code-Review+1
I guess it should be +1 since there will be some changes around the schema.
--
To view, visi
Adam Litke has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 16: Code-Review+1
I guess it should be +1 since there will be some changes around the schema.
--
To view, vi
Adam Litke has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit https://gerrit.ovirt
Adam Litke has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40477
To unsubscribe, visit https://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/15/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema
Dan Kenigsberg has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41972
To unsubscribe, visit https://gerrit.ovirt.org/s
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add way to easily mock host devices
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add way to easily mock host devices
..
Patch Set 8: Verified+1
not much to test
--
To view, visit https://gerrit.ovirt.org/40860
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add way to easily mock host devices
..
tests: add way to easily mock host devices
Currently, trying to use host device in unit test will result
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: allow a single dev from IOMMU group to be passed through
..
virt: allow a single dev from IOMMU group to be passed through
This patch introduces
automat...@ovirt.org has posted comments on this change.
Change subject: virt: allow a single dev from IOMMU group to be passed through
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-U
Dan Kenigsberg has posted comments on this change.
Change subject: virt: allow a single dev from IOMMU group to be passed through
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41508
To unsubscribe, v
Martin Sivák has posted comments on this change.
Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/41571
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/s
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py
File lib/ya
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 23: Verified+1
Fixed comment by small refactoring. Change verified by running build locally.
--
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 27:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Adam Litke has posted comments on this change.
Change subject: ceph: Require ceph-common package
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41804
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py
File lib/yajsonrp
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: introduce class heirarchy
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py
File lib/ya
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 29: Verified+1
Comments fixed and verified by checking that communication with latest engine
work.
--
T
Yeela Kaplan has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py
File lib/yajson
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 27:
(2 comments)
https://gerrit.ovirt.org/#/c/38819/27/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/s
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py
File lib/ya
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 26:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Yeela Kaplan has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 27:
(2 comments)
https://gerrit.ovirt.org/#/c/38819/27/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stomp
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 28:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
1 - 100 of 206 matches
Mail list logo
