Change in vdsm[master]: net: simplify _get_gateway

Ido Barkan has uploaded a new change for review. Change subject: net: simplify _get_gateway .. net: simplify _get_gateway Using the default value of _RT_TABLE_UNSPEC is meaningless since it can be any default value chosen by the

Change in vdsm[master]: net: simplify _get_gateway

Ido Barkan has posted comments on this change. Change subject: net: simplify _get_gateway .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42966 To unsubscribe, visit https://gerrit.ovirt.org/settings Ger

Change in vdsm[master]: net: simplify _get_gateway

automat...@ovirt.org has posted comments on this change. Change subject: net: simplify _get_gateway .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[ovirt-3.5]: net: tests: only test kernel config if unified persistence

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR,

Change in vdsm[ovirt-3.5]: net: tests: do not use KernelConfig.__eq__ in tests

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: do not use KernelConfig.__eq__ in tests .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At leas

Change in vdsm[ovirt-3.5]: net: Drop default bonding options

automat...@ovirt.org has posted comments on this change. Change subject: net: Drop default bonding options .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is r

Change in vdsm[ovirt-3.5]: net: ifcfg: ONBOOT=yes on all persisted network files.

automat...@ovirt.org has posted comments on this change. Change subject: net: ifcfg: ONBOOT=yes on all persisted network files. .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK

Change in vdsm[ovirt-3.5]: net: introducing KernelConfig

automat...@ovirt.org has posted comments on this change. Change subject: net: introducing KernelConfig .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Prod

Change in vdsm[ovirt-3.5]: net: during boot, restore only networks that were actually c...

automat...@ovirt.org has posted comments on this change. Change subject: net: during boot, restore only networks that were actually changed. .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug

Change in vdsm[ovirt-3.5]: net: missing Exception formatting value

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42955 to review the following change. Change subject: net: missing Exception formatting value .. net: missing Exception formatt

Change in vdsm[ovirt-3.5]: Move _stpBooleanize to netinfo.

automat...@ovirt.org has posted comments on this change. Change subject: Move _stpBooleanize to netinfo. .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is req

Change in vdsm[ovirt-3.5]: net: Drop default bonding options

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42959 to review the following change. Change subject: net: Drop default bonding options .. net: Drop default bonding options O

Change in vdsm[ovirt-3.5]: net: tests: wrap setupNetworks calls

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: wrap setupNetworks calls .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url i

Change in vdsm[ovirt-3.5]: net: reset bonding options to defaults.

automat...@ovirt.org has posted comments on this change. Change subject: net: reset bonding options to defaults. .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-ur

Change in vdsm[ovirt-3.5]: net: tests: do not use KernelConfig.__eq__ in tests

Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42963 to review the following change. Change subject: net: tests: do not use KernelConfig.__eq__ in tests .. net:

Change in vdsm[ovirt-3.5]: net: missing Exception formatting value

automat...@ovirt.org has posted comments on this change. Change subject: net: missing Exception formatting value .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-ur

Change in vdsm[ovirt-3.5]: net: reset bonding options to defaults.

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42958 to review the following change. Change subject: net: reset bonding options to defaults. .. net: reset bonding options to

Change in vdsm[ovirt-3.5]: net: during boot, restore only networks that were actually c...

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42961 to review the following change. Change subject: net: during boot, restore only networks that were actually changed. .. n

Change in vdsm[ovirt-3.5]: net: tests: only test kernel config if unified persistence

Ido Barkan has uploaded a new change for review. Change subject: net: tests: only test kernel config if unified persistence .. net: tests: only test kernel config if unified persistence Testing KernelConfig does not support ifcf

Change in vdsm[ovirt-3.5]: net: ifcfg: ONBOOT=yes on all persisted network files.

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42962 to review the following change. Change subject: net: ifcfg: ONBOOT=yes on all persisted network files. .. net: ifcfg: ONB

Change in vdsm[ovirt-3.5]: Move _stpBooleanize to netinfo.

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42956 to review the following change. Change subject: Move _stpBooleanize to netinfo. .. Move _stpBooleanize to netinfo. And r

Change in vdsm[ovirt-3.5]: net: introducing KernelConfig

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42960 to review the following change. Change subject: net: introducing KernelConfig .. net: introducing KernelConfig KernelCon

Change in vdsm[ovirt-3.5]: net: bondingOptions should not be a part of runningConfig ne...

automat...@ovirt.org has posted comments on this change. Change subject: net: bondingOptions should not be a part of runningConfig networks .. Patch Set 2: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url

Change in vdsm[master]: tests: disable truncating diff in assert error messages

Ido Barkan has posted comments on this change. Change subject: tests: disable truncating diff in assert error messages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42902 To unsubscribe, visit https://g

Change in vdsm[master]: tests: disable truncating diff in assert error messages

automat...@ovirt.org has posted comments on this change. Change subject: tests: disable truncating diff in assert error messages .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found

Change in vdsm[master]: tests: disable truncating diff in assert error messages

Ido Barkan has posted comments on this change. Change subject: tests: disable truncating diff in assert error messages .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42902/1/tests/testlib.py File tests/testlib.py: L

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

Ala Hino has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42952/1/vdsm/storage/storageServer.py File vdsm/storage

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

automat...@ovirt.org has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: gluster: Verify volume is Replica 3

automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 40: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Che

Change in vdsm[ovirt-3.3]: vm: Continue to sample after errors

Nir Soffer has abandoned this change. Change subject: vm: Continue to sample after errors .. Abandoned Not needed now, this issue is fixed in master. -- To view, visit https://gerrit.ovirt.org/22575 To unsubscribe, visit http

Change in vdsm[ovirt-3.3]: vm: Continue to sample after errors

automat...@ovirt.org has posted comments on this change. Change subject: vm: Continue to sample after errors .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/22575 To unsub

Change in vdsm[ovirt-3.3]: vm: Avoid log spamming when drive format is undefined

automat...@ovirt.org has posted comments on this change. Change subject: vm: Avoid log spamming when drive format is undefined .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.

Change in vdsm[ovirt-3.3]: vm: Avoid log spamming when drive format is undefined

Nir Soffer has abandoned this change. Change subject: vm: Avoid log spamming when drive format is undefined .. Abandoned Not needed now, this issue is fixed in master. -- To view, visit https://gerrit.ovirt.org/22518 To unsub

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

Nir Soffer has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42952/1/vdsm/storage/storageServer.py File vdsm/stora

Change in vdsm[master]: virt: Safe device type check for console device

Martin Polednik has posted comments on this change. Change subject: virt: Safe device type check for console device .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/

Change in vdsm[master]: gluster: Verify volume is Replica 3

Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 38: (1 comment) https://gerrit.ovirt.org/#/c/41931/38/vdsm/storage/storageServer.py File vdsm/storage/storageServer.

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

automat...@ovirt.org has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.o

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

Ala Hino has abandoned this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Abandoned Not needed -- To view, visit https://gerrit.ovirt.org/42940 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: gluster: Verify volume is Replica 3

automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 39: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Che

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

automat...@ovirt.org has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

Ala Hino has uploaded a new change for review. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. gluster:refactor: Refactor GlusterFSConnection class Gluster volume info is required when validating that glu

Change in vdsm[master]: hook: diskunmap: To include UNMAP support for disk and lun d...

Amador Pahim has posted comments on this change. Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/29770/7/vdsm_hooks/diskunmap/before_

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

automat...@ovirt.org has posted comments on this change. Change subject: adding the StorageDomain.upgradeVersion verb .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: adding StorageDomain.updateVmData()

automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.updateVmData() .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: adding StorageDomain.getBackedUpVmsInfo

automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.getBackedUpVmsInfo .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: hook: diskunmap: To include UNMAP support for disk and lun d...

Dan Kenigsberg has posted comments on this change. Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/29770/7/vdsm_hooks/diskunmap/befor

Change in vdsm[master]: gluster: Verify volume is Replica 3

Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 38: (1 comment) https://gerrit.ovirt.org/#/c/41931/38/vdsm/storage/storageServer.py File vdsm/storage/storageServe

Change in vdsm[master]: rwlock: Support timed acquire

Nir Soffer has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/42909/6/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 89: def __init

Change in vdsm[master]: rwlock: Add simpler RWLock

Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 4: Code-Review-1 - Fix reader wakeup - Make this compatible with older misc.RWLock -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: tests: Add RWLock tests

Nir Soffer has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 4: Code-Review-1 More missing tests: - When waking up blocked readers, all readers up to the first writer should wake up. Curr

Change in vdsm[master]: rwlock: Add simpler RWLock

Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/42908/4/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 31: self._wa

Change in vdsm[master]: gluster: Verify volume is Replica 3

Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 37: (1 comment) https://gerrit.ovirt.org/#/c/41931/37/vdsm/storage/storageServer.py File vdsm/storage/storageServer.

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

automat...@ovirt.org has posted comments on this change. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class

Ala Hino has uploaded a new change for review. Change subject: gluster:refactor: Refactor GlusterFSConnection class .. gluster:refactor: Refactor GlusterFSConnection class Gluster volume info is required when validating that glu

Change in vdsm[master]: gluster: Verify volume is Replica 3

automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 38: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Che

Change in vdsm[master]: rwlock: Support timed acquire

Dima Kuznetsov has posted comments on this change. Change subject: rwlock: Support timed acquire .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/42909/6/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line

Change in vdsm[master]: rwlock: Add simpler RWLock

Dima Kuznetsov has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/42908/4/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 31: self

Change in vdsm[master]: tests: Add RWLock tests

Dima Kuznetsov has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42907 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: virt: Safe device type check for console device

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Safe device type check for console device .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Li

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

automat...@ovirt.org has posted comments on this change. Change subject: adding the StorageDomain.upgradeVersion verb .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: adding StorageDomain.updateVmData()

automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.updateVmData() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: tests: Add RWLock tests

Nir Soffer has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 4: Missing tests - forbid promotion - take read lock when holding write lock (not sure what is the intention in current code)