Change in vdsm[master]: net: tests: only test kernel config if unified persistence

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/43499 to review the following change. Change subject: net: tests: only test kernel config if unified persistence .. net:

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

Ido Barkan has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43499 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: no need to call setupNetworks with empty argument during net...

Yaniv Bronhaim has submitted this change and it was merged. Change subject: no need to call setupNetworks with empty argument during network restoration .. no need to call setupNetworks with empty argument during network

Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up

Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: wait for restored devices to be up .. net: wait for restored devices to be up If restore-net-config does not wait for all devices to be up, it

Change in vdsm[ovirt-3.5]: net: restore-nets should support ONBOOT=no

automat...@ovirt.org has posted comments on this change. Change subject: net: restore-nets should support ONBOOT=no .. Patch Set 4: * Update tracker::#1203422::OK * Check TR::#1203422::OK * Set MODIFIED::bug

Change in vdsm[ovirt-3.5]: net: ignore bondingOptions in persistent networks.

Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: ignore bondingOptions in persistent networks. .. net: ignore bondingOptions in persistent networks. Up until https://gerrit.ovirt.org/#/c/42146/

Change in vdsm[ovirt-3.5]: net: support strings for 'bridged' in kernelConfig

Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: support strings for 'bridged' in kernelConfig .. net: support strings for 'bridged' in kernelConfig Because kernelConfig did not know how to

Change in vdsm[ovirt-3.5]: net: support strings for 'bridged' in kernelConfig

automat...@ovirt.org has posted comments on this change. Change subject: net: support strings for 'bridged' in kernelConfig .. Patch Set 3: * Update tracker::#1237032::OK * Check TR::#1237032::ERROR, 3.6.0 should match

Change in vdsm[ovirt-3.5]: net: flatten ifcfg.ConfigWriter

Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: flatten ifcfg.ConfigWriter .. net: flatten ifcfg.ConfigWriter Make startDevices and stopDevices public for further use. Also, promotoe them to be

Change in vdsm[master]: vm: events: do not send hashes in status messages

Francesco Romani has posted comments on this change. Change subject: vm: events: do not send hashes in status messages .. Patch Set 7: Verified+1 (trivially) verified that an events do not have the hash anymore. -- To view,

Change in vdsm[master]: vm: run before_vm_create hook only in the VM boot

automat...@ovirt.org has posted comments on this change. Change subject: vm: run before_vm_create hook only in the VM boot .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: net: if all devices are up, skip ifup during restoratrion.

Ido Barkan has posted comments on this change. Change subject: net: if all devices are up, skip ifup during restoratrion. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43435 To unsubscribe, visit

Change in vdsm[master]: net: if all devices are up, skip ifup during restoratrion.

Ido Barkan has posted comments on this change. Change subject: net: if all devices are up, skip ifup during restoratrion. .. Patch Set 1: yes. on my minidell every restoration now take about 3 seconds. -- To view, visit

Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up

Dan Kenigsberg has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: flatten ifcfg.ConfigWriter

Dan Kenigsberg has posted comments on this change. Change subject: net: flatten ifcfg.ConfigWriter .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43381 To unsubscribe, visit

Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

Ido Barkan has posted comments on this change. Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43441/1/tests/functional/networkTests.py

Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

Dan Kenigsberg has posted comments on this change. Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43388/3/vdsm/storage/fc-scan File vdsm/storage/fc-scan:

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

automat...@ovirt.org has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

Ido Barkan has uploaded a new change for review. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. net: _upgrade_onboot failed on python 2.6.6 The flags keyword argument was added only on python 2.7. Change-Id:

Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs

automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs

Dan Kenigsberg has submitted this change and it was merged. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. resize-lun: Fix resizing when vg has multiple pvs When resizing a PV, LVM needs the other PVs

Change in vdsm[master]: concurrent: Add Barrier class

Francesco Romani has posted comments on this change. Change subject: concurrent: Add Barrier class .. Patch Set 6: Code-Review+1 seems OK and nicely tested -- To view, visit https://gerrit.ovirt.org/42927 To unsubscribe,

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

automat...@ovirt.org has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 3: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public

Change in vdsm[master]: hostdev: fix hostdev addressing

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: fix hostdev addressing .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: event: emit event on setDownStatus

Francesco Romani has posted comments on this change. Change subject: vm: event: emit event on setDownStatus .. Patch Set 12: Verified+1 verified that an events with extra data is indeed emitted. -- To view, visit

Change in vdsm[master]: vm: event: emit event on domDependentInit

Francesco Romani has posted comments on this change. Change subject: vm: event: emit event on domDependentInit .. Patch Set 11: Verified+1 verified that an events with extra data is indeed emitted. -- To view, visit

Change in vdsm[master]: vm: event: emit event on guest status change

Francesco Romani has posted comments on this change. Change subject: vm: event: emit event on guest status change .. Patch Set 11: Verified+1 verified that an events with extra data is indeed emitted. -- To view, visit

Change in vdsm[master]: tests: Add RWLock tests

Francesco Romani has posted comments on this change. Change subject: tests: Add RWLock tests .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42907 To unsubscribe, visit

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 2: * Update tracker::#1203422::OK * Set MODIFIED::bug

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

Dan Kenigsberg has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43499 To unsubscribe,

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: only test kernel config if unified persistence .. net: tests: only test kernel config if unified persistence Testing KernelConfig does not

Change in vdsm[ovirt-3.5]: net: restore-nets should support ONBOOT=no

Yaniv Bronhaim has submitted this change and it was merged. Change subject: net: restore-nets should support ONBOOT=no .. net: restore-nets should support ONBOOT=no on 3.5.x devices were persisted with ONBOOT=no. Hence, the

Change in vdsm[ovirt-3.5]: no need to call setupNetworks with empty argument during net...

automat...@ovirt.org has posted comments on this change. Change subject: no need to call setupNetworks with empty argument during network restoration .. Patch Set 4: * Update tracker::#1203422::OK * Set MODIFIED::bug

Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up

automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 7: * Update tracker::#1203422::OK * Set MODIFIED::bug 1203422#1203422IGNORE, not all related

Change in vdsm[ovirt-3.5]: net: flatten ifcfg.ConfigWriter

automat...@ovirt.org has posted comments on this change. Change subject: net: flatten ifcfg.ConfigWriter .. Patch Set 4: * Update tracker::#1203422::OK * Set MODIFIED::bug 1203422#1203422IGNORE, not all related patches

Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action

Francesco Romani has posted comments on this change. Change subject: vdsm hooks: report hook stderr to Engine if it fails an action .. Patch Set 18: Code-Review+1 (2 comments) seems OK. Please state in the comments how you

Change in vdsm[master]: vm: event: add arguments to send_status_event

Francesco Romani has posted comments on this change. Change subject: vm: event: add arguments to send_status_event .. Patch Set 4: Verified+1 verified with 43269 and 43270: the notification events has the extra fields. -- To

Change in vdsm[master]: hostdev: fix hostdev addressing

Martin Polednik has posted comments on this change. Change subject: hostdev: fix hostdev addressing .. Patch Set 10: Verified+1 Addresses are reported correctly - meaning the VM can be freely restarted and it's start won't

Change in vdsm[master]: net: if all devices are up, skip ifup during restoratrion.

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: if all devices are up, skip ifup during restoratrion. .. net: if all devices are up, skip ifup during restoratrion. The usual case since 3.5.4 is

Change in vdsm[master]: net: if all devices are up, skip ifup during restoratrion.

automat...@ovirt.org has posted comments on this change. Change subject: net: if all devices are up, skip ifup during restoratrion. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

Dan Kenigsberg has posted comments on this change. Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43441 To unsubscribe,

Change in vdsm[master]: hostdev: inline source address function

Francesco Romani has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 2: Code-Review+1 thanks! -- To view, visit https://gerrit.ovirt.org/43379 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix hostdev addressing

Francesco Romani has posted comments on this change. Change subject: hostdev: fix hostdev addressing .. Patch Set 10: Code-Review+1 Thanks for the updates, I think it's good now. -- To view, visit

Change in vdsm[master]: net: tests: only test kernel config if unified persistence

Petr Horáček has posted comments on this change. Change subject: net: tests: only test kernel config if unified persistence .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43499 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: support strings for 'bridged' in kernelConfig

Ido Barkan has posted comments on this change. Change subject: net: support strings for 'bridged' in kernelConfig .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43446 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: restore-nets should support ONBOOT=no

Ido Barkan has posted comments on this change. Change subject: net: restore-nets should support ONBOOT=no .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43382 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

Dan Kenigsberg has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43507 To unsubscribe, visit

Change in vdsm[master]: virt: migration: create full status in migration.py

Francesco Romani has posted comments on this change. Change subject: virt: migration: create full status in migration.py .. Patch Set 2: Code-Review-1 (1 comment) -1 for visibility v2 seems just a rebase, please check my

Change in vdsm[ovirt-3.5]: net: restore-nets should support ONBOOT=no

Dan Kenigsberg has posted comments on this change. Change subject: net: restore-nets should support ONBOOT=no .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43382 To unsubscribe, visit

Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: vm: run before_vm_create hook only in the VM boot

Francesco Romani has abandoned this change. Change subject: vm: run before_vm_create hook only in the VM boot .. Abandoned I guess this pet peeve of mine should wait better times. -- To view, visit

Change in vdsm[master]: virt: make vm events callback public

Francesco Romani has posted comments on this change. Change subject: virt: make vm events callback public .. Patch Set 5: Reason for Jenkins CI Failure: DEBUG util.py:378: Traceback (most recent call last): DEBUG

Change in vdsm[master]: adding StorageDomain.removeVmData()

automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.removeVmData() .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: adding StorageDomain.activateHsm()

automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.activateHsm() .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

automat...@ovirt.org has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 2: -Verified * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: migration: create full status in migration.py

Francesco Romani has posted comments on this change. Change subject: virt: migration: create full status in migration.py .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/43357/1/vdsm/API.py File vdsm/API.py: Line

Change in vdsm[master]: hostdev: add tests for guest addressing

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add tests for guest addressing .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit

Change in vdsm[master]: hostdev: inline source address function

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: testlib: Use nose.case.Test.getDescription()

Dan Kenigsberg has posted comments on this change. Change subject: testlib: Use nose.case.Test.getDescription() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43431 To unsubscribe, visit

Change in vdsm[master]: testlib: Show fully qualified class name

automat...@ovirt.org has posted comments on this change. Change subject: testlib: Show fully qualified class name .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: virt: add logic for POWER cpu xml element

automat...@ovirt.org has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5]: net: tests: clean legacy bonds from kernelConfig

Dan Kenigsberg has posted comments on this change. Change subject: net: tests: clean legacy bonds from kernelConfig .. Patch Set 1: (2 comments) nits about comments https://gerrit.ovirt.org/#/c/43513/1//COMMIT_MSG Commit

Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action

automat...@ovirt.org has posted comments on this change. Change subject: vdsm hooks: report hook stderr to Engine if it fails an action .. Patch Set 19: * Update tracker::#1219630::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: hostdev: add basic unit tests for XML

Francesco Romani has posted comments on this change. Change subject: hostdev: add basic unit tests for XML .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/43088/4/tests/hostdevTests.py File

Change in vdsm[master]: hostdev: add tests for guest addressing

Francesco Romani has posted comments on this change. Change subject: hostdev: add tests for guest addressing .. Patch Set 3: Code-Review+1 ok, I see your point. I can't think of an wasy way to inject address, so let's move

Change in vdsm[ovirt-3.5]: net: fix python 2.7 specific code

automat...@ovirt.org has posted comments on this change. Change subject: net: fix python 2.7 specific code .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

automat...@ovirt.org has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 4: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public

Change in vdsm[ovirt-3.5]: net: tests: clean legacy bonds from kernelConfig

Ido Barkan has uploaded a new change for review. Change subject: net: tests: clean legacy bonds from kernelConfig .. net: tests: clean legacy bonds from kernelConfig VdsProxy netinfo is built from getVdsCapabilities which

Change in vdsm[ovirt-3.5]: net: fix python 2.7 specific code

Ido Barkan has uploaded a new change for review. Change subject: net: fix python 2.7 specific code .. net: fix python 2.7 specific code This syntax is only supported in python 2.7 hence should be removed from 3.5 branch which

Change in vdsm[master]: testlib: Remove unneeded methods

Dan Kenigsberg has submitted this change and it was merged. Change subject: testlib: Remove unneeded methods .. testlib: Remove unneeded methods VdsmTestRunner was implementing __init__() and run() for no reason. Maybe we used

Change in vdsm[master]: testlib: Remove unneeded methods

Dan Kenigsberg has posted comments on this change. Change subject: testlib: Remove unneeded methods .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43430 To unsubscribe, visit

Change in vdsm[master]: virt: add logic for POWER cpu xml element

Francesco Romani has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element .. Patch Set 6: Code-Review+1 looks OK to me -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe,

Change in vdsm[master]: hostdev: add basic unit tests for XML

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add basic unit tests for XML .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: add basic unit tests for XML

Martin Polednik has posted comments on this change. Change subject: hostdev: add basic unit tests for XML .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43088 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: net: _upgrade_onboot failed on python 2.6.6

Dan Kenigsberg has posted comments on this change. Change subject: net: _upgrade_onboot failed on python 2.6.6 .. Patch Set 4: but any idea what's 14:13:15 ERROR: test_parseVolumeStatus (gluster_cli_tests.GlusterCliTests)

Change in vdsm[master]: virt: migration: create full status in migration.py

automat...@ovirt.org has posted comments on this change. Change subject: virt: migration: create full status in migration.py .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: api: 'device' property for RNG device

Shmuel Leib Melamud has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43166 To unsubscribe, visit

Change in vdsm[master]: api: 'device' property for RNG device

automat...@ovirt.org has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 2: * Update tracker::#1233825::OK * Check Bug-Url::OK * Check Public Bug::#1233825::OK, public bug *

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: inline source address function

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5]: net: tests: clean legacy bonds from kernelConfig

automat...@ovirt.org has posted comments on this change. Change subject: net: tests: clean legacy bonds from kernelConfig .. Patch Set 1: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK,

Change in vdsm[master]: hostdev: fix hostdev addressing

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: fix hostdev addressing .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: hostdev: inline source address function

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: add basic unit tests for XML

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add basic unit tests for XML .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: test_setupNetworks_bond_with_custom_option with ifcfg p...

Dan Kenigsberg has posted comments on this change. Change subject: net: test_setupNetworks_bond_with_custom_option with ifcfg persistence .. Patch Set 1: (1 comment)

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43388/5/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line

Change in vdsm[master]: testlib: Use nose.case.Test.getDescription()

automat...@ovirt.org has posted comments on this change. Change subject: testlib: Use nose.case.Test.getDescription() .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: testlib: Remove unneeded methods

automat...@ovirt.org has posted comments on this change. Change subject: testlib: Remove unneeded methods .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: hostdev: inline source address function

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5]: net: fix python 2.7 specific code

Dan Kenigsberg has posted comments on this change. Change subject: net: fix python 2.7 specific code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43512 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix hostdev addressing

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: fix hostdev addressing .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: testlib: Show fully qualified class name

Dan Kenigsberg has posted comments on this change. Change subject: testlib: Show fully qualified class name .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43432 To unsubscribe, visit

Change in vdsm[master]: hostdev: inline source address function

Martin Polednik has posted comments on this change. Change subject: hostdev: inline source address function .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43379 To unsubscribe, visit

Change in vdsm[master]: hostdev: add tests for guest addressing

automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add tests for guest addressing .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

  1   2   3   >