Piotr Kliczewski has posted comments on this change.
Change subject: utils.retry: Support system time changes while retry() is
running
..
Patch Set 2: Code-Review+1
so, let's add tests in future patch.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/45345
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 2:
Would be easier to read if you noted (explicitly :) ) that there is no a
behavior change - or
Martin Polednik has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45345/5/vdsm/supervdsmServer
File
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: utils.retry: Support system time changes while retry() is
running
..
Patch Set 2:
Piotr, adding test would be nice but this a trivial change that can not break
Martin Polednik has posted comments on this change.
Change subject: virt: console: use serial type when bind to socket
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46089
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vm: graphics: save all settings when snapshotting
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45979/1//COMMIT_MSG
Commit Message:
Line 10:
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vm: graphics: fix settings after restore
..
Patch Set 8: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/44842/8//COMMIT_MSG
Commit Message:
Line 6:
Francesco Romani has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45345/5/vdsm/supervdsmServer
File
Martin Polednik has posted comments on this change.
Change subject: vm: graphics: save all settings when snapshotting
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45979
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: fix trigger docstring
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15: Code-Review+1
(1 comment)
One thing to take into consideration: don't break the build :)
Martin Polednik has posted comments on this change.
Change subject: virt: console: do not add always serial device
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46088
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Update lvm2 requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46102
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: deactivateSd - remove domain from pending for upgrade list
..
Patch Set 17: Code-Review+1
The code makes sense to me. Nir, please use your +2.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: spec: Update lvm2 requirement
..
Patch Set 1:
* Update tracker::#1127117::OK
* Check Bug-Url::OK
* Check Public Bug::#1127117::OK, public bug
* Check
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Update lvm2 requirement
..
spec: Update lvm2 requirement
lvm2-2.02.107 solved a race condition in LVM when concurrently
activating the same LV multiple
Adam Litke has posted comments on this change.
Change subject: hsm: lock pool when running upgradeStoragePool
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45866
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: console: use serial type when bind to socket
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has posted comments on this change.
Change subject: safelease: Fix wrong parameter name
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45960
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: console: do not add always serial device
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: console: use serial type when bind to socket
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: virt: console: do not add always serial device
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Adam Litke has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45963
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46057
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: safelease: Remove unhelpful debug code
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45962
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: safelease: Improve logging when releasing lock
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45961
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: vdsClient: parse no value arguments
..
vdsClient: parse no value arguments
There was regression introduced by
00cae320514b096c11bfb7b48ebe944235b2e85a
automat...@ovirt.org has posted comments on this change.
Change subject: vdsClient: parse no value arguments
..
Patch Set 1:
* Update tracker::#1249624::OK
* Check Bug-Url::OK
* Check Public Bug::#1249624::OK, public bug
*
Petr Horáček has uploaded a new change for review.
Change subject: automation: add build_artifacts
..
automation: add build_artifacts
Change automation structure according to new CI standard. Add
build-artifacts.sh which build
automat...@ovirt.org has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 3: Verified+1
Verified again with OVA import. There is still no VMWare environment available.
--
To view,
Adam Litke has posted comments on this change.
Change subject: Move jobs.py to lib/vdsm
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46141
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: Move jobs.py to lib/vdsm
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: Move jobs.py to lib/vdsm
..
Move jobs.py to lib/vdsm
The host jobs infrastructure in jobs.py is general purpose and belongs
in the vdsm-python package. The
Marcin Mirecki has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/44552
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: spec: Update lvm2 requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46102
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: console: do not add always serial device
..
Patch Set 3: Verified+1
this was the version I actually verified
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sudoers: remove unused iscsid policies
..
sudoers: remove unused iscsid policies
could've been removed on:
https://gerrit.ovirt.org/#/c/305/
automat...@ovirt.org has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 5:
* Update tracker::#1254713::OK
* Set MODIFIED::bug 1254713#1254713IGNORE, not
automat...@ovirt.org has posted comments on this change.
Change subject: sudoers: remove unused iscsid policies
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
* Update tracker::#1247075::OK
* Check Bug-Url::OK
* Check Public Bug::#1247075::OK, public
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: lvm: Check if device in VG before extend
..
Patch Set 3:
* Update tracker::#1261531::OK
* Set MODIFIED::bug 1261531#1261531IGNORE, not oVirt prod
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lvm: Check if device in VG before extend
..
lvm: Check if device in VG before extend
Before extending a VG, VDSM needs to check that none of
the
Dan Kenigsberg has posted comments on this change.
Change subject: virt: vm with port mirroring stuck in down state
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/45344/4/vdsm/virt/vm.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: vm with port mirroring stuck in down state
..
virt: vm with port mirroring stuck in down state
When powering off VM with port mirroring
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/14/tests/tasksetTests.py
File
Sandro Bonazzola has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44552
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: spec: Update lvm2 requirement
..
Patch Set 6:
* Update tracker::#1127117::OK
* Set MODIFIED::bug 1127117#1127117IGNORE, not oVirt prod but Red
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Update lvm2 requirement
..
spec: Update lvm2 requirement
lvm2-2.02.107 solved a race condition in LVM when concurrently
activating the same LV
Sandro Bonazzola has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44552/5/vdsm/hooks.py
File vdsm/hooks.py:
Line 395: return
automat...@ovirt.org has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#965929::ERROR, private bug
* Check Public
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45345/5/vdsm/supervdsmServer
File
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15: Verified+1
verification: no affinity set (checked with taskset -p -c $VDSM_PID) if option
Piotr Kliczewski has posted comments on this change.
Change subject: utils.retry: Support system time changes while retry() is
running
..
Patch Set 2:
Can we have some test to be sure that it works as we think it does?
--
Piotr Kliczewski has posted comments on this change.
Change subject: cleanup: Remove unused pidfile option and argument parsing code
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45964
To
Michal Skrivanek has posted comments on this change.
Change subject: fakekvm: report correct POWER8 model
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45249
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
amending previous comment:
tested in conjunction with https://gerrit.ovirt.org/#/c/45749/ .
I did
66 matches
Mail list logo
