gerrit-hooks has posted comments on this change.
Change subject: net: fix systemd race in exec_ifup
..
Patch Set 2:
* #1259468::Update tracker: OK
* Set MODIFIED::bug 1259468#1259468OK, already on MODIFIED
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix systemd race in exec_ifup
..
net: fix systemd race in exec_ifup
We set unique uuid for every systemd-run to not use the same unit
twice and
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Milan Zamazal has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48790
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48803/1/lib/yajsonrpc/stomp.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
For ssl socket we delegate pending call to underlying socket so in theory it
should
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48803/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
Yes, we do.
--
To view, visit https://gerrit.ovirt.org/48608
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48803/1/lib/yajsonrpc/stomp.py
File
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48803/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1: Code-Review+2 Verified+1
Let's take this patch. It is generic solution instead of the specific
Milan Zamazal has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46525/1/vdsm/virt/domain_descriptor.py
Nir Soffer has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
Pitor, do we have a way to run the test with both m2c and ssl, in the same way
we run with ssl
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 11:
Dan doesn't like the yes no as well - i'm trying to check how we can keep the 1
0 which I
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48803/1/lib/yajsonrpc/stomp.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
I tested both m2c and ssl modules and the code works in the same way for both.
--
To
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: Drain pending bytes from SSLConnection
..
stomp: Drain pending bytes from SSLConnection
Stomp reactor was reading only 4096 bytes from the
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 4:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2:
Arik, can you get jenkins to be happy with your patch, or explain the failures?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Test both ssl and m2c
..
Patch Set 2:
(1 comment)
Much nicer! but we need also to test no ssl.
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2:
Done
--
To view, visit https://gerrit.ovirt.org/48826
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 3:
(4 comments)
Nice! but we must have tests before doing this refactoring.
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: logUtils: Process SimpleLogAdapter's context once
..
Patch Set 4:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/48552
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/48826
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Test both ssl and m2c
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py
File tests/stompTests.py:
Line 55:
Nir Soffer has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4: Code-Review-2
(1 comment)
https://gerrit.ovirt.org/#/c/48844/4/vdsm/storage/image.py
File vdsm/storage/image.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 4:
* #1274670::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1274670::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 3:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Notice imageSyncVolumeChain errors
..
Patch Set 1:
Needs another review
--
To view, visit https://gerrit.ovirt.org/45387
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 7: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/46383/7/vdsm/storage/volume.py
File
Arik Hadas has abandoned this change.
Change subject: proposal for bz 1282239
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/48844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
gerrit-hooks has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/48844
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/48051/10/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 630: """
gerrit-hooks has posted comments on this change.
Change subject: netinfo: report DHCP from configuration to avoid confusion
after stopping DHCP
..
Patch Set 2:
* #1279824::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: report DHCP from configuration to avoid confusion
after stopping DHCP
..
Patch Set 2: Verified+1
The extended test passed and manual testing,
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48846
to review the following change.
Change subject: netinfo: report DHCP from configuration to avoid confusion
after stopping DHCP
gerrit-hooks has posted comments on this change.
Change subject: netinfo: report DHCP from configuration to avoid confusion
after stopping DHCP
..
Patch Set 1:
* #1279824::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 7:
Needs another review
--
To view, visit https://gerrit.ovirt.org/46383
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 7:
Needs another review
--
To view, visit https://gerrit.ovirt.org/46384
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/45613/8//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-11-18
Nir Soffer has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 10:
(3 comments)
Seems that this needs rebase
https://gerrit.ovirt.org/#/c/48051/10//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 4: Verified+1
Verified on rhel7:
- Create 2 vms from tempate
- Start vms
- Migrate couple of times
- Stop
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Notice imageSyncVolumeChain errors
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45387
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit f8127d8
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47367/7/tests/v2vTests.py
File tests/v2vTests.py:
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 7:
Needs another review
--
To view, visit https://gerrit.ovirt.org/46382
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46382
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46384
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4:
Yeah that's another option. Currently VDSM does not know that it operates on
metadata volume, if we break this assumption
Nir Soffer has submitted this change and it was merged.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
gluster: Fixing connection when server is not one of the bricks
When processing gluster
Nir Soffer has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9:
Thanks Ala!
Can you backport?
--
To view, visit https://gerrit.ovirt.org/48308
gerrit-hooks has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 10:
* #1278880::Update tracker: OK
* Set MODIFIED::bug 1278880#1278880OK
--
Nir Soffer has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4:
Thanks Arik, we will continue with this.
--
To view, visit https://gerrit.ovirt.org/48844
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 8: Code-Review+1
Thanks for this cleanup! Vdsm feels less dirty now :-)
Waiting for Piotr approval on the infra related
gerrit-hooks has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: daemon: autodisable cpu affinity on singlecore
..
Patch Set 4: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/48619/4//COMMIT_MSG
Commit Message:
Line
Adam Litke has posted comments on this change.
Change subject: Live Merge: Notice imageSyncVolumeChain errors
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45387
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 4:
This version reads all the pending bytes in the second read, instead of reading
bufferSize bytes each
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/48473/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 4:
And also run the stompTests with both ssl and m2c.
--
To view, visit https://gerrit.ovirt.org/48803
To
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Notice imageSyncVolumeChain errors
..
Patch Set 2:
* #1214342::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1214342::OK, public bug
*
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 1: Continuous-Integration+1
unrelated
ERROR: Tests mkimage.mkFloppyFs creating an image and checking
Nir Soffer has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 1:
Francesco, are you waiting for something?
--
To view, visit https://gerrit.ovirt.org/48705
To
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48695
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
storagetestlib: use a real metadata file for FileSD manifests
When building a fake
Nir Soffer has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 13:
This is much too big, please break to small focus patches.
--
To view, visit https://gerrit.ovirt.org/46912
To
gerrit-hooks has posted comments on this change.
Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48629
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore
..
Remove vdsm/vdsm-logrotate.conf from .gitignore
vdsm/vdsm-logrotate.conf is no more generated, so
Nir Soffer has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 13: Code-Review-1
(1 comment)
Partial review of cpuinfo module.
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12:
Ping
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 4: Code-Review-1
would you care to manually rebase
--
To view, visit https://gerrit.ovirt.org/48180
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 3:
Ping?
--
To view, visit https://gerrit.ovirt.org/48477
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: config: Trivial typo fix in option description
..
config: Trivial typo fix in option description
Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f
gerrit-hooks has posted comments on this change.
Change subject: config: Trivial typo fix in option description
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yeela Kaplan has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48803
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2: Code-Review-1
(2 comments)
Thanks! lets keep only vdsm.conf.d - and lets create the directory during
installation
Francesco Romani has posted comments on this change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
Patch Set 6: Code-Review+2
this patch seems fine.
However the underlying issue is very interesting.
What about
gerrit-hooks has posted comments on this change.
Change subject: Using six.moves configparser to support ConfigParser in python3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 2: -Verified
Milan tested it and the bug seems to be fixed now.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Using six.moves configparser to support ConfigParser in python3
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/48780
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 1:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/48803
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 2:
* #1274670::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1274670::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: stomp: Drain pending bytes from SSLConnection
..
Patch Set 2: Verified-1
Need to test if this fixes https://bugzilla.redhat.com/1274670
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: daemon: enable cpu affinity by default
..
Patch Set 4:
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431IGNORE, not all related patches
Francesco Romani has submitted this change and it was merged.
Change subject: daemon: enable cpu affinity by default
..
daemon: enable cpu affinity by default
To run VDSM with CPU affinity enabled provided only
(huge) benefits
Francesco Romani has posted comments on this change.
Change subject: daemon: enable cpu affinity by default
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48787
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Test both ssl and m2c
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 11: Code-Review-1
(3 comments)
Nir Soffer has submitted this change and it was merged.
Change subject: Using six.moves configparser to support ConfigParser in python3
..
Using six.moves configparser to support ConfigParser in python3
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Using six.moves configparser to support ConfigParser in python3
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Nir Soffer has posted comments on this change.
Change subject: Using six.moves configparser to support ConfigParser in python3
..
Patch Set 2: Code-Review+2
Thanks, can you test this?
--
To view, visit
1 - 100 of 152 matches
Mail list logo
