gerrit-hooks has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net func tests: ip config drop on bond slaves
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has uploaded a new change for review.
Change subject: tests: modprobe validation handle failure
..
tests: modprobe validation handle failure
On validation failure, add a skip action with
a proper message.
Nir Soffer has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Nir Soffer has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 8: Code-Review-1
(21 comments)
https://gerrit.ovirt.org/#/c/49402/8/lib/vdsm/config.py.in
File
Nir Soffer has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
Daniel, please check why jenkins is failing, explain if the failure is relevant
to this
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG
Commit Message:
Line 3:
Edward Haas has uploaded a new change for review.
Change subject: net func tests: ip config drop on bond slaves
..
net func tests: ip config drop on bond slaves
Moving an interface to a bond should flush/drop
its ip
Nir Soffer has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/49402/8//COMMIT_MSG
Commit Message:
Line 24: the only
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3:
Ala, please address Piotr comment about the schema.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/49475/3/tests/storageServerTests.py
File
Nir Soffer has posted comments on this change.
Change subject: alerts: Introduce the alerts module
..
Patch Set 2:
(1 comment)
Piotr, code generating alerts will return them to engine. We have existing code
when getting
Nir Soffer has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3:
Pitor, there is no need to use events when you perform synchronous task such as
connecting to
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG
Commit Message:
Line 3:
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3:
I think a nicer solution would be to return a namedtuple from connect and
disconnect:
Result
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5:
Francesco?
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3: Code-Review-1
(4 comments)
Will be ok with little more work, but I don't like this code. Too much
gerrit-hooks has posted comments on this change.
Change subject: ImageManifest: create_image_dir
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has uploaded a new change for review.
Change subject: FakeLVM: support single LV and array in activateLVs
..
FakeLVM: support single LV and array in activateLVs
Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Adam Litke has uploaded a new change for review.
Change subject: FakeLVM: Add changeLVTags
..
FakeLVM: Add changeLVTags
Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Signed-off-by: Adam Litke
---
M
Adam Litke has uploaded a new change for review.
Change subject: tests: add FakeSanlock.init_resource
..
tests: add FakeSanlock.init_resource
Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Adam Litke has uploaded a new change for review.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
fileVolume: refactor _putMetadata to support volume artifacts
When writing normal FileVolume
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has abandoned this change.
Change subject: wip
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: wip
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49549
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: wip: how can I test block volumes?
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: support single LV and array in activateLVs
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: wip: how can I test block volumes?
..
wip: how can I test block volumes?
Change-Id: I4f584edabe61f6c5c473f722b7d1d20a505a5849
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: wip
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
gerrit-hooks has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Adam Litke has uploaded a new change for review.
Change subject: wip
..
wip
Change-Id: Ica3ddbd2bb3da5b699d8abb8977daef834bf6f29
Signed-off-by: Adam Litke
---
M tests/volumeartifacts_tests.py
M
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Introduce LV tag to ID block volume artifacts
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has uploaded a new change for review.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
fileVolume: define file extension for volume artifacts metadata
Change-Id:
Adam Litke has uploaded a new change for review.
Change subject: blockVolume: Introduce LV tag to ID block volume artifacts
..
blockVolume: Introduce LV tag to ID block volume artifacts
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 11: Code-Review+2
still looks good after big rebase
--
To view, visit https://gerrit.ovirt.org/48880
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/48880/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2714:
Nir Soffer has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49386/2//COMMIT_MSG
Commit Message:
Line 19: Now we
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 1: Code-Review-1
(1 comment)
I'm totally fine with the concept, not sure how this patch achieves that.
Francesco Romani has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 19: Code-Review+2
even better, thanks
--
To view, visit https://gerrit.ovirt.org/48473
To
Francesco Romani has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 14: Code-Review+2
please see my comment in 48473
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 19: Code-Review-1
too quick. I'm still happy with this patch per se, but I want to avoid
Francesco Romani has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 11:
(1 comment)
added one inside comment, but can be fixed by a later patch
Nir Soffer has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49386/2//COMMIT_MSG
Commit Message:
Line 19: Now we
Ido Barkan has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 21: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42003/21/vdsm/storage/blockVolume.py
File
Shahar Havivi has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/48672/13//COMMIT_MSG
Commit Message:
Line 11: We want to use one
Ido Barkan has posted comments on this change.
Change subject: net func tests: ip config drop on bond slaves
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41847
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net func tests: ip config drop on bond slaves
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49539
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: init: wait for ipv4 with monitoring
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/46148/9/init/wait_for_ipv4s
File init/wait_for_ipv4s:
Line 39:
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Shahar Havivi has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 1:
(1 comment)
> (1 comment)
>
> I'm totally fine with the concept, not sure how this patch
>
gerrit-hooks has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ido Barkan has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/49238/6//COMMIT_MSG
Commit Message:
Line 10: logic changed
> change
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 3:
* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 4:
* #1282187::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1282187::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 4:
* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
* Check
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 4:
This version cleans up the magic attaching code, using early returns to make
the intent more clear. No
gerrit-hooks has posted comments on this change.
Change subject: vm: always return bond mode in Host.getCapabilities
..
Patch Set 1:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: always return bond mode in Host.getCapabilities
..
vm: always return bond mode in Host.getCapabilities
The 'mode' attribute in bonding options should
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
That's not exactly correct - previewing a memory snapshot without disks
prevents running
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
vm: snapshot - enabling memory snapshot for diskless VM
Taking a memory snapshot of a VM without disks
gerrit-hooks has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty
gerrit-hooks has posted comments on this change.
Change subject: spec: Require ioprocess containing important fixes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 4:
* #1271173::Update tracker: OK
* Set MODIFIED::bug 1271173#1271173OK
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 4:
* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 4:
Ping?
--
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4: -Code-Review Verified-1
temporary V-1 to avoid premature merges (before 3.6.1 released)
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: PoC: enforcement of contract for notifications
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/49442/1/lib/api/notify-schema.yaml
File
gerrit-hooks has posted comments on this change.
Change subject: automation: support fc23
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49503
to review the following change.
Change subject: automation: support fc23
..
automation: support fc23
Change-Id:
Manoj Pillai has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2: -Code-Review
(3 comments)
Francesco Romani has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49205
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
..
Patch Set 2: Continuous-Integration+1
run CI checks manually
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: spec: Require ioprocess containing important fixes
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49175
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
..
Patch Set 2: Code-Review+1
temporary reducing score to avoid premature merges (before 3.6.1
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Require ioprocess containing important fixes
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49175
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
1 - 100 of 320 matches
Mail list logo