Francesco Romani has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3:
We still don't have this build for qemu-kvm-ev. Sandro is working on it, and
Daniel should be able to
Sahina Bose has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 6:
(1 comment)
Sorry - i'd thought i had commented on this - but it was stuck in drafts!
https://gerri
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 13:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* C
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 12:
> (1 comment)
>
> Looks good, just minor issue in test name.
Done
--
To view, visit https://gerri
Sahina Bose has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 3:
> (1 comment)
>
> Seems too big and not clear if all the changes are relat
Nir Soffer has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48317/7//COMMIT_MSG
Commit Message:
Line 35: - /etc/vdsm/vdsm.conf
Line 36: -
Nir Soffer has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 3: Code-Review-1
(1 comment)
Seems too big and not clear if all the changes are
Nir Soffer has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 8:
(9 comments)
Nice
https://gerrit.ovirt.org/#/c/49505/8/vdsm/v2v.py
File vdsm/v2v.py:
Nir Soffer has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 7:
(8 comments)
I like this, just few tweaks and it is ready.
https://gerrit.ovirt.org/#/c/49951/7/
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/48672/20/vdsm/v2v.py
File vdsm/v2v.py:
Line 648: for name i
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 5:
(8 comments)
https://gerrit.ovirt.org/#/c/49636/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 646: try:
Line 647:
Nir Soffer has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 2:
This patch increase coverage to 77%
--
To view, visit https://gerrit.ovirt.org/50585
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 2:
Nice, we have 74% coverage now.
--
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit htt
Nir Soffer has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 2:
Once we fix jobs cleanup, this is ready for merge.
--
To view, visit https://gerrit.ovirt.org/50585
To unsub
Nir Soffer has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/50585/2/tests/v2vTests.py
File tests/v2vTests.py:
Line 354:
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 2:
(2 comments)
Thanks for moving the test first, please check the comments.
https://gerrit.ovirt.org/#/c/505
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3: Code-Review+2
Daniel, can you verify that vdsm can be install on rhel and centos with this
patch?
--
To
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2:
Changing policy regarding backward compatibility should be discussed in devel.
It is not acceptable t
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2: Code-Review-1
Are you sure about not supporting engine < 3.6?
In 3.6 we support engine > 3.3. I expec
Nir Soffer has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 12: Code-Review+1
(1 comment)
Looks good, just minor issue in test name.
https://gerrit.ovirt.org/#/c/5
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3:
Sandro?
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: virt: Handle fork() related issues in vmchannels/guestagent
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/42570/12/vdsm/virt/vmchannels.py
File vdsm/vi
Nir Soffer has posted comments on this change.
Change subject: virt: Handle fork() related issues in vmchannels/guestagent
..
Patch Set 13:
(5 comments)
https://gerrit.ovirt.org/#/c/42570/13/vdsm/virt/guestagent.py
File vdsm/v
Nir Soffer has posted comments on this change.
Change subject: executor: Streamline __repr__
..
Patch Set 1:
Who will approve?
--
To view, visit https://gerrit.ovirt.org/50627
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: executor: Fix the task-callable mismtach
..
Patch Set 3:
Nobody wants to approve?
--
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://g
Nir Soffer has submitted this change and it was merged.
Change subject: VolumeMetadata: move newMetadata
..
VolumeMetadata: move newMetadata
Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Signed-off-by: Adam Litke
Review
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:/
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 12: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/48097/12/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http
Nir Soffer has submitted this change and it was merged.
Change subject: VolumeMetadata: move validateDelete
..
VolumeMetadata: move validateDelete
Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Signed-off-by: Adam Litke
Nir Soffer has posted comments on this change.
Change subject: constants: Define temporary volume indicators
..
Patch Set 7: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: storage: add getHostId to DomainMonitor
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: constants: Define temporary volume indicators
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/49544/7/vdsm/storage/constants.py
File vdsm/storage/constant
Nir Soffer has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 6: Code-Review-1
Unanswered questions
--
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 2:
Adam, can you answer the questions in patchset 2?
https://gerrit.ovirt.org/#/c/50340/2/tests/storagefakelib.
gerrit-hooks has posted comments on this change.
Change subject: storage: add getHostId to DomainMonitor
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: constants: Define temporary volume indicators
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: XXX: Add _getDeletedImagePath until patch merged
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sdm: add SDM.create_volume API stub
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 11:
(14 comments)
https://gerrit.ovirt.org/#/c/48097/11/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_ar
Nir Soffer has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py
F
Adam Litke has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 7:
Ok. Moved code to VolumeArtifacts.
--
To view, visit https://gerrit.ovirt.org/49545
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Marking testFakeNics as broken
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.o
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Marking testFakeNics as broken
..
Patch Set 3: Continuous-Integration+1
unrelated broken test
12:40:04 ERROR: testTogglePromisc (tcTests.TestQdisc)
Adam Litke has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py
F
Adam Litke has posted comments on this change.
Change subject: storage: add getHostId to DomainMonitor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/50630/3//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Some SDM ver
Nir Soffer has submitted this change and it was merged.
Change subject: fileSD: Do not try to remove non-existent lease file
..
fileSD: Do not try to remove non-existent lease file
The volume.lease file exists only if a domain
gerrit-hooks has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2:
* #1291207::Update tracker: OK
* Set MODIFIED::bug 1291207#1291207FAILED, illegal cha
Nir Soffer has posted comments on this change.
Change subject: virt: Fix @staticmethod usage in guest agent
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50656/1/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py
gerrit-hooks has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3:
* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check P
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Rename storageConstants.py to constants.py
..
storage: Rename storageConstants.py to constants.py
The SDM work is beginning an effort to reorganiz
gerrit-hooks has posted comments on this change.
Change subject: storage: Rename storageConstants.py to constants.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 12: Verified+1
Following verification performed while glusterfs-cli is not installed:
1. Added a 3.5 host,
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 12:
> Build Failed
>
> http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1557/
> : FAILU
Jenkins CI has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 7: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 6
--
To
Adam Litke has posted comments on this change.
Change subject: storage: Rename storageConstants.py to constants.py
..
Patch Set 2: Verified+1
Tested by running running a VM and doing a LSM and snapshot merge.
--
To view, visi
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 7:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Pr
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/49580/5//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 6:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Pr
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.p
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 12:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* C
Piotr Kliczewski has posted comments on this change.
Change subject: executor: Fix the task-callable mismtach
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.
Piotr Kliczewski has posted comments on this change.
Change subject: executor: Streamline __repr__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50627
To unsubscribe, visit https://gerrit.ovirt.org/s
Piotr Kliczewski has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49427
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Rename storageConstants.py to constants.py
..
Patch Set 2:
Adam, did you test this code with your new patches? Is it ready for merge?
--
To view, visit h
Adam Litke has posted comments on this change.
Change subject: storage: Rename storageConstants.py to constants.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: p3test: add few modules that currently pass on Python 3
..
Patch Set 1: Verified+1
domainDescriptorTests.DevicesHashTests
test_different_devices
Petr Horáček has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.
Amit Aviram has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visi
Ido Barkan has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt
gerrit-hooks has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ido Barkan has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50657/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net: M
Ido Barkan has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 5: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/49580/5//COMMIT_MSG
Commit Message:
Line 5: Commit
Amit Aviram has posted comments on this change.
Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit https:/
gerrit-hooks has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
net: support hot(un)plugNic for SRIOV network devices.
The missing behavior was to automatica
Amit Aviram has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, vi
Petr Horáček has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 1: Code-Review-1
(2 comments)
nice patch, just a nit. do we have something similar for vlans?
https://
Piotr Kliczewski has abandoned this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Abandoned
There is different issue on 3.6 and this patch is not needed.
--
To view, visit https://gerrit.ovirt.org/5026
gerrit-hooks has posted comments on this change.
Change subject: stomp: Drain pending bytes from ssl socket
..
Patch Set 2:
* #1188543::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/50265
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 3: Code-Review+2
looks OK to me.
--
To view, visit https://gerrit.ovirt.org/50372
To uns
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 11: Verified+1
Following verification performed:
1. Added a 3.5 host, created a gluster sd, upgraded host t
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 5:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Pr
Francesco Romani has posted comments on this change.
Change subject: vm: fix misleading XML log
..
Patch Set 4: Verified+1
verified on branch dehibernating and restoring a VM. Now the correct XML is
logged.
--
To view, visit
Ido Barkan has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt
Ido Barkan has uploaded a new change for review.
Change subject: net: MTU should be an integer all over VDSM.
..
net: MTU should be an integer all over VDSM.
It should be serialized as such and be converted to a string only
when
gerrit-hooks has posted comments on this change.
Change subject: net: MTU should be an integer all over VDSM.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 2: Verified+1
verified on branch running a couple of VMs over patched VDSM with no issues
--
To view, visit https
gerrit-hooks has posted comments on this change.
Change subject: virt: Fix @staticmethod usage in guest agent
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 139 matches
Mail list logo
