Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 14: Code-Review+1
Look good to me, but we need more reviews from the virt team and approval from
gerrit-hooks has posted comments on this change.
Change subject: p3test: add few modules that currently pass on Python 3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
gerrit-hooks has posted comments on this change.
Change subject: sdm: add SDM.create_volume API stub
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: XXX: All outstanding VolumeMetadata changes squashed
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: storagefakelib: Add FakeResourceManager
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: constants: Define temporary volume indicators
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: storage constants: Move LEASE_FILEEXT
..
storage constants: Move LEASE_FILEEXT
Change-Id: I80c741d34c6441de2474bf7c5ce4d5ea5a725995
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: storage: add get_volume_artifacts_class to the domain manifest
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: XXX: Add _getDeletedImagePath until patch merged
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/sampling.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: tcTests should run as root
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50794/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net
Nir Soffer has posted comments on this change.
Change subject: net tests: tcTests should run as root
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50794/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net tests:
Nir Soffer has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50804/1//COMMIT_MSG
Commit Message:
Line 14:
Line 15: Also, if one of the
gerrit-hooks has posted comments on this change.
Change subject: storage constants: Move LEASE_FILEEXT
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: show vlan in caps ports
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: caps vlan vlanid property has to be int
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has submitted this change and it was merged.
Change subject: p3test: add few modules that currently pass on Python 3
..
p3test: add few modules that currently pass on Python 3
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48366/11/tests/functional/networkTests.py
File
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Nir Soffer has posted comments on this change.
Change subject: constants: Define temporary volume indicators
..
Patch Set 8: Code-Review-1
(1 comment)
Check the comments
gerrit-hooks has posted comments on this change.
Change subject: python3: Port password module to python 3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: python3: Port password module to python 3
..
python3: Port password module to python 3
Python 3 removed the iteritems() method from dict object. Use
Nir Soffer has posted comments on this change.
Change subject: python3: Port password module to python 3
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/50848
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 8: Code-Review-1
(13 comments)
Partial review
https://gerrit.ovirt.org/#/c/50221/8/vdsm/storage/hsm.py
File
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 7:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 1: Verified+1
Verified on master
--
To view, visit https://gerrit.ovirt.org/50787
To unsubscribe, visit
Sagi Shnaidman has uploaded a new change for review.
Change subject: Always propagate bonding mode to engine
..
Always propagate bonding mode to engine
Without this patch the bond mode is not propagated
if it's not equal to 0
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1: Verified-1
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public
Sagi Shnaidman has abandoned this change.
Change subject: Always propagate bonding mode to engine
..
Abandoned
wrong change-id
--
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit
Sagi Shnaidman has uploaded a new change for review.
Change subject: Always propagate bonding mode to engine
..
Always propagate bonding mode to engine
Without this patch the bond mode is not propagated
if it's not equal to 0
Nir Soffer has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3: Code-Review+2 Continuous-Integration+1
CI failure is not relevant.
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
gluster: ensure LV size is multiple of VG's PE value
Alignment value for JBOD is changed to 256
gerrit-hooks has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 4:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt
gerrit-hooks has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
Idan Shaby has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 215:
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
Freddy Rolland has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 216:
gerrit-hooks has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
*
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50809
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50806
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50808
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50807
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK,
Nir Soffer has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1:
I think you should first merge this into ovirt-3.6 before backporting to
ovirt-3.5.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 6:
* #1281940::Update tracker: OK
* Set MODIFIED::bug 1281940#1281940OK
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(4 comments)
Nice
https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line
Jenkins CI has posted comments on this change.
Change subject: hooks: ovs: show vlan in caps ports
..
Patch Set 4: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 3
--
To
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 1:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
*
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50787
to review the following change.
Change subject: gluster: Handle missing glusterfs-cli package
..
gluster:
Edward Haas has uploaded a new change for review.
Change subject: net: Update mtu under the bridge only when needed
..
net: Update mtu under the bridge only when needed
Updating the mtu of an existing bridge and its ports,
only
gerrit-hooks has posted comments on this change.
Change subject: net: Update mtu under the bridge only when needed
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1:
* #1276445::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 22:
(4 comments)
https://gerrit.ovirt.org/#/c/42908/22//COMMIT_MSG
Commit Message:
Line 29: ---
Line 30:
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50807
to review the following change.
Change subject: gluster add mount options for gluster brick.
..
gluster add
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50809
to review the following change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50806
to review the following change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50808
to review the following change.
Change subject: gluster: fix size conversion issues in brick create
..
gluster:
Hello Nir Soffer, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50805
to review the following change.
Change subject: gluster: create bricks without MBR partitions
..
gluster:
gerrit-hooks has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
*
Ramesh N has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1:
This is a special branch for gluster :-). But Yes. I have to back port the
patches to ovirt 3.6 as
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: show vlan in caps ports
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 22:
(4 comments)
https://gerrit.ovirt.org/#/c/42908/22//COMMIT_MSG
Commit Message:
Line 29: ---
Line
Freddy Rolland has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 216:
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3:
I have verified this patch in Fedora, RHEL 6 and RHEL 7 platforms.
Also i tried creating brick
Freddy Rolland has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit
Idan Shaby has posted comments on this change.
Change subject: fileSD: fix deleteImage flow
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 215:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: startup: Change system default encoding to utf8
..
startup: Change system default encoding to utf8
In Python 2, the system default encoding is
Dan Kenigsberg has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 5:
I cannot say that I like it, as it is hiding deeply-entrenched bugs of Vdsm
failing to decode
Piotr Kliczewski has posted comments on this change.
Change subject: p3test: add few modules that currently pass on Python 3
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50647
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: list all attached nics in caps ports
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: caps vlan vlanid property has to be int
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ramesh N has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50851
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50852
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 2:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 2:
* #1293537::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1293537::OK,
gerrit-hooks has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 2:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 2:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 2:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 2:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK,
Sahina Bose has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit
Sahina Bose has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: vm.py: Fixed typo speficy->specify
..
vm.py: Fixed typo speficy->specify
Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Signed-off-by: Allon Mureinik
gerrit-hooks has posted comments on this change.
Change subject: vm.py: Fixed typo speficy->specify
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Allon Mureinik has posted comments on this change.
Change subject: vm.py: Fixed typo speficy->specify
..
Patch Set 1: Verified+1
Verification: This is a fix to a comment, runtime is not affected. The read the
comment and
Ramesh N has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50849
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK,
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 1:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
1 - 100 of 202 matches
Mail list logo
