Change in vdsm[master]: net: mtu should be reported as a string through caps

Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634:

Change in vdsm[master]: jobs: Replace validation method with a property

Nir Soffer has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51216 To unsubscribe, visit

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

Nir Soffer has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51217 To unsubscribe, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: Verified by running all networking functional tests. They cover these points: - setupNetwork

Change in vdsm[master]: net: mtu should be reported as a string through caps

Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

Dan Kenigsberg has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe,

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpcvdscli: improve functional network tests duration time .. jsonrpcvdscli: improve functional network tests duration time The tests were creating

Change in vdsm[master]: net: mtu should be reported as a string through caps

Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) could you state how this was verified?

Change in vdsm[master]: net: mtu should be reported as a string through caps

Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: mtu should be reported as a string through caps

Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: PoC: enforcement of contract for rpc

Nir Soffer has posted comments on this change. Change subject: PoC: enforcement of contract for rpc .. Patch Set 2: Code-Review-1 (14 comments) https://gerrit.ovirt.org/#/c/50032/2//COMMIT_MSG Commit Message: Line 7: PoC:

Change in vdsm[master]: jobs: Remove unused method

gerrit-hooks has posted comments on this change. Change subject: jobs: Remove unused method .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: tests: Test default Job.progress implementation

Nir Soffer has posted comments on this change. Change subject: tests: Test default Job.progress implementation .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51213 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid

gerrit-hooks has posted comments on this change. Change subject: net: netconf owner change should ignore gid .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: netconf owner change should ignore gid .. net: netconf owner change should ignore gid When changing ownership of the directories/files the group

Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid

Dan Kenigsberg has posted comments on this change. Change subject: net: netconf owner change should ignore gid .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51149 To unsubscribe, visit

Change in vdsm[master]: jobs: Take lock once when deleting a job

Nir Soffer has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51215 To unsubscribe, visit

Change in vdsm[master]: jobs: Remove unused method

Nir Soffer has posted comments on this change. Change subject: jobs: Remove unused method .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51214 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

gerrit-hooks has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jobs: Take lock once when deleting a job

Nir Soffer has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: Continuous-Integration+1 CI failure not relevant (mount loop device failures) -- To view, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: tests: Test default Job.progress implementation

Nir Soffer has uploaded a new change for review. Change subject: tests: Test default Job.progress implementation .. tests: Test default Job.progress implementation Test jobs.Job.progress, and add ProgressingJob class for

Change in vdsm[master]: tests: Test default Job.progress implementation

gerrit-hooks has posted comments on this change. Change subject: tests: Test default Job.progress implementation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jobs: Take lock once when deleting a job

Nir Soffer has uploaded a new change for review. Change subject: jobs: Take lock once when deleting a job .. jobs: Take lock once when deleting a job Previous we use get() for checking if a job exists before deleting it, and

Change in vdsm[master]: jobs: Take lock once when deleting a job

gerrit-hooks has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jobs: Remove unused method

Nir Soffer has uploaded a new change for review. Change subject: jobs: Remove unused method .. jobs: Remove unused method Nobody is calling Job.validate_done(), and I don't want to add test for code that we don't need.

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

Nir Soffer has uploaded a new change for review. Change subject: jobs: Add Job.__repr__ for easier debugging .. jobs: Add Job.__repr__ for easier debugging Every object should have __repr__ to make it easy to have more detailed

Change in vdsm[master]: jobs: Replace validation method with a property

gerrit-hooks has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jobs: Replace validation method with a property

Nir Soffer has uploaded a new change for review. Change subject: jobs: Replace validation method with a property .. jobs: Replace validation method with a property Replace Job.validate_not_active() with an Job.active property.

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

gerrit-hooks has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: mtu should be reported as a string through caps

Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: monitor: Convert valid to read-only property

gerrit-hooks has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39088 To

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

gerrit-hooks has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: monitor: Convert valid to read-only property

Jenkins CI RO has abandoned this change. Change subject: monitor: Convert valid to read-only property .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

Jenkins CI RO has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: vmdevices: move storage methods to storage module

Jenkins CI RO has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

Jenkins CI RO has abandoned this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: monitor: Convert valid to read-only property

Jenkins CI RO has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: vmdevices: move storage methods to storage module

Jenkins CI RO has abandoned this change. Change subject: vmdevices: move storage methods to storage module .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: net: mtu should be reported as a string through caps

Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634:

Change in vdsm[master]: vmdevices: move storage methods to storage module

gerrit-hooks has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40133