Change in vdsm[master]: net api: Canonize the network bridged flag

Edward Haas has posted comments on this change. Change subject: net api: Canonize the network bridged flag .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/52482 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Francesco Romani has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: Code-Review+1 (1 comment) partial ACK, deeper review (to make sure all

Change in vdsm[master]: net: Refactor _canonize_networks for readablity

Edward Haas has posted comments on this change. Change subject: net: Refactor _canonize_networks for readablity .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/52478 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Piotr Kliczewski has uploaded a new change for review. Change subject: migration: set timeout to 10 mins .. migration: set timeout to 10 mins On heavily loaded environments createMigration call can take a lot of time so we want

Change in vdsm[ovirt-3.5]: utils: add weakmethod helper

Hello Nir Soffer, Martin Polednik, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/52557 to review the following change. Change subject: utils: add weakmethod helper .. utils: add weakmethod

Change in vdsm[master]: terminating tests - verify process death

Yaniv Bronhaim has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/52362/5/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

Milan Zamazal has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

gerrit-hooks has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: * #1188543::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1188543::OK, public bug * Check

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Vinzenz Feenstra has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52548 To unsubscribe, visit

Change in vdsm[master]: virt: stats: make compute_latency more robust

Martin Polednik has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 11: Code-Review-1 (4 comments) Some naming issues and inconsistencies. +1 for the improvement,

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Francesco Romani has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+2 raising score, will merge once Jankins is happy. -- To view, visit

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Martin Polednik has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/52548/2/lib/vdsm/config.py.in File

Change in vdsm[master]: hooks: moving hook error to exception module

Piotr Kliczewski has posted comments on this change. Change subject: hooks: moving hook error to exception module .. Patch Set 2: Verified with the engine not knowing about code 1500. Here is the exception hierarchy on the

Change in vdsm[ovirt-3.5]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[ovirt-3.5]: lib: use weakmethod to break reference cycles

Hello Piotr Kliczewski, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/52558 to review the following change. Change subject: lib: use weakmethod to break reference cycles .. lib: use

Change in vdsm[ovirt-3.5]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[master]: virt: stats: make disk_rate more robust

Martin Polednik has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 14: Code-Review+1 It is an improvement over previous version. What I don't like (and it's not this patch

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Piotr Kliczewski has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Verified+1 Run migration using 2 hosts on f22. The migration was successful and correct timeout was used

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Martin Polednik has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 11: Code-Review-1 (1 comment) Same as 50593. If you decide not to touch either, i'd raise the

Change in vdsm[master]: net: Refactor _canonize_networks for readablity

gerrit-hooks has posted comments on this change. Change subject: net: Refactor _canonize_networks for readablity .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net api: Canonize the network stp flag

gerrit-hooks has posted comments on this change. Change subject: net api: Canonize the network stp flag .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net api: Canonize the network bridged flag

gerrit-hooks has posted comments on this change. Change subject: net api: Canonize the network bridged flag .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: stats: make disk_rate more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 14: Martin, good point. Will address this in a future series. -- To view, visit

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Milan Zamazal has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52548 To unsubscribe, visit

Change in vdsm[master]: net api: Canonize the network stp flag

Edward Haas has posted comments on this change. Change subject: net api: Canonize the network stp flag .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/52495 To unsubscribe, visit

Change in vdsm[master]: net: drop isolatedCommand handling

gerrit-hooks has posted comments on this change. Change subject: net: drop isolatedCommand handling .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: add support for arbiter volumes

gerrit-hooks has posted comments on this change. Change subject: gluster: add support for arbiter volumes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

Francesco Romani has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47404 To

Change in vdsm[master]: virt: do not use status after getStat()

Martin Polednik has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40522 To unsubscribe, visit

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 6: Verified+1 Verified by testing with engine knowing nothing about code 1500. -- To

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 11: Verified+1 re-verified (48493, 50593, 50594) booting one vm and requesting I/O (md5sum

Change in vdsm[master]: virt: stats: make compute_latency more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 11: Verified+1 re-verified (48493, 50593, 50594) booting one vm and requesting I/O (md5sum

Change in vdsm[master]: virt: stats: make disk_rate more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 14: Verified+1 re-verified (48493, 50593, 50594) booting one vm and requesting I/O (md5sum /dev/vda).

Change in vdsm[master]: gluster: add support for arbiter volumes

Ramesh N has uploaded a new change for review. Change subject: gluster: add support for arbiter volumes .. gluster: add support for arbiter volumes Add support for arbiter gluster volume creations. Also include arbiter count

Change in vdsm[master]: gluster: add support for arbiter volumes

gerrit-hooks has posted comments on this change. Change subject: gluster: add support for arbiter volumes .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: lib: add tests for utils.weakmethod

gerrit-hooks has posted comments on this change. Change subject: tests: lib: add tests for utils.weakmethod .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Due to systemd we don't require to use deathSignal to kill f...

Piotr Kliczewski has posted comments on this change. Change subject: Due to systemd we don't require to use deathSignal to kill fence scripts .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52484 To

Change in vdsm[master]: tests: lib: add tests for utils.weakmethod

Francesco Romani has posted comments on this change. Change subject: tests: lib: add tests for utils.weakmethod .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/52408/1/tests/utilsTests.py File tests/utilsTests.py:

Change in vdsm[master]: tests: simplify bridge tests

gerrit-hooks has posted comments on this change. Change subject: tests: simplify bridge tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hooks: moving hook error to exception module

gerrit-hooks has posted comments on this change. Change subject: hooks: moving hook error to exception module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

gerrit-hooks has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 6: * #1295778::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1295778::OK,

Change in vdsm[master]: vdsm: introduce cpuinfo module

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: introduce cpuinfo module .. vdsm: introduce cpuinfo module The objective of the new modules is encapsulating functionality related to CPU from

Change in vdsm[master]: vdsm: introduce cpuinfo module

gerrit-hooks has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: api: expose stop and start of profilers

gerrit-hooks has posted comments on this change. Change subject: api: expose stop and start of profilers .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

Francesco Romani has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 partial ACK: looks good, waiting for other reviews. -- To view, visit

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 13: -Code-Review Let's have it finished -- To view, visit https://gerrit.ovirt.org/48871 To

Change in vdsm[ovirt-3.6]: resourceManager: Fix ResourceRef leak

Hello Adam Litke, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/52563 to review the following change. Change subject: resourceManager: Fix ResourceRef leak .. resourceManager: Fix

Change in vdsm[ovirt-3.6]: resourceManager: Fix ResourceRef leak

gerrit-hooks has posted comments on this change. Change subject: resourceManager: Fix ResourceRef leak .. Patch Set 1: * #1269424::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269424::OK, public bug * Check

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py File

Change in vdsm[master]: terminating tests - verify process death

Nir Soffer has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/52362/4/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4

Dan Kenigsberg has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52366 To unsubscribe, visit

Change in vdsm[master]: imagetickets: Support image tickets

Nir Soffer has posted comments on this change. Change subject: imagetickets: Support image tickets .. Patch Set 11: (19 comments) https://gerrit.ovirt.org/#/c/50014/11/lib/api/vdsmapi-schema.json File

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

Francesco Romani has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 15: Code-Review+2 (3 comments) good enough, raising score. There are a couple of places

Change in vdsm[master]: vdsm: introduce cpuinfo module

Francesco Romani has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 28: Code-Review+2 Nice job! (+1) These changes are in the shared area, but I volunteer to own them (+2). -- To

Change in vdsm[ovirt-3.6]: migration: set timeout to 10 mins

gerrit-hooks has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 1: * #1188543::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1188543::OK, public bug * Check

Change in vdsm[master]: terminating tests - verify process death

Nir Soffer has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 4: (11 comments) Nice tests https://gerrit.ovirt.org/#/c/52362/4/tests/utilsTests.py File

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

Francesco Romani has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 15: Code-Review+1 quick review: looks good. Need to spend more time, especially on tests.

Change in vdsm[master]: terminating tests - verify process death

Nir Soffer has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/52362/4/tests/utilsTests.py File tests/utilsTests.py: Line 88:

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 3: Code-Review-1 Please fix the tests and make sure the tests are successful locally

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 3: sure, I thought that "make rpm" should also check the tests, but apparently it

Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: vdsClient fails to connect to an IPv6 addr .. net: vdsClient fails to connect to an IPv6 addr When vdsClient is used on a non-ipv6 host, and no

Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr

gerrit-hooks has posted comments on this change. Change subject: net: vdsClient fails to connect to an IPv6 addr .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Francesco Romani has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/52463/4/tests/vmTests.py File

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/52463/4/tests/vmTests.py File

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/52463 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52515 To unsubscribe, visit

Change in vdsm[master]: terminating tests - verify process death

Yaniv Bronhaim has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/52362/4/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: * #1299235::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299235::OK,

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: Code-Review+1 Continuous-Integration+1 (1 comment) CI failure is not relevant

Change in vdsm[master]: terminating tests - verify process death

gerrit-hooks has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: health: Warn about delays in monitor threads

Piotr Kliczewski has posted comments on this change. Change subject: health: Warn about delays in monitor threads .. Patch Set 1: (1 comment) I like the idea, hopefully it would help use solve the issue. Please update

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

Martin Polednik has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 15: Code-Review+1 Also tested it on ppc and it is definitely somewhat better than before,

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/50594/11/vdsm/virt/vmstats.py File

Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...

Sandro Bonazzola has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: Nice start, you're on the right way. -- To view, visit

Change in vdsm[master]: virt: stats: make compute_latency more robust

Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 11: (4 comments) https://gerrit.ovirt.org/#/c/50593/11/vdsm/virt/vmstats.py File

Change in vdsm[master]: faqemu: refactor and update

gerrit-hooks has posted comments on this change. Change subject: faqemu: refactor and update .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vdsm: move fake_kvm code into faqemu

gerrit-hooks has posted comments on this change. Change subject: vdsm: move fake_kvm code into faqemu .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: native ovs

gerrit-hooks has posted comments on this change. Change subject: native ovs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: virt: stats: make compute_latency more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 12: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug *

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 12: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug *

Change in vdsm[master]: v2v: tests: new testing class: MockVirConnectTests

gerrit-hooks has posted comments on this change. Change subject: v2v: tests: new testing class: MockVirConnectTests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

gerrit-hooks has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vdsm: move fake_kvm code into faqemu

Francesco Romani has posted comments on this change. Change subject: vdsm: move fake_kvm code into faqemu .. Patch Set 18: Code-Review+1 (2 comments) looks good, but a couple of suggestion in the hook. Partial ACK for this

Change in vdsm[master]: Return deep copy from GuestAgent.getGuestInfo()

gerrit-hooks has posted comments on this change. Change subject: Return deep copy from GuestAgent.getGuestInfo() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 33: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[ovirt-3.5]: lib: use weakmethod to break reference cycles

Piotr Kliczewski has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52558 To unsubscribe, visit

Change in vdsm[master]: Return deep copy from GuestAgent.getGuestInfo()

Francesco Romani has posted comments on this change. Change subject: Return deep copy from GuestAgent.getGuestInfo() .. Patch Set 2: Code-Review+2 codewise looks OK. Let's check, as part of verification, that the performance

Change in vdsm[master]: Return deep copy from GuestAgent.getGuestInfo()

Milan Zamazal has posted comments on this change. Change subject: Return deep copy from GuestAgent.getGuestInfo() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52499/1/vdsm/virt/guestagent.py File

Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4

Piotr Kliczewski has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py File vdsm/clientIF.py:

Change in vdsm[master]: virt: stats: make disk_rate more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 15: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check

Change in vdsm[master]: native ovs

gerrit-hooks has posted comments on this change. Change subject: native ovs .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: native ovs

gerrit-hooks has posted comments on this change. Change subject: native ovs .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: native ovs

gerrit-hooks has posted comments on this change. Change subject: native ovs .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

Javier Coscia has posted comments on this change. Change subject: Hook: ide2sata: To switch IDE disks to SATA .. Patch Set 6: (5 comments) https://gerrit.ovirt.org/#/c/48450/6/vdsm.spec.in File vdsm.spec.in: Line 611:

Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

gerrit-hooks has posted comments on this change. Change subject: Hook: ide2sata: To switch IDE disks to SATA .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: simplify bridge tests

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: simplify bridge tests .. tests: simplify bridge tests Change-Id: I02f9fb60898b49f63915ac6a26b6e62d5e09a4d0 Signed-off-by: pkliczewski

Change in vdsm[master]: tests: simplify bridge tests

gerrit-hooks has posted comments on this change. Change subject: tests: simplify bridge tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: Run %systemd_post on all effected unit files

Dan Kenigsberg has posted comments on this change. Change subject: Run %systemd_post on all effected unit files .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/52537/1/vdsm.spec.in File vdsm.spec.in:

Change in vdsm[master]: net: Refactor _canonize_networks for readablity

Dan Kenigsberg has posted comments on this change. Change subject: net: Refactor _canonize_networks for readablity .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52478 To unsubscribe, visit

Change in vdsm[master]: net: Refactor _canonize_networks for readablity

gerrit-hooks has posted comments on this change. Change subject: net: Refactor _canonize_networks for readablity .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

  1   2   >