Nir Soffer has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 2: Code-Review+1
Looks good, but I will need deeper check to verify that we don't assume single
Edward Haas has posted comments on this change.
Change subject: net: native ovs [4]: move RollbackIncomplete to network errors
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55311
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 2:
* #1322933::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1322933::OK, public
Edward Haas has posted comments on this change.
Change subject: net: native ovs [3]: validate networks and bonds
..
Patch Set 4: Code-Review-1
(10 comments)
https://gerrit.ovirt.org/#/c/55310/4/lib/vdsm/common/contextlib.py
Dan Kenigsberg has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 11:
I run `make rpm` and see this.
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 28:
(4 comments)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 41: Find
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 73: def
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 15: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/50221/15/vdsm/storage/sdm/api/base.py
File
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: Introduce VolumeArtifacts
..
Introduce VolumeArtifacts
In an SDM managed storage domain we will create and remove volumes using
a garbage collection
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 28: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 27:
(2 comments)
https://gerrit.ovirt.org/#/c/48097/27/tests/storage_volume_artifacts_test.py
File
Adam Litke has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 28: Verified+1
--
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 15:
(8 comments)
https://gerrit.ovirt.org/#/c/50221/8/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3688
Line 3689
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storageServer: Remove unused instance variable
..
Patch Set 1: Verified+1
Untested, but should be safe enough for deadcode.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 27: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/48097/26/tests/storage_volume_artifacts_test.py
File
Edward Haas has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 6: Code-Review-1
(2 comments)
A few suggestions:
- Canonicalize old ovs marking to the 'switch'
Nir Soffer has uploaded a new change for review.
Change subject: storageServer: Remove unused instance variable
..
storageServer: Remove unused instance variable
IscsiConnection._lastSessionId is not used since commit
gerrit-hooks has posted comments on this change.
Change subject: storageServer: Remove unused instance variable
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 1:
(2 comments)
Add back commments from deleted patch.
I'm not sure this is enough, there may be
Adam Litke has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 2: Code-Review+1
Looks good after you address Nir's last remaining comment.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 1:
* #1322933::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1322933::OK, public
Nir Soffer has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 1:
(3 comments)
Thanks Pavel!
Please post again to master, I cannot access the master version
gerrit-hooks has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 1: Verified-1
* #1322933::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 1:
* #1322933::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1322933::OK, public
gerrit-hooks has posted comments on this change.
Change subject: HACK: virt: override vm type from custom property
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hook: add imagerepo feed containers
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: containers: always add emulator to XML
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: WIP: vm: skip domDependentInit for containers
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: containers: initial support
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: virt: recovery: refactor entry points
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: WIP: vm: skip domDependentInit for containers
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sudo: add permissions to run containers
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: containers: initial support
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: containers: detect and report container support
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: HACK: virt: override vm type from custom property
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hook: add imagerepo feed containers
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: containers: make sure directory are ready
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: containers: always add emulator to XML
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Artyom Lukianov has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 11:
Can you say me when you see this error?
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: schema: restore still used types
..
Patch Set 1: Verified+1
I noticed issue when updating the new yaml schema. We still need to have thos
types for
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: restore still used types
..
schema: restore still used types
It looks like we removed whole category when we removed unused storage
methods but some
gerrit-hooks has posted comments on this change.
Change subject: schema: restore still used types
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Artyom Lukianov has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 11: -Verified
hm I was sure everything is fine with deployment because install and erase
worked fine for vdms
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 28: Verified+1
Fixes as Nir wanted, updated schema based on merged patches with changes to
json schema. Verified by
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 11: Verified+1
Code rebased. Verified by updating existing vdsm and seeing that communication
works without any
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 16: Verified+1
Code rebased. Verified by updating existing vdsm and seeing that communication
works without any
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: bridge: fix naming style
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55537
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3: Code-Review+2
Schema change looks good now
--
To view, visit https://gerrit.ovirt.org/47519
Francesco Romani has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3: Code-Review+1
most comments where about the schema, once that's fixed, the patch is fine for
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/47519/2/lib/api/vdsmapi-schema.json
File
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3:
* #1273399::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1273399::OK, public bug
*
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/47519
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/47519/2/lib/api/vdsmapi-schema.json
File
Piotr Kliczewski has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/47519/2/lib/api/vdsmapi-schema.json
Francesco Romani has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3: Verified+1
not sure we want this on branch 3.6. Not needed to fix bz1309884.
However, verified
Dan Kenigsberg has submitted this change and it was merged.
Change subject: API: net: introduce 'switch' attribute for nets and bonds
..
API: net: introduce 'switch' attribute for nets and bonds
'switch' attribute is needed
gerrit-hooks has posted comments on this change.
Change subject: API: net: introduce 'switch' attribute for nets and bonds
..
Patch Set 4:
* #1195208::Update tracker: OK
* Set MODIFIED::bug 1195208#1195208IGNORE, not
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotplug
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55537
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2:
* #1260131::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/54547
To unsubscribe, visit
Milan Zamazal has abandoned this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Abandoned
Duplicate of http://gerrit.ovirt.org/54796
--
To view, visit https://gerrit.ovirt.org/54547
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 2:
* #1292096::Update tracker: OK
* Set MODIFIED::bug 1292096#1292096IGNORE, not all related patches are
Francesco Romani has submitted this change and it was merged.
Change subject: spec: bump libvirt requirement
..
spec: bump libvirt requirement
Consume fix to handle imports from vmware.
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55570
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 1: Verified+1
verified on branch on centos 7.x, same results of master
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55570
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: API: net: introduce 'switch' attribute for nets and bonds
..
Patch Set 3: Code-Review+2
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 1:
* #1292096::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292096::OK, public bug
* Check
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55570
to review the following change.
Change subject: spec: bump libvirt requirement
..
spec: bump libvirt requirement
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement
..
Patch Set 2:
* #1292096::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292096::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2: Code-Review-1
ahhh, race condition. I've already merged https://gerrit.ovirt.org/#/c/54796/
--
To
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 6:
* #1292096::Update tracker: OK
* Set MODIFIED::bug 1292096#1292096IGNORE, not all related patches are
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: bump libvirt requirement
..
spec: bump libvirt requirement
Consume fix to handle imports from vmware.
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2:
please also check:
https://gerrit.ovirt.org/#/c/54796/5
patches are identical, we just need to add
Francesco Romani has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 5: Verified+1
this is now available on CentOS/RHEL, but please also check
https://gerrit.ovirt.org/#/c/54547/2
Francesco Romani has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54547
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2:
I think you can piggyback on https://gerrit.ovirt.org/#/c/54796/
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2:
Actually, it should be the other way around :)
--
To view, visit https://gerrit.ovirt.org/54547
To
Milan Zamazal has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2: Verified+1
Verified that the rpm package installs on current CentOS and a VM with
non-ASCII characters
gerrit-hooks has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2:
* #1260131::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260131::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 2: Verified-1
CI error is real
--
To view, visit https://gerrit.ovirt.org/55537
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 73:
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 3:
* #1309884::Update tracker: OK
* Set MODIFIED::bug 1309884#1309884IGNORE, not oVirt
1 - 100 of 117 matches
Mail list logo