Change in vdsm[master]: virt: Set timeout on boot menu

Milan Zamazal has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: Verified+1 Verified by enabling boot menu and checking the menu prompt remains on the VM startup for about the

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Petr Horáček has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 4: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe,

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: OvsTestCase

Edward Haas has posted comments on this change. Change subject: net: native ovs: OvsTestCase .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/56391/6/tests/network/ovsnettestlib.py File tests/network/ovsnettestlib.py:

Change in vdsm[master]: virt: Set timeout on boot menu

Milan Zamazal has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56393/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: PS2, Line

Change in vdsm[master]: tests: FakeLVM: Always create lv file

Adam Litke has posted comments on this change. Change subject: tests: FakeLVM: Always create lv file .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56169 To unsubscribe, visit

Change in vdsm[master]: virt: Set timeout on boot menu

gerrit-hooks has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: * #1324375::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1324375::OK, public bug * Check

Change in vdsm[master]: net: native ovs: introduce constants module

Petr Horáček has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 6: Verified+1 Passed ovs_test.py and: >>> from vdsm.network.ovs.constants import BRIDGE_NAME >>>

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: check for bond existence

Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 3: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/55958/17/automation/check-patch.repos.el7 File automation/check-patch.repos.el7: Line

Change in vdsm[master]: net: native ovs: check for nic existence

Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 5: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit

Change in vdsm[master]: virt: Set timeout on boot menu

Francesco Romani has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 2: Code-Review+1 +2 on hold -- To view, visit https://gerrit.ovirt.org/56393 To unsubscribe, visit

Change in vdsm[master]: virt: Set timeout on boot menu

Francesco Romani has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56393/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: PS2, Line

Change in vdsm[master]: virt: Set timeout on boot menu

Francesco Romani has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56393 To unsubscribe, visit

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

Francesco Romani has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56459 To unsubscribe,

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

Francesco Romani has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 1: initial review, looks ok at first glance, more comments later -- To view, visit

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

Francesco Romani has posted comments on this change. Change subject: kvm@ovirt: tool for streaming images from libvirt .. Patch Set 2: (10 comments) minor comments, since the heavy lifting is done now by the directio module.

Change in vdsm[master]: net: native ovs: check for bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: check for nic existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: check for bond existence

Petr Horáček has uploaded a new change for review. Change subject: net: native ovs: check for bond existence .. net: native ovs: check for bond existence Network creation is not connected with bond creation in any way, created

Change in vdsm[master]: net: native ovs: check for bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: client: do not protect requests on client side

Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (2 comments) change the parameter name please.

Change in vdsm[master]: virt: Set timeout on boot menu

gerrit-hooks has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 2: * #1324375::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1324375::OK, public bug * Check

Change in vdsm[master]: contrib: schema converter

Yaniv Bronhaim has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 35: (1 comment) https://gerrit.ovirt.org/#/c/52864/35/lib/api/json_schema.py File lib/api/json_schema.py: Line 1:

Change in vdsm[master]: net: native ovs: check for nic existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: json: removal of old schemas

Yaniv Bronhaim has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit

Change in vdsm[master]: automation: Run make check over el7 in automation CI

Yaniv Bronhaim has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 5: lets just merge https://gerrit.ovirt.org/#/c/56152/2 first - I think it is verified

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

Nir Soffer has posted comments on this change. Change subject: kvm@ovirt: tool for streaming images from libvirt .. Patch Set 2: (14 comments) Partial review https://gerrit.ovirt.org/#/c/55797/2//COMMIT_MSG Commit Message:

Change in vdsm[master]: net: native ovs: OvsTestCase

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: OvsTestCase .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: automation: Run make check over el7 in automation CI

Nir Soffer has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 4: Yaniv, should we rebase this patch on https://gerrit.ovirt.org/56152 to solve the python-pep8

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

gerrit-hooks has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

Shahar Havivi has uploaded a new change for review. Change subject: v2v: add support for importing kvm based vms from libvirt .. v2v: add support for importing kvm based vms from libvirt Change-Id:

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

gerrit-hooks has posted comments on this change. Change subject: kvm@ovirt: tool for streaming images from libvirt .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: OVS driver - bond_slave commands

Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files

Ondřej Svoboda has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 2: (2 comments) I agree that a synchronous way to unmanage devices is a much safer thing to do.

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for nic/bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic/bond existence .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for nic/bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic/bond existence .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Petr Horáček has uploaded a new change for review. Change subject: net: native ovs: reserve ovsbr0 network name .. net: native ovs: reserve ovsbr0 network name Don't allow user to set network name 'ovsbr0' as it is reserved by

Change in vdsm[master]: net: native ovs: introduce constants module

Petr Horáček has uploaded a new change for review. Change subject: net: native ovs: introduce constants module .. net: native ovs: introduce constants module We need to share some constants accross many OVS modules. This will

Change in vdsm[master]: net: native ovs: introduce constants module

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: events: introduction of schema

Francesco Romani has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 15: Code-Review-1 (3 comments) questions inside, -1 for visibility

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vdsmapi: prepare for event naming

Francesco Romani has posted comments on this change. Change subject: vdsmapi: prepare for event naming .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55999 To unsubscribe, visit

Change in vdsm[master]: migration: move helper into Progress class

Milan Zamazal has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit

Change in vdsm[master]: json: removal of old schemas

Francesco Romani has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 19: Code-Review+1 straightforward patch once the previous change are OK. -- To view, visit

Change in vdsm[master]: yml: generate api doc from the schema

Yaniv Bronhaim has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 1: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/56387/1/lib/api/Makefile.am File

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit

Change in vdsm[master]: net: OVS driver - bond_slave commands

gerrit-hooks has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has uploaded a new change for review. Change subject: net: OVS driver - bond_slave commands .. net: OVS driver - bond_slave commands The *bond_slave commands are a bit special, they are composed of two sub-commands.

Change in vdsm[master]: contrib: schema converter

Francesco Romani has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 35: (8 comments) Still pending to review (just glanced): - schema-converter - vdsm-api.yml - the virt parts, another

Change in vdsm[master]: net: OVS driver

Yaniv Bronhaim has posted comments on this change. Change subject: net: OVS driver .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/55958/17/automation/check-patch.repos.el7 File automation/check-patch.repos.el7:

Change in vdsm[master]: migration: validate progress fields from libvirt

Milan Zamazal has posted comments on this change. Change subject: migration: validate progress fields from libvirt .. Patch Set 4: Code-Review+1 Fine, I just still suggest adding a notice to the commit message why we need to

Change in vdsm[master]: net: native ovs: check for nic/bond existence

gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic/bond existence .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for nic/bond existence

Petr Horáček has uploaded a new change for review. Change subject: net: native ovs: check for nic/bond existence .. net: native ovs: check for nic/bond existence OVS allows us to add a port which does not exist, so it won't

Change in vdsm[ovirt-3.6]: network: replace NM_CONTROLLED=no with 'yes'

Ondřej Svoboda has uploaded a new change for review. Change subject: network: replace NM_CONTROLLED=no with 'yes' .. network: replace NM_CONTROLLED=no with 'yes' This is for testing only (on 3.6). Change-Id:

Change in vdsm[ovirt-3.6]: network: replace NM_CONTROLLED=no with 'yes'

gerrit-hooks has posted comments on this change. Change subject: network: replace NM_CONTROLLED=no with 'yes' .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url

Change in vdsm[master]: bridge: usage of yaml schema

Francesco Romani has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py File lib/api/schemaapi.py: PS18, Line

Change in vdsm[master]: net: OVS driver

Petr Horáček has posted comments on this change. Change subject: net: OVS driver .. Patch Set 18: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Francesco Romani has submitted this change and it was merged. Change subject: host stats: Collect stats from online cpu cores only .. host stats: Collect stats from online cpu cores only When a cpu goes offline while libvirtd

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Francesco Romani has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56188 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

gerrit-hooks has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 5: * #1264003::Update tracker: OK * Set MODIFIED::bug 1264003#1264003OK -- To view,

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Roman Mohr has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 4: Verified+1 Verified by 1) installing vdsm 2) waiting for getVdsStats to give cpu statistics

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Francesco Romani has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 4: Code-Review+1 looks ok (including the extra whitespaces), please verify -- To view,

Change in vdsm[master]: jsonrpc: handle strings as correct response

Francesco Romani has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56207 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Roman Mohr has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56188/3/vdsm/virt/sampling.py File

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

gerrit-hooks has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 4: * #1264003::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1264003::OK, public

Change in vdsm[master]: network: replace NM_CONTROLLED=no with 'yes'

gerrit-hooks has posted comments on this change. Change subject: network: replace NM_CONTROLLED=no with 'yes' .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: network: replace NM_CONTROLLED=no with 'yes'

Ondřej Svoboda has uploaded a new change for review. Change subject: network: replace NM_CONTROLLED=no with 'yes' .. network: replace NM_CONTROLLED=no with 'yes' This is for testing only. Change-Id:

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

Francesco Romani has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56188/3/vdsm/virt/sampling.py File

Change in vdsm[master]: migration: add 'ongoing' property to Progress

gerrit-hooks has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: move helper into Progress class

gerrit-hooks has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: validate progress fields from libvirt

gerrit-hooks has posted comments on this change. Change subject: migration: validate progress fields from libvirt .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.6]: host stats: Collect stats from online cpu cores only

gerrit-hooks has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 3: * #1264003::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1264003::OK, public

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files

Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 2: Code-Review-1 (2 comments) -1 for the NM restart.

Change in vdsm[master]: tests/functional: Remove storage tests references from virtT...

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests/functional: Remove storage tests references from virtTests .. tests/functional: Remove storage tests references from virtTests

Change in vdsm[master]: tests/functional: Remove storage tests references from virtT...

gerrit-hooks has posted comments on this change. Change subject: tests/functional: Remove storage tests references from virtTests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 18: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/55958/17/lib/vdsm/network/ovs/driver/vsctl.py File

<    1   2