Ondřej Svoboda has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files ......................................................................
Patch Set 2: (2 comments) I agree that a synchronous way to unmanage devices is a much safer thing to do. https://gerrit.ovirt.org/#/c/56365/2/vdsm.spec.in File vdsm.spec.in: PS2, Line 811: if /bin/systemctl status NetworkManager; then > no, I was somehow misunderstood. I don't want you to touch NetwrorkManager It is stopped and disabled indeed. In that case this code does nothing. If NM was left running, I think it should be restarted at some point before VDSM starts to introduce its own ifcfg files. Certainly before we run ifup. Do you think NetworkManager should be restarted via VDSM's systemd units instead? https://gerrit.ovirt.org/#/c/56365/2/vdsm/90-vdsm-monitor-connection-files.conf File vdsm/90-vdsm-monitor-connection-files.conf: Line 1: # This file is necessary to let VDSM properly consume connections owned by Line 2: # NetworkManager (to make it unmanage them), primarily on ifcfg systems. Line 3: Line 4: [main] Line 5: monitor-connection-files=true > from NetworkManager.conf man page: Yes, 'nmcli conn reload' was made for this purpose. But since we may run ifup a couple of times during configuration (and not just at the end), I think we should call 'nmcli conn load [ifcfg-file]' from each _ifup. [However, I would like to have my approach tried out first. We write our ifcfg files in one block, as they are small. We don't write them in the midst of editing. The effect on NetworkManager is immediate: it only has to change state for a given connection, after reading the file (okay, here is the race, it may not always be immediate).] -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
