Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files ......................................................................
Patch Set 2: Code-Review-1 (2 comments) -1 for the NM restart. https://gerrit.ovirt.org/#/c/56365/2/vdsm.spec.in File vdsm.spec.in: PS2, Line 811: if /bin/systemctl status NetworkManager; then > Dan, you said that NM should be restarted if we upgraded from a VDSM versio no, I was somehow misunderstood. I don't want you to touch NetwrorkManager here. it is still stopped and disabled on ovirt-host-deploy, and we should not restart it here. https://gerrit.ovirt.org/#/c/56365/2/vdsm/90-vdsm-monitor-connection-files.conf File vdsm/90-vdsm-monitor-connection-files.conf: Line 1: # This file is necessary to let VDSM properly consume connections owned by Line 2: # NetworkManager (to make it unmanage them), primarily on ifcfg systems. Line 3: Line 4: [main] Line 5: monitor-connection-files=true from NetworkManager.conf man page: "Automatic reloading is not advised because there are race conditions involved and it depends on the way how the editor updates the file. In some situations, NetworkManager might first delete and add the connection anew, instead of updating the existing one. Also, NetworkManager might pick up incomplete settings while the user is still editing the files." Can we instead explicitly tell NM to re-read the connection files after we have written them all? -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
