gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
Dan Kenigsberg has uploaded a new change for review.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
net tests: take2: wait for a concurrent iptables call to finish
commit 9f7685f added --wait
Edward Haas has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56871
To unsubscribe, vis
Liron Aravot has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.
Edward Haas has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 1: Verified+1
Passes functional tests on Centos7
--
To view, visit https://gerrit.ov
Shahar Havivi has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56694
To unsubscribe, visit https://gerrit.ovirt.org/settin
Shahar Havivi has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 4:
we need to make sure that Libvirt API this is working on rhel 5.x which
importing Libvirt Xen to vdsm
--
To view
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool/configurator.py
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
(3 comments)
except some minor notes its +1
https://gerrit.ovirt.org/#/c/532
gerrit-hooks has posted comments on this change.
Change subject: net: add Transaction() to netconfpersistence
..
Patch Set 17:
* #1195208::Update tracker: OK
* Set MODIFIED::bug 1195208#1195208IGNORE, not all related pa
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: add Transaction() to netconfpersistence
..
net: add Transaction() to netconfpersistence
This patch introduces Transaction() class/context manager
Dan Kenigsberg has posted comments on this change.
Change subject: net: add Transaction() to netconfpersistence
..
Patch Set 16: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, vis
gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 13:
* #1305529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305529::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56704/2/tests/mountTests.py
File tests/mountTests.py:
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Edward Haas has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56015/2/vdsm_hooks/macspoof/README
File vdsm_hooks
Nir Soffer has restored this change.
Change subject: tests: Test both ssl and m2c
..
Restored
--
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: restor
Nir Soffer has restored this change.
Change subject: hsm: Refine error handling in getDevicesVisibility
..
Restored
--
To view, visit https://gerrit.ovirt.org/39305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerr
Nir Soffer has restored this change.
Change subject: hsm: Pep8ize function name
..
Restored
--
To view, visit https://gerrit.ovirt.org/39306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: restore
Nir Soffer has restored this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Restored
--
To view, visit https://gerrit.ovirt.org/37329
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: Removing generationID from clientIF
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
Nir Soffer has submitted this change and it was merged.
Change subject: Removing generationID from clientIF
..
Removing generationID from clientIF
Originally generationID was added as an element to getVdsStats to
monitor vdsmd
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move the host stats dict creation to host module
..
Move the host stats dict creation to host module
This work is part of reporting the metric of host stats. T
gerrit-hooks has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Shahar Havivi has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/55797/5/configure.ac
File configure.ac:
Line 376: AC_
gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Nir Soffer has submitted this change and it was merged.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
storage: add tests for Mount.isMounted in mount.py
Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f4298
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior introduce
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check Product::#1331978
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified-1
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check Produc
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior introduce
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1:
This is not merge on master yet, but I want to get this tested by the community.
--
To view, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified+1
Tested:
- start vdsm
- stop vdsm
- deactivate storage domain
- activate storage domain
- put host to maintenance
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified+1
Tested:
- start vdsm
- stop vdsm
- deactivate storage domain
- activate storage domain
- put host to maintenance
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check Product::#1331978
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check Product::#1331978
gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG
Commit Message:
PS2, Line 10:
Irit Goihman has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG
Commit Message:
PS2, Line 10: c
Nir Soffer has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56874/2/lib/vdsm/host.py
File lib/vdsm/host.py:
Line 22
gerrit-hooks has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line 10
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move hoststats code to host module
..
Move hoststats code to host module
The code shouldn't be under virt folder and we already have host module
which should g
gerrit-hooks has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56607
To unsubscribe, visit https:/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
net tests: take2: wait for a concurrent iptables call to finish
commit 9f7685f added
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56871
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url foun
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Patch Set 4: Code-Review+1
But I'd prefer that this kind of validation take place much higher up, at the
en
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
(16 comments)
https://gerrit.ovirt.org/#/c/55797/6/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line
Nir Soffer has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 1:
You move here lot of code, but I don't see the deleted code in the original
module
--
To view, visit https://g
Nir Soffer has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 3:
Can you verify? I want to take this first.
--
To view, visit https://gerrit.ovirt.org/56706
To unsub
Nir Soffer has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 4:
Dan, ping
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1:
OK, we will improve this later.
--
To view, visit https://gerrit.ovirt.org/56694
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerri
Nir Soffer has submitted this change and it was merged.
Change subject: v2v: small test improvement
..
v2v: small test improvement
Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f
Signed-off-by: Tomáš Golembiovský
Reviewed
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py
Fil
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
net tests: Clean netinfo_test from uneeded mocks
Removing mockey patches that are no longer needed.
Edward Haas has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56015
To unsubscribe, visit https:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding reportStats
..
Adding reportStats
Adding function that uses statsd to report internal host info. This will
be called after each sampling for now.
Chang
gerrit-hooks has posted comments on this change.
Change subject: Adding reportStats
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and i
gerrit-hooks has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Hello Nir Soffer, Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/56881
to review the following change.
Change subject: Don't prepare image with illegal volumes
..
Don
Ala Hino has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1:
* #1331572::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331572::OK, public bug
* Check P
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 2: Code-Review-1
(8 comments)
boring ordering nits
https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/
Nir Soffer has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit https://gerrit.ovirt.
Edward Haas has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 3: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/56828/3/lib/vdsm/network/configurators/libvir
gerrit-hooks has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8:
* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
*
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: use libvirt flags to select capability
..
hostdev: use libvirt flags to select capability
hostdevListByCaps (or list_by_caps in hostdev module
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use libvirt flags to select capability
..
Patch Set 9:
* #1270581::Update tracker: OK
* Set MODIFIED::bug 1270581#1270581IGNORE, not all related
gerrit-hooks has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 14:
* #1305529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305529::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Idan Shaby has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56706
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Nir Soffer has submitted this change and it was merged.
Change subject: storage: streamline getting domain mountpoint
..
storage: streamline getting domain mountpoint
When checking if a domain's mountpoint is mounted, the code
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review-1
Wait with the merge, we need a different Bug-Url
--
To view, visit https://gerrit.ovirt.org/
Edward Haas has posted comments on this change.
Change subject: net: get network switch type from libvirt
..
Patch Set 1: Code-Review-1
I am not clear why libvirt DB is considered 'actual' or real time info.
To me, it is not be
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init
Idan Shaby has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 10: -Verified
There've been too many rebases since the last time I verified.
Marking as not verified
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__ini
Ala Hino has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Verified-1
-1 for visibility:
The code is perfect but bug Id is incorrect
--
To view, visit https://gerrit.
Edward Haas has posted comments on this change.
Change subject: configure: add support for nosetests/python 3.5
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:
Line 289: fi
L
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: -Code-Review
Please use this bug in the Bug-Url:
https://bugzilla.redhat.com/1332038
--
To view, visit ht
1 - 100 of 166 matches
Mail list logo