Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55987/19/tests/storage_volume_artifacts_test.py
Nir Soffer has posted comments on this change.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56865
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Share failure function
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56863
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix python-blivet dependency issue for python3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ramesh N has uploaded a new change for review.
Change subject: gluster: fix python-blivet dependency issue for python3
..
gluster: fix python-blivet dependency issue for python3
Until now blivet API had both 'python-blivet'
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move netconfpersistence under vdsm.network
..
net: Move netconfpersistence under vdsm.network
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56677
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: allow to run a DHCP server on multiple interfaces
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Share failure function
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Prepare for COW_FORMAT test permutations
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cow wip
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
Adam Litke has uploaded a new change for review.
Change subject: tests: Use MonkeyPatchScope to inject failures
..
tests: Use MonkeyPatchScope to inject failures
The FileVolumeArtifactsTests checked volume creation failures by
gerrit-hooks has posted comments on this change.
Change subject: tests: Use MonkeyPatchScope to inject failures
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Adam Litke has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 18:
(8 comments)
https://gerrit.ovirt.org/#/c/55987/18/tests/storage_volume_artifacts_test.py
File
Nir Soffer has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56912/1//COMMIT_MSG
Commit Message:
Line 3:
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/56876/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 653: for vg in
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File
Edward Haas has posted comments on this change.
Change subject: net: Move netinfo under vdsm.network
..
Patch Set 2:
(1 comment)
I'm planning to move all network related modules and packages under network, I
was not sure if
Edward Haas has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56677
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Move netinfo under vdsm.network
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56713
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Move netinfo under vdsm.network
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 3: Verified+1
Verified by successfully opening a SPICE console with a patched
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 3:
* #1060573::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Adam Litke has posted comments on this change.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
Patch Set 1:
(1 comment)
Certainly a few of these things will crop up along the way. Since we're
Adam Litke has posted comments on this change.
Change subject: tests: Share failure function
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56863/1/tests/storage_volume_artifacts_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56884
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419:
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/56876/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 653: for vg in
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py
File vdsm/API.py:
Line 112: def
gerrit-hooks has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Jenkins CI has posted comments on this change.
Change subject: net: ovs bondings netinfo
..
Patch Set 3: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 2
--
To view, visit
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File tests/bridgeTests.py:
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: ovs bondings netinfo
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: OVS bondings netinfo
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: hostdev: add support for SCSI
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/55024
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: make _update_usb_device_info more generic
..
Patch Set 11: Verified+1
I don't like the code, but makes it easy to remove the workarounds for 4.1.
--
gerrit-hooks has posted comments on this change.
Change subject: hostdev: make _update_usb_device_info more generic
..
Patch Set 11:
* #1270581::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270581::OK, public
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add support for SCSI
..
Patch Set 12:
* #1270581::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270581::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: ovs info
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: ovs netinfo
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: ovs info
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: get_external_vms return format for KVM images
..
v2v: get_external_vms return format for KVM images
Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d
Sahina Bose has posted comments on this change.
Change subject: virt: enable libgfapi
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56907/1//COMMIT_MSG
Commit Message:
Line 10: libgfapi directly.
Line 11: To
Sahina Bose has posted comments on this change.
Change subject: virt: enable libgfapi
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56907/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: With the introduction of
gerrit-hooks has posted comments on this change.
Change subject: net: ovs info
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56836/2//COMMIT_MSG
Commit
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 3:
* #1060573::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: virt: enable libgfapi
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Hello Ala Hino,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/56906
to review the following change.
Change subject: virt: enable libgfapi with snapshot support
..
virt: enable libgfapi with
gerrit-hooks has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Hello Ala Hino,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/56907
to review the following change.
Change subject: virt: enable libgfapi
..
virt: enable libgfapi
With the introduction of
gerrit-hooks has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File tests/bridgeTests.py:
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose generic scsi driver char device in device params
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: hostdev: report storage model as product
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/56123
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: report additional information in 'scsi' device
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56038
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: make _update_usb_device_info more generic
..
Patch Set 10: Verified-1
although works, we need to (unfortunately) split address handling due to
Shahar Havivi has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
(17 comments)
https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Petr Horáček has posted comments on this change.
Change subject: net: don't handle OVS networks in netinfo
..
Patch Set 2: Verified+1
Passed network/*test.py
--
To view, visit https://gerrit.ovirt.org/56838
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: net: don't handle OVS networks in netinfo
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: netinfo/cache.py handles only legacy nets
..
Patch Set 1:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56843
To unsubscribe,
Petr Horáček has abandoned this change.
Change subject: net: netinfo/cache.py handles only legacy nets
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 5:
Build failure not related to this change.
--
To view, visit https://gerrit.ovirt.org/56387
To
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56650
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 3: Verified+1
Verified by running a local build.
--
To view, visit https://gerrit.ovirt.org/56650
To
gerrit-hooks has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56650/1/tests/stompTests.py
File tests/stompTests.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/56574/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 897:
gerrit-hooks has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ovs netinfo
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Petr Horáček has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 4: Verified+1
(3 comments)
Passed conf_test.py.
Petr Horáček has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 5: Verified+1
Passed conf_test.py.
--
To view, visit https://gerrit.ovirt.org/56829
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 22: Verified+1
Rebase + test update due to a change. No other code changes.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 38: Verified+1
Rebase + schema update due to change. No other code changes.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 26: Verified+1
Rebase + test update due to a change. No other code changes.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: events: verify data before sending
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 38:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
1 - 100 of 164 matches
Mail list logo