Nir Soffer has posted comments on this change.
Change subject: v2v: Treat Xen specially after all.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57431/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 993: try:
Nir Soffer has posted comments on this change.
Change subject: v2v: Do not give Xen a special treatment.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57430/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 995:
Jenkins CI has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
Jenkins CI has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 1
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 2:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 6:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: monitor: Convert valid to read-only property
..
monitor: Convert valid to read-only property
Status.valid was a duplicate of Status.error. This could lead
Nir Soffer has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 20:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 37:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 8:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
Nir Soffer has uploaded a new change for review.
Change subject: monitoring: Use new monitoring infrastructure
..
monitoring: Use new monitoring infrastructure
DomainMonitor is keeping now a checker object, providing path
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Treat Xen specially after all.
..
Patch Set 1:
The cause of CI -1 seems unrelated to the change. Yum failed to install stuff
from EPEL.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: v2v: Do not give Xen a special treatment.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Treat Xen specially after all.
..
v2v: Treat Xen specially after all.
The condition in the exception handler may be too general and may hide
some
gerrit-hooks has posted comments on this change.
Change subject: v2v: Treat Xen specially after all.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Do not give Xen a special treatment.
..
v2v: Do not give Xen a special treatment.
Allways perform the check for snapshots and do not give Xen a
Petr Horáček has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 5: Verified+1
(1 comment)
Passed network tests OK.
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57429
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57429
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: monitor: Separate path status and domain status
..
monitor: Separate path status and domain status
Introduce two classes:
PathStatus the status of checking
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: monitor: Simplify Status class
..
monitor: Simplify Status class
Remove the unneeded __slots__ since we do not manage many status
objects.
Remove FrozenStatus as
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 12:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 11:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1: Code-Review+1
Looks good, but get it tested before we merge to 3.6.
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: access network caps via network API
..
Patch Set 2: Verified+1
Passed network tests.
--
To view, visit https://gerrit.ovirt.org/57402
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 10:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: schema: Marked optional fields in ExternalVmInfo.
..
Patch Set 1: Verified+1
There is nothing to verify, is there?
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: migrations: enhance legacy downtime alg
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1:
* #1333627::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1333627::OK,
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize network before broken network removal
..
Patch Set 2: Verified+1
Passed network tests OK.
--
To view, visit https://gerrit.ovirt.org/57349
To
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/57418/1/lib/api/vdsm-api.yml
File
gerrit-hooks has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: migration: dynamic setting of {in,out}bound limits
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: schema: yml: fix virt glitches
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/57419
to review the following change.
Change subject: storage: Do not reference image dir in backing volume path
..
storage: Do
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Lazy loading of external VMs info
..
v2v: Lazy loading of external VMs info
API changes allowing implementation of lazy loading of information about
gerrit-hooks has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
* #1294629::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294629::OK, public bug
* Check
Tomas Golembiovsky has uploaded a new change for review.
Change subject: schema: Marked optional fields in ExternalVmInfo.
..
schema: Marked optional fields in ExternalVmInfo.
Some fields may remain empty in certain cases, but
gerrit-hooks has posted comments on this change.
Change subject: schema: Marked optional fields in ExternalVmInfo.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 9:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 8:
please rebase on top of gerrit to make jenkins happy.
--
To view, visit https://gerrit.ovirt.org/57084
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix scsi udev rule target
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: fake OVS networks as bridgeless
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: access network caps via network API
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: consume OVS netinfo by CachingNetInfo
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize network before broken network removal
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize network before broken network removal
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/57349
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 1:
We've got a bug for this now: https://bugzilla.redhat.com/1335840
--
To view, visit
Petr Horáček has uploaded a new change for review.
Change subject: net: access network caps via network API
..
net: access network caps via network API
With OVS, caps will be mixed from OVS netinfo, legacy netinfo and
nics
gerrit-hooks has posted comments on this change.
Change subject: net: access network caps via network API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: storage: add LegacyCdromPath as DriveSpec
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/57339
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: fake OVS networks as bridgeless
..
Patch Set 6: Verified+1
(3 comments)
Passed ovs_info_test.py
gerrit-hooks has posted comments on this change.
Change subject: net: fake OVS networks as bridgeless
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: consume OVS netinfo by CachingNetInfo
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
David Caro has posted comments on this change.
Change subject: Adapting to latest lago 0.17
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/57376
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: check-merged:Using yaml for the lago initfile
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
David Caro has abandoned this change.
Change subject: bridgeTests:Remove extra param to migrationCreate
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/57388
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: Adapting to latest lago 0.17
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridgeTests:Remove extra param to migrationCreate
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57388
Tomas Jelinek has posted comments on this change.
Change subject: migration: log the convergence schedule only if provided
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57370
To unsubscribe, visit
Tomas Jelinek has posted comments on this change.
Change subject: migrations: enhance legacy downtime alg
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit
Jakub Niedermertl has posted comments on this change.
Change subject: net: Network speed reported as -1 if it can not be determined
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57108
To
Nir Soffer has posted comments on this change.
Change subject: bridgeTests:Remove extra param to migrationCreate
..
Patch Set 2:
Yes, master is ok now, so you should abandon this change.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
Please backport to 3.6
--
To view, visit https://gerrit.ovirt.org/57284
To
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Do not reference image dir in backing volume path
..
storage: Do not reference image dir in backing volume path
Until now, the backing volume
gerrit-hooks has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
* #1333627::Update tracker: OK
* Set MODIFIED::bug 1333627#1333627IGNORE, not
Nir Soffer has posted comments on this change.
Change subject: storage: add LegacyCdromPath as DriveSpec
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57339
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: teardown non-scsi devices
..
Patch Set 6: Code-Review+1
Without understanding all the possible implications, it looks basically fine to
me. (And I
Nir Soffer has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/56826
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/57372
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Use module logger
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Rename storage.monitor test module
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56885
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Use module logger
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename storage.monitor test module
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: add LegacyCdromPath as DriveSpec
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Milan Zamazal has posted comments on this change.
Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: hostdev: fix scsi udev rule target
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:
gerrit-hooks has posted comments on this change.
Change subject: hostdev: fix scsi udev rule target
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
1 - 100 of 107 matches
Mail list logo