gerrit-hooks has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 33:
* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move fuser module to vdsm storage lib
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56620
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Move libvirt module under network
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/57310/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net: Move
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: ad_actor_system may not be reset to its default value
..
Patch Set 1: Code-Review-1
(1 comment)
Edward Haas has posted comments on this change.
Change subject: net: Expose existing ip address info through the api
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/57309/2/lib/vdsm/network/api.py
File
Daniel Erez has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: mount: Remove pointless force=True usage
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: ad_actor_system may not be reset to its default value
..
Patch Set 1: Verified+1
testSetupNetworksActiveSlave now passes on Fedora 23.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: ad_actor_system may not be reset to its default value
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ondřej Svoboda has uploaded a new change for review.
Change subject: ifcfg: ad_actor_system may not be reset to its default value
..
ifcfg: ad_actor_system may not be reset to its default value
_restore_default_bond_options
gerrit-hooks has posted comments on this change.
Change subject: legacy_switch: make _bonds_edit more readable
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove duplicated handling of extraneous slaves
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ondřej Svoboda has posted comments on this change.
Change subject: legacy_switch: quote bonding options and stop repeating "bond
Bond()"
..
Patch Set 1: Verified+1
Strings only.
--
To view, visit
Ondřej Svoboda has posted comments on this change.
Change subject: network: point to vars.hidden_nics when refusing to bond them
..
Patch Set 2: Verified+1
Strings only.
--
To view, visit https://gerrit.ovirt.org/57485
To
Ondřej Svoboda has posted comments on this change.
Change subject: netconfpersistence: clarify logging messages, use explicit terms
..
Patch Set 1: Verified+1
Strings only.
--
To view, visit https://gerrit.ovirt.org/57484
To
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove duplicated handling of extraneous slaves
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove duplicated handling of extraneous slaves
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: explain why we have to reset bonding options to default
..
Patch Set 1: Verified+1
Documentation-only commit.
--
To view, visit
Ondřej Svoboda has uploaded a new change for review.
Change subject: ifcfg: remove duplicated handling of extraneous slaves
..
ifcfg: remove duplicated handling of extraneous slaves
legacy_switch._detach_extraneous_slaves
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove duplicated handling of extraneous slaves
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: network: point to vars.hidden_nics when refusing to bond them
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ondřej Svoboda has uploaded a new change for review.
Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..
legacy_switch: split _detach_extraneous_slaves off _bonds_edit
Change-Id:
Ondřej Svoboda has uploaded a new change for review.
Change subject: legacy_switch: make _bonds_edit more readable; and mark a
possible duplicity in ifcfg
..
legacy_switch: make _bonds_edit more readable; and mark a possible
gerrit-hooks has posted comments on this change.
Change subject: legacy_switch: make _bonds_edit more readable; and mark a
possible duplicity in ifcfg
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check
gerrit-hooks has posted comments on this change.
Change subject: legacy_switch: quote bonding options and stop repeating "bond
Bond()"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Ondřej Svoboda has uploaded a new change for review.
Change subject: legacy_switch: quote bonding options and stop repeating "bond
Bond()"
..
legacy_switch: quote bonding options and stop repeating "bond Bond()"
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: network: point to vars.hidden_nics when refusing to bond them
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ondřej Svoboda has uploaded a new change for review.
Change subject: network: point to vars.hidden_nics when refusing to bond them
..
network: point to vars.hidden_nics when refusing to bond them
Saying that dummy0 is "unknown"
gerrit-hooks has posted comments on this change.
Change subject: netconfpersistence: clarify logging messages, use explicit terms
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ondřej Svoboda has uploaded a new change for review.
Change subject: netconfpersistence: clarify logging messages, use explicit terms
..
netconfpersistence: clarify logging messages, use explicit terms
In supervdsm.log, an
Nir Soffer has uploaded a new change for review.
Change subject: sdm: Remove circular dependency
..
sdm: Remove circular dependency
StorageDomain.get_volume_artifacts() was creating a circular dependency;
BlockSD and fileSD
gerrit-hooks has posted comments on this change.
Change subject: sdm: Remove circular dependency
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: explain why we have to reset bonding options to default
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Petr Horáček has posted comments on this change.
Change subject: net: consume OVS netinfo by CachingNetInfo
..
Patch Set 6:
Does it make more sense with https://gerrit.ovirt.org/#/c/57441/5 ?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Separate broken test from good tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Temporary hack around circular import
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Separate broken test from good tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: storage: Temporary hack around circular import
..
storage: Temporary hack around circular import
Since the introducation of BlockVolumeArtifacts, it is not
Nir Soffer has uploaded a new change for review.
Change subject: tests: Separate broken test from good tests
..
tests: Separate broken test from good tests
In commit 29fa0abb687d (storagetests: add a test for
Nir Soffer has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 3: Continuous-Integration+1
CI failure not related.
--
To view, visit https://gerrit.ovirt.org/57428
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: directio: Port to Python 3
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: directio: Keep line terminators in readlines()
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/54701
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: directio: Require full blocks
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/54715
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: directio: Introduce vdsm.storage.directio module
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Modernize test names
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: directio: Keep line terminators in readlines()
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Replace magic number with constant
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: directio: Add test for reading entire file
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: directio: Add failing test for DirectFile.readlines()
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: directio: Port to Python 3
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: directio: Require full blocks
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: tests: Simplify DirectFile tests
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54678
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.outOfProcess
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.threadPool
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: directio: Require full blocks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: directio: Introduce vdsm.storage.directio module
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: directio: Add failing test for DirectFile.readlines()
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Modernize test names
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: directio: Keep line terminators in readlines()
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: directio: Port to Python 3
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: directio: Remove useless DirectFile.writelines()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: directio: Add test for reading entire file
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Replace magic number with constant
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: changed Makefile so that both python2 and pyhton3 will
be default. That way, all tests (including new ones) will have to support
python3 eventually.
..
Yaniv Bronhaim has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 16: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 16:
ci -1 is not related.
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42471/11/vdsm.spec.in
File vdsm.spec.in:
Line 140:
Yaniv Bronhaim has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 30:
(2 comments)
https://gerrit.ovirt.org/#/c/53919/30/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 36:
gerrit-hooks has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/54528/25/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 130:
Nir Soffer has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/57471
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sd: Introduce StorageDomainChecker
..
Patch Set 2:
Replaced by monitoring topic.
--
To view, visit https://gerrit.ovirt.org/54375
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 5:
ping
--
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Refresh domains only if needed
..
Patch Set 2:
* #1081962::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/53395
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: monitor: Refresh domains only if needed
..
Abandoned
We must keep refresh now, lot of stuff will break if we stop refreshing.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/53540
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.outOfProcess
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.threadPool
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Simplify DirectFile tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Remove open_ex
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: directio: Add failing test for DirectFile.readlines()
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Modernize test names
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Remove the redundant "d" mode
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Replace magic number with constant
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 284 matches
Mail list logo