Nir Soffer has posted comments on this change.
Change subject: virt: Improve thread safety of discarding executor workers
..
Patch Set 9:
Francesco?
--
To view, visit https://gerrit.ovirt.org/58146
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 8:
(4 comments)
https://gerrit.ovirt.org/#/c/59304/8//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 21:
(6 comments)
https://gerrit.ovirt.org/#/c/58728/21//COMMIT_MSG
Commit Message:
Line 26: - /usr/lib/vdsm/vdsm.conf.d/
Nir Soffer has posted comments on this change.
Change subject: vdsm: Conditional hard dependency on gluster rpms
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/58605/2/vdsm.spec.in
File vdsm.spec.in:
Line 711:
Nir Soffer has posted comments on this change.
Change subject: py3 tests: ported vdsClientTests.py to python3
..
Patch Set 1:
(2 comments)
Thanks for separating this and having a small and easy to review patch.
Nir Soffer has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58964
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59696
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Send host reports each sampling interval from HostMonitor
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
gerrit-hooks has posted comments on this change.
Change subject: Adding report_stats to health reports
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: Send host reports each sampling interval from HostMonitor
..
Send host reports each sampling interval from HostMonitor
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Adding report_stats to host.api
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: Adding report_stats to host.api
..
Adding report_stats to host.api
Adding functions that use reports.send function to report internal host info
Nir Soffer has submitted this change and it was merged.
Change subject: Adding report_stats to health reports
..
Adding report_stats to health reports
Adding function that use reports.send function to report internal vdsm
Nir Soffer has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55949/7//COMMIT_MSG
Commit Message:
Line 19:
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27:
Milan, can you rebase?
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Nir Soffer has submitted this change and it was merged.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
With Tox we dont need to have local installation of pep8 and pyflakes
Tox
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Report qcow2 compat version
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59408/4/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line 98:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Fix tests with non-default qcow2_compat
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Fix tests with non-default qcow2_compat
..
qemuimg: Fix tests with non-default qcow2_compat
In commit 808ccde4de35 (qemuimg: Make QCOW2_COMPAT
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Fix tests with non-default qcow2_compat
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57457
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Report qcow2 compat version
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59408/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 94:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sdm: Support snapshot creation
..
Patch Set 10:
(5 comments)
https://gerrit.ovirt.org/#/c/57057/10/vdsm/storage/sdm/volume_artifacts.py
File
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/59649/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Nir Soffer has posted comments on this change.
Change subject: Refactor verify_untrusted_volume
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59409/1/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Report qcow2 compat version
..
Patch Set 4:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: Refactor verify_untrusted_volume
..
Patch Set 4:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 5:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 5:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public
Adam Litke has posted comments on this change.
Change subject: Refactor verify_untrusted_volume
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59409/1/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: snapshot fixes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/59761
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: snapshot fixes
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59761
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
gerrit-hooks has posted comments on this change.
Change subject: snapshot fixes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: gc wip
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: sdm: Support snapshot creation
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: template wip
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: template wip
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: gc wip
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: sdm: Support snapshot creation
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: snapshot fixes
..
snapshot fixes
Change-Id: I00b170f993cf98506f540fc188ae1e41e337a078
Signed-off-by: Adam Litke
---
M
Adam Litke has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58879
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/59306/10/Makefile.am
File
gerrit-hooks has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Yaniv Bronhaim has posted comments on this change.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59723
To
Yaniv Bronhaim has posted comments on this change.
Change subject: infra: moved infra package contents from lib/vdsm to
lib/vdsm/common
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/59304/7//COMMIT_MSG
Commit
Adam Litke has posted comments on this change.
Change subject: sdm: Support snapshot creation
..
Patch Set 10:
(12 comments)
https://gerrit.ovirt.org/#/c/57057/10/tests/storage_volume_artifacts_test.py
File
Nir Soffer has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1:
According to David, this is el6 only issue, so this patch is needed only for
3.5, the last version supporting el6.
--
Nir Soffer has abandoned this change.
Change subject: spec: Require sanlock 2.8-3
..
Abandoned
This patch is not needed, this issue never existed on rhel 7. The fix is needed
only for el6, so it is 3.5 only fix.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1:
* #1349068::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/59655
To unsubscribe, visit
Tomas Golembiovsky has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: core: Unlink volume run path when deleting a snapshot
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/59725/3/vdsm/storage/blockVolume.py
Piotr Kliczewski has posted comments on this change.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59723
To
Piotr Kliczewski has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38426
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38425
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Send host reports each sampling interval from HostMonitor
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59067
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: infra: moved infra package contents from lib/vdsm to
lib/vdsm/common
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59304
To
Michal Skrivanek has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 9:
this just underlines the discussion on host upgrade. we can't really continue
this way and create bugs
gerrit-hooks has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 9:
* #1349864::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1349864::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/58964/8//COMMIT_MSG
Commit Message:
Line 12: This patch
Nir Soffer has posted comments on this change.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59723
To
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2:
Verified by couple hundred migrations in few hours on Sefi's setup with
4.18.4-2 plus this patch
Martin Polednik has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/6/vdsm/virt/vmdevices/hostdevice.py
File
Francesco Romani has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 5: Code-Review-1
(4 comments)
-1 because of questions inside
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent running periodic operations on stuck VMs
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 6: Code-Review-1
(1 comment)
I'd like to try NOT to have this facade class.
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent running stuck periodic operations
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent running stuck VM operations
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: doc: Typo fixes and other doc improvements in periodic.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has posted comments on this change.
Change subject: net: disable unused IPv6 in ip.address.add()
..
Patch Set 6: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/59002/6/lib/vdsm/network/ip/address.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: doc: Typo fixes and other doc improvements in periodic.py
..
doc: Typo fixes and other doc improvements in periodic.py
This is a documentation only change to
Francesco Romani has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 21: Verified+1
re-verified as before
--
To view, visit https://gerrit.ovirt.org/38426
To
Francesco Romani has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 19: Verified+1
v19 fixes comments from Dan and extracts the mapping between names and levels
into
gerrit-hooks has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net func test: add basic bond tests
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59567
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: netswitch: split setup actions on netswitch level
..
Patch Set 17:
https://gerrit.ovirt.org/#/c/58502/10/tests/network/netswitch_test.py@36
Martin Peřina has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 8: Verified+1
updated centos 7.2 box: we now have the required libvirt package.
Succesfully installed patched
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2: Verified+1
seems to work. let's verify a bit more thoroughly
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2: Verified+1
Verified on Isreal's environment with 4 migrations.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2:
* #1349461::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1349461::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 11: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/59306/11/Makefile.am
Yaniv Bronhaim has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/59306/10/Makefile.am
File
gerrit-hooks has posted comments on this change.
Change subject: core: Unlink volume run path when deleting a snapshot
..
Patch Set 3:
* #1321018::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321018::OK, public
gerrit-hooks has posted comments on this change.
Change subject: core: Unlink volume run path when deleting a snapshot
..
Patch Set 2:
* #1321018::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321018::OK, public
Ala Hino has posted comments on this change.
Change subject: core: Unlink volume run path when deleting a snapshot
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/59725/1/vdsm/storage/blockVolume.py
File
93 matches
Mail list logo