Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60420/3/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60420/3/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 3:
(14 comments)
Nice!
https://gerrit.ovirt.org/#/c/60420/3/vdsm/storage/sdm/api/copy_data.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/60615/1/tests/storagetestlib.py
File
Nir Soffer has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3: Code-Review+1
Waiting for Liron and Fredd ack.
--
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 3:
We have faling test:
20:56:03 ==
20:56:03
Nir Soffer has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60417/3/tests/storagetestlib.py
File tests/storagetestlib.py:
Line 52:
Nir Soffer has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/60416
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
tests: Add tmpdir and sdcache to FakeEnv
Some tests may need to perform additional MonkeyPatching using the
Nir Soffer has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60416
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: add helper to read test data
..
tests: add helper to read test data
Many tests need to read external data,
like VM configuration, or API dumps,
gerrit-hooks has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: tests: Introduce qemu-io pattern verification utils
..
tests: Introduce qemu-io pattern verification utils
qemu-io is a utility that is useful for testing all
Adam Litke has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60417/1/tests/storagetestlib.py
File tests/storagetestlib.py:
Line 43:
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/60420/1/tests/storage_sdm_copy_data_test.py
File
Adam Litke has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/60416/1/tests/storagetestlib.py
File tests/storagetestlib.py:
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 1:
(23 comments)
https://gerrit.ovirt.org/#/c/60420/1/tests/storage_sdm_copy_data_test.py
File
Irit Goihman has posted comments on this change.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: sos report: removed call to vdsClient getVGList
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60613
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 8:
/usr/lib/python2.7/site-packages/vdsm/tool/dump_volume_chains.py:28:
DeprecationWarning: vdscli uses
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sos report: removed call to vdsClient getVGList
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sos report: removed call to vdsClient getVGList
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Irit Goihman has uploaded a new change for review.
Change subject: sos report: removed call to vdsClient getVGList
..
sos report: removed call to vdsClient getVGList
getVGList has been deprecated and will be fully removed in
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60607
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 3: Verified+1
Verified (by jenkins) in https://gerrit.ovirt.org/#/c/60382/2
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 9: Verified+1
verified that the newly extracted method is still called.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 7:
need to check if MOM likes this.
--
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 7: Verified+1
looks like this (virsh dumpxml)
a01
ad9456a5-5740-4c18-82b0-d52826e2521c
Francesco Romani has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 7:
the "metadata" section is still created, hence V+1
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: is_kvm from custom containerType
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/54872
To
Francesco Romani has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 7: -Code-Review
commit message is now up to date
--
To view, visit https://gerrit.ovirt.org/57381
To
Francesco Romani has abandoned this change.
Change subject: virt: utils: is_kvm from custom containerType
..
Abandoned
no longer needed
--
To view, visit https://gerrit.ovirt.org/54872
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 3: Verified+1
succesfully booted a VM using Vdsm with this patch applied and Engine 3.6.z
--
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 3: Verified+1
Engine (3.6.z) still allow connections using SPICE, hence V+1
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 3:
example list output:
ad9456a5-5740-4c18-82b0-d52826e2521c
Status = Up
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 3:
example getAllVmStatus output:
ad9456a5-5740-4c18-82b0-d52826e2521c
Status = Up
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 1:
Yaniv is moving vmstatus in the common part here:
https://gerrit.ovirt.org/#/c/57820/
I still
Francesco Romani has uploaded a new change for review.
Change subject: vm: api: move vm status check into migrate()
..
vm: api: move vm status check into migrate()
The API layer is guarding against incorrect calls of
the
gerrit-hooks has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Adam Litke has submitted this change and it was merged.
Change subject: sdc: Safer way to access storage domain manifest
..
sdc: Safer way to access storage domain manifest
New spm-less code must never access StorageDomain, as
Adam Litke has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/58879
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(5 comments)
Looking great. See comments within.
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
jsonrpcvdscli: added getAllTasksInfo verb
getAllTasksInfo verb is needed by sos report
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 5: Code-Review+2
Cannot be simpler :-)
--
To view, visit https://gerrit.ovirt.org/60272
To
Irit Goihman has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59677
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: draft: add logstash handler
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/60573/1/lib/vdsm/reports/__init__.py
File lib/vdsm/reports/__init__.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Irit Goihman has uploaded a new change for review.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
[wip] sos report: replace vdscli with jsonrpcvdscli
Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use proper scsi address
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: cleanup udev files after PCI host devices
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: properly detect attached scsi devices
..
hostdev: properly detect attached scsi devices
SCSI device is addressed by two fields: adapter, meaning the
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly detect attached scsi devices
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: use proper scsi address
..
hostdev: use proper scsi address
SCSI device requires different address than what we call host address,
as host address
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59677
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
ok with the concept, will have a proper review later
--
To view, visit https://gerrit.ovirt.org/60450
To
Martin Polednik has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/58011/7/lib/vdsm/hostdev.py
File
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 33:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Sivák has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit
Martin Sivák has uploaded a new change for review.
Change subject: Fix return value names for VM.ioTune calls
..
Fix return value names for VM.ioTune calls
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: vmxml: metadata could be local variable
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: metadata could be local variable
..
vmxml: metadata could be local variable
There is no need for `metadata' to be an instance variable,
so this
gerrit-hooks has posted comments on this change.
Change subject: vm: drop legacy device config support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy graphics config support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 159 matches
Mail list logo