gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 2:
* #1365051::Update tracker: OK
* Set MODIFIED::bug 1365051#1365051IGNOR
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63678
To unsubscr
Francesco Romani has submitted this change and it was merged.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
kvm2ovirt: Fixes issue in importing VMs with libvirt uri qemu+tcp
Current imple
Edward Haas has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe, visit https://gerrit.ovirt.org/set
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Petr Horáček has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 1: Verified+1
Test was fixed and now it passes OK.
--
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe
Petr Horáček has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 1: Verified+1
Exceptions from marked tests were skipped on CI and raised outside Jenkins.
--
To view, vi
Petr Horáček has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 4: Code-Review+1
Great!
--
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
gerrit-hooks has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
gerrit-hooks has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Allon Mureinik has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63547/7//COMMIT_MSG
Commit Message:
PS7, Line 7:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 1: Verified+1
make rpm works in branch master, clicking verified.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
cleanup: remove persist/unpersist calls for legacy node
This patch removes all related t
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: spec: Require sanlock version handling EINTR
..
Patch Set 11:
Still not available:
00:22:49 Error: Package: vdsm-4.18.999-532.git681d5f3.el7.centos.x86_64
(/vdsm-
Nir Soffer has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 2:
Dan, can you check this from the networking side?
--
To view, visit https://gerrit.ovirt.org/55
Nir Soffer has posted comments on this change.
Change subject: v2v: Do not give Xen a special treatment.
..
Patch Set 1:
Lets make a decision about these patches.
--
To view, visit https://gerrit.ovirt.org/57430
To unsubscrib
Nir Soffer has posted comments on this change.
Change subject: spec: Require sanlock version handling EINTR
..
Patch Set 11:
Package should be available today, retrying...
--
To view, visit https://gerrit.ovirt.org/61200
To u
gerrit-hooks has posted comments on this change.
Change subject: spec: Require sanlock version handling EINTR
..
Patch Set 11:
* #1356676::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356676::OK, public bug
* Ch
Nir Soffer has posted comments on this change.
Change subject: vdsm: add eventfd and EventFile synchronization
..
Patch Set 1:
Similar and simpler module was merged ages ago.
--
To view, visit https://gerrit.ovirt.org/33687
T
Nir Soffer has abandoned this change.
Change subject: vdsm: add eventfd and EventFile synchronization
..
Abandoned
Not needed now.
--
To view, visit https://gerrit.ovirt.org/33687
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: vdsm: add eventfd and EventFile synchronization
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/33687
To u
Nir Soffer has uploaded a new change for review.
Change subject: vdsm: add eventfd and EventFile synchronization
..
vdsm: add eventfd and EventFile synchronization
Change-Id: I0d237f13c42b1f4505c90d30c6d3c3ecbd1e9fa7
Signed-off-
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3:
(6 comments)
Unfortunately, this change the behavior in incompatible way. I did not check
the schem
Nir Soffer has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3:
Irit, the previous patch created a conflict in the schema - the schema promise
list of vms, and the
Nir Soffer has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settin
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/62002/6/tests/jobsTests.py
File tests/jobsTests.py:
Line 290:
Nir Soffer has posted comments on this change.
Change subject: jobs: Preserve aborted status after run finishes
..
Patch Set 1: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/63713/1/lib/vdsm/jobs.py
File lib/vdsm/job
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/jobs.py
File lib/vdsm/job
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 154
Line 155
gerrit-hooks has posted comments on this change.
Change subject: properties: properties_test.py py2/3 compliance
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Adam Litke has uploaded a new change for review.
Change subject: jobs: Preserve aborted status after run finishes
..
jobs: Preserve aborted status after run finishes
Job.run was unconditionally setting Job.status to done wheneve
gerrit-hooks has posted comments on this change.
Change subject: jobs: Preserve aborted status after run finishes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has uploaded a new change for review.
Change subject: jobs: Guard against racy state changes
..
jobs: Guard against racy state changes
When performing test and set operations with the job status we must use
a lock to
Adam Litke has uploaded a new change for review.
Change subject: jobs: Allow run and abort only from valid states
..
jobs: Allow run and abort only from valid states
Before this patch we allow abort and run from any state even w
Jenkins CI has posted comments on this change.
Change subject: properties: properties.py py2/3 metaclass compliance
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from pat
gerrit-hooks has posted comments on this change.
Change subject: properties: properties.py py2/3 string type check compliance
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: properties: properties.py py2/3 metaclass compliance
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: properties: properties.py py2/3 metaclass compliance
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: properties: properties.py py2/3 string type check compliance.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3:
> This looks correct, if https://gerrit.ovirt.org/63408 was correcdt,
> but
> I think it was wron
Nir Soffer has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit https://gerrit.ovirt.org/settin
Nir Soffer has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63230/3/tests/properties_test.py
File tes
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
You can remove the module from the blacklist in the last patch, or just send
anoth
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/63230/3/lib/vdsm/properties.py
File lib/
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
Looking in the failures when running this under python 3, we have 3 issues:
1. dec
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: use None if no password is given
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63679
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63678
To unsubscribe, v
Nir Soffer has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2:
I'll verify this patch tomorrow.
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 2:
* #1374328::Update tracker: OK
* Set MODIFIED::bug 1374328#1374328IGNORE, not all related patches are
clo
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1: Code-Review+2 Verified+1
test passes
--
To view, visit https://gerrit.ovirt.org/63539
To unsubscribe, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: fix test_events_keys
..
net tests: fix test_events_keys
On Jenkins CI Fedora 23 this test sometimes fails because of missing
del_neigh event
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Don't use fixed path to systemd directory
..
build: Don't use fixed path to systemd directory
Since commit 9d6f46d9 the project can no longer be
gerrit-hooks has posted comments on this change.
Change subject: build: Don't use fixed path to systemd directory
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2: Code-Review+2
Oops, I've merged the follow-up readme before taking this one. I hope it is
verified soon.
--
Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:
Line 10: is no real reason to i
Edward Haas has posted comments on this change.
Change subject: net tests: raise specific MonitorError on IPv6 timeout
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63486/3/tests/network/netinfo_test.p
Edward Haas has posted comments on this change.
Change subject: net tests: replace wait_for_ipv6 with waitfor.waitfor_ipv6_addr
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/63665/1/tests/network/neti
Nir Soffer has posted comments on this change.
Change subject: api: use the new devel_warn helper
..
Patch Set 2:
Is this needed now?
--
To view, visit https://gerrit.ovirt.org/62210
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 3: Code-Review+2
CI failure not relevant.
--
To view, visit https://gerrit.ovirt.org/62212
To unsubscrib
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/62209/3//COMMIT_MSG
Commit Message:
Line 10: module doesn't really
Edward Haas has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 4: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/63660/2/lib/vdsm/network/netlink/wa
gerrit-hooks has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Nir Soffer has posted comments on this change.
Change subject: storage: outOfProcess: remove useless warning
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63702
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62208
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..
jobs: Move run from sdm.base.Job to jobs.Job
The run implementation in sdm.base.Job is generally useful. I
gerrit-hooks has posted comments on this change.
Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sdm: Drop support for thread-local job_id
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sdm: Drop support for thread-local job_id
..
sdm: Drop support for thread-local job_id
sdm.api.base.Job currently has support for setting the job_id in the
Nir Soffer has submitted this change and it was merged.
Change subject: vdsm: Pass scheduler to jobs.start
..
vdsm: Pass scheduler to jobs.start
In a subsequent patch the jobs module will want to defer calls to delete
by using
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Pass scheduler to jobs.start
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Fix stopping order
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.o
Nir Soffer has submitted this change and it was merged.
Change subject: vdsm: Fix stopping order
..
vdsm: Fix stopping order
The jobs module uses the scheduler so it should be stopped before the
scheduler.
Change-Id: Ieef1797a
Nir Soffer has posted comments on this change.
Change subject: vdsm: Pass scheduler to jobs.start
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/setti
Nir Soffer has posted comments on this change.
Change subject: vdsm: Fix stopping order
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63662
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
gerrit-hooks has posted comments on this change.
Change subject: lib: vdscli: switch to the new devel_warn helper
..
Patch Set 2:
* #1369822::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/62211
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: storage: outOfProcess: remove useless warning
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has abandoned this change.
Change subject: lib: vdscli: switch to the new devel_warn helper
..
Abandoned
squashed in https://gerrit.ovirt.org/#/c/62209/
--
To view, visit https://gerrit.ovirt.org/62211
To uns
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 3:
* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 3:
* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Prod
gerrit-hooks has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 3:
* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check
1 - 100 of 214 matches
Mail list logo
