Francesco Romani has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py
File vdsm/API.py:
Line 37: from vdsm import supervds
Yaniv Kaul has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuim
gerrit-hooks has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Jenkins CI has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited fro
gerrit-hooks has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Maor Lipchuk has uploaded a new change for review.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
[QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
Add kwargs of storage domain metadata to i
Nir Soffer has posted comments on this change.
Change subject: config: Rename irs:scsi_settle_timeout option
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/64064
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit https://gerrit.ovirt.org/sett
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: -Continuous-Integration
Jenkins happy now
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, v
Jenkins CI has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 7
--
To vi
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 7:
Francesco, can you update the commit message?
See comments in https://gerrit.ovirt.org/#/c/62212/4//COM
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Code-Review+2 Continuous-Integration+1
ci failure seems irellevent.
--
To view, visit https://gerrit.ovirt.o
Edward Haas has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 8: Code-Review-1
(3 comments)
Small things...
I like the tests, very nice!
https://
Nir Soffer has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerr
Edward Haas has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG
Commit Message:
PS3, Line
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Edward Haas has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/63119/30/lib/vdsm/network/netswitch.py
File lib/vdsm/network/nets
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(2 comments)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virt
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(7 comments)
Thank you all for the comments and suggestions, I hope things get clarified and
we can
Francesco Romani has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/61474/12/lib/vdsm/common/api.py
File lib/vdsm/common/a
Francesco Romani has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py
File lib/vdsm/
Francesco Romani has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 13: Verified+1
schemaValidation passes with this patch.
--
To view, visit https://gerrit.ovirt.org
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1:
cstratak reached me in irc as python maintainer and asked to remove this
requirement from our spec now when
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove python-argparse requirement
..
Remove python-argparse requirement
This package has been obsoleted in Fedora because it got in to stdlib.
Change-Id: I4b
gerrit-hooks has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63686
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovi
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovir
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 8: Verified+1
Passed network/*_test.py and functional/networkTests.py OK.
Without i
gerrit-hooks has posted comments on this change.
Change subject: virt: Inform Engine about switching to post-copy
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Add info about post-copy to UP event after migration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: virt: Report paused VM status in post-copy
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: virt: Distinguish between migration completion kinds
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: virt: Report downtime after a post-copy migration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
gerrit-hooks has posted comments on this change.
Change subject: virt: Stop guest agent before switching to post-copy
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Use a variable for self._vm in MonitorThread action
handling
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url f
gerrit-hooks has posted comments on this change.
Change subject: virt: Destroy VM after failed post-copy migration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 19: Verified+1
--
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/
Petr Horáček has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://ge
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG
Commit Mess
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 8:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::
Simone Tiraboschi has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+1
+1 for me, I agree to take the python way for it.
--
To view, visit https://
Martin Sivák has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Li
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 7:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63119/30/lib/vdsm/network/netswitch.py
File lib/vd
Nir Soffer has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt.org/s
Freddy Rolland has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/se
Edward Haas has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:
PS1, Line 14: bon
Petr Horáček has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG
Commit Message:
PS
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.or
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 6: Verified+1
The added test fails without ifcfg changes, passes with them.
--
To
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 6:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Edward Haas has uploaded a new change for review.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
net: Relocate sysfs_bond_permission to nettestlib
CI does not always allow access to sysfs and will fail the
Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3:
Please send another patch documenting why we are not using logrotate in the
standard way, with url to the rele
gerrit-hooks has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Wait for systemd temporary mount unit
..
mount: Wait for systemd temporary mount unit
Systemd is monitoring mountpoints created during runtime b
Tomas Golembiovsky has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
Yaniv, you are trying to force your warnings on other developers.
We are trying to help developers
gerrit-hooks has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Jenkins CI has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To vi
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: alignmentScan:
Tomas Golembiovsky has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
(1 comment)
Just a typo in commit message. Other than that LGTM.
https://gerrit.ovirt.org/#/c/64123/
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Tal Nisan has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 18:
code coverage is pretty good:
00:08:20.964
/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 18: Verified+1
this patch adds only tests, so as long as juenkins is happy, so we are.
--
To view, visit https
Tomas Golembiovsky has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3: Code-Review-1
Thanks Dan. Somehow I have missed this change when browsing through related
history.
If
Francesco Romani has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 3:
Junkins failure is unrelated:
DEBUG package_manager.py:96: ['/usr/bin/yum-deprecated', '--installroot
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33: Verified+1
trivial patch, covered by tests.
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.p
Nir Soffer has uploaded a new change for review.
Change subject: alignmentScan: Use proper environment
..
alignmentScan: Use proper environment
In commit f9d12864a404 (v2v: Running virt-v2v with some sane
environment) we leaned
gerrit-hooks has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Verified+1
verified running patched Vdsm, and using the tests.
--
To view, visit https://gerrit.ovirt.org/564
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
1 - 100 of 180 matches
Mail list logo