gerrit-hooks has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
qemuimg: Add qcow_compat optional parameter.
Add qcow2_compat parameter that indicates the apropriate qemu
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 28:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add gen_uuid test helper
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64542/1/tests/testlib.py
File tests/testlib.py:
Line 592:
Nir Soffer has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64488/2/vdsm/storage/sdm/api/copy_data.py
Nir Soffer has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 2:
(2 comments)
Test is probably failing because of using generation_id instead of generation
Nir Soffer has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 2: Code-Review-1
(3 comments)
Nir Soffer has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 2: Code-Review-1
(2 comments)
Nir Soffer has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/64484/2//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(2 comments)
I think this patch is too big, lets change first the easy places where
replacing the duplicate code with
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 6:
(2 comments)
Did you verify the current code with both top layer merge and internal layer
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 6: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 2: Verified-1
Still investigating a test failure.
--
To view, visit https://gerrit.ovirt.org/64488
gerrit-hooks has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: tests: Add gen_uuid test helper
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: tests: Add gen_uuid test helper
..
tests: Add gen_uuid test helper
The test code is sprinkled with lots of boilerplate code to generate
UUIDs in the proper
Adam Litke has uploaded a new change for review.
Change subject: storage: GenerationMismatch exception
..
storage: GenerationMismatch exception
Introduce a new exception with a public error code for generation
mismatch errors.
Arik Hadas has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 263: """
Line 264:
Nir Soffer has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
File
Nir Soffer has submitted this change and it was merged.
Change subject: sd: Select qcow2_compat by storage domain version
..
sd: Select qcow2_compat by storage domain version
Add a method that will return the qcow
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 19:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 27:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 27: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 26: Verified+1
Tests pass, looks verified to me.
--
To view, visit https://gerrit.ovirt.org/64169
To
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 26:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/25/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64486/1/tests/storage_volume_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation id to VolumeMetadata
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/1/tests/storage_volume_metadata_test.py
Maor Lipchuk has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/64487/1/vdsm/storage/volume.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 1:
(11 comments)
https://gerrit.ovirt.org/#/c/64486/1/lib/vdsm/storage/exception.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation id to VolumeMetadata
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/volumemetadata.py
File
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 18:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 25:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 25: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 18:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 24:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18: Code-Review-1
(6 comments)
Nice change, but we should be careful and double check. I'm afraid there are
some
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 3:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64479/1/tests/storage_sdm_copy_data_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Fix calling convention.
..
qemuimg: Fix calling convention.
Use kwarg calling stype for qemuimg API calls.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/23/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 2: Continuous-Integration+1
Network tests again
--
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 263: """
Line 264:
Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 4:
(6 comments)
https://gerrit.ovirt.org/#/c/64433/4/vdsm/storage/lvm.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Adam Litke has posted comments on this change.
Change subject: storage: Add support for generation id to VolumeMetadata
..
Patch Set 1:
(10 comments)
https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/constants.py
File
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 17:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.reduce_domain_device
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.reduce_domain_device API
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.move_domain_device API
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: -Code-Review
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: storage: fileUtils: drop redundant warning
..
storage: fileUtils: drop redundant warning
The usage of warnings.warn in the fileUtils
looks
Francesco Romani has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 3: Verified+1
verified the same way as master, with and without logging enabled
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 3: Verified+1
tests runs ok, so does Vdsm.
--
To view, visit https://gerrit.ovirt.org/64517
To
Francesco Romani has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 1: Verified+1
verified on-branch the same way as master; it is a trivial removal, I did some
basic
1 - 100 of 263 matches
Mail list logo