Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4: -Code-Review
--
To view, visit https://gerrit.ovirt.org/43724
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43724
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46625
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe, visit https://gerrit.ovirt.org
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43393
To unsubscribe, visit https://gerrit.ovirt.org
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/44494/16/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 164
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43745
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: reducing log footprint from stomp lib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/46931/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4:
:) I have a conflict two users. fixing it
--
To view, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: test: getInstance is not used so removing
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46941
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46911
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/10/vdsm/rpc/bindingjsonrpc.py
File vdsm/rpc
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: more meaningful name of address param
..
Patch Set 1: Code-Review+1
please try to use meaningful variable names always.. it helps a lot to read
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: change default protocol
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43457/2//COMMIT_MSG
Commit Message:
Line 11: see issues
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43724
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43746/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When we
Yaniv Bronhaim has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2//COMMIT_MSG
Commit Message:
Line 9: It seems
Yaniv Bronhaim has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/45963
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: safelease: Fix wrong parameter name
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45960/2/vdsm/storage/protect/spmstop.sh
File vdsm
Yaniv Bronhaim has posted comments on this change.
Change subject: safelease: Improve logging when releasing lock
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45961
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: safelease: Make it easier to debug spmstop.sh
..
Patch Set 2: Code-Review+1
the commit msg should be "remove redundant debug code" imo
--
To v
Yaniv Bronhaim has posted comments on this change.
Change subject: join supervdsm subprocess after terminated to avoid defunct
status
..
Patch Set 1:
Where is the patch with the zombieReaper? Can you add a link
25 matches
Mail list logo