Royce Lv has abandoned this change.
Change subject: persist state in _changeBlockDev
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/8617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: aband
Royce Lv has abandoned this change.
Change subject: refactor libvirt event loop start
..
Patch Set 5: Abandoned
--
To view, visit http://gerrit.ovirt.org/12306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Royce Lv has abandoned this change.
Change subject: Add basic ballooning policy to vdsm
..
Patch Set 7: Abandoned
--
To view, visit http://gerrit.ovirt.org/11244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Royce Lv has abandoned this change.
Change subject: change vdsm to use multipolicy mom
..
Patch Set 7: Abandoned
--
To view, visit http://gerrit.ovirt.org/11243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Royce Lv has posted comments on this change.
Change subject: Change mom policy related interface to support multi-policy
..
Patch Set 7:
Thanks, Doron! Currently this patch series are waiting for some patch of MOM to
be merged
Royce Lv has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 1:
Hi, Doron,
1. we could use same vmId every tests, but I guess if under some corner case
the vm started o
Royce Lv has posted comments on this change.
Change subject: Change mom policy related interface to support multi-policy
..
Patch Set 6: (1 inline comment)
File tests/functio
Royce Lv has posted comments on this change.
Change subject: trival change for skip mom test logic
..
Patch Set 2: (3 inline comments)
File tests/functional/momTests.py
Line
Royce Lv has uploaded a new change for review.
Change subject: add rollback to _runVMKernelBootTemplate
..
add rollback to _runVMKernelBootTemplate
This will enable us checking status of VM after it starts up.
Change-Id: I497d3
Royce Lv has uploaded a new change for review.
Change subject: [WIP]add simple balloon functional testcase
..
[WIP]add simple balloon functional testcase
Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Signed-off-by: Royce
Royce Lv has uploaded a new change for review.
Change subject: trival change for skip mom test logic
..
trival change for skip mom test logic
using wrapper of runtime vdsm caps to judge mom module existence
instead of trying
Royce Lv has uploaded a new change for review.
Change subject: Change mom policy related interface to support multi-policy
..
Change mom policy related interface to support multi-policy
Change-Id: I09c40fee74b10d3eb41f4ec3ca1809
Royce Lv has posted comments on this change.
Change subject: Using CrabRPC to communicate between vdsm and super vdsm
..
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
.
Royce Lv has posted comments on this change.
Change subject: refactor libvirt event loop start
..
Patch Set 5: (1 inline comment)
File vdsm/libvirtconnection.py
Line 167
Line
Royce Lv has posted comments on this change.
Change subject: Using CrabRPC to communicate between vdsm and super vdsm
..
Patch Set 2: (2 inline comments)
File vdsm/vdsm
Line
Royce Lv has uploaded a new change for review.
Change subject: refactor libvirt event loop start
..
refactor libvirt event loop start
libvirt event loop started during module loading process tends to
be error prone:
1.reload
Royce Lv has posted comments on this change.
Change subject: Using CrabRPC to communicate between vdsm and super vdsm
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/11910
To
Royce Lv has posted comments on this change.
Change subject: Using CrabRPC to communicate between vdsm and super vdsm
..
Patch Set 2: (6 inline comments)
Haven't checked the corner cases and verified yet,Some comments on wrappe
Royce Lv has posted comments on this change.
Change subject: removing the use of zombie reaper from supervdsm
..
Patch Set 2: I would prefer that you didn't submit this
Zheng sheng's idea is great.But with signal.siginterrupt()
Royce Lv has posted comments on this change.
Change subject: removing the use of zombie reaper from supervdsm
..
Patch Set 2:
Zheng sheng's idea is great.But with signal.siginterrupt() previous zombie test
fails. I'm investiga
Royce Lv has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 1: (2 inline comments)
File tests/miscTests.py
Line 1
Royce Lv has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
...
Royce Lv has abandoned this change.
Change subject: [WIP]merge setIPCChannel and supervdsmProxy init
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/11195
To unsubscribe, visit http://gerrit.ovirt.org/settin
Royce Lv has abandoned this change.
Change subject: [WIP]misc clean for supervdsmServer
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/11196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Royce Lv has posted comments on this change.
Change subject: [WIP]clean authKey for managers
..
Patch Set 3:
As I wrote in the commit message, we can use multiprocessing manager without
key to do parent/child IPC.It has been t
Royce Lv has posted comments on this change.
Change subject: [WIP]wait vdsm instead of poking it
..
Patch Set 3: (1 inline comment)
File vdsm/supervdsmServer.py
Line 434: if
Royce Lv has posted comments on this change.
Change subject: [WIP]start vdsm as subprocess in supervdsm server
..
Patch Set 3: (7 inline comments)
Yes, Tested it. Most of the problem may due to disorder rebase problem:(I'll
cl
Royce Lv has uploaded a new change for review.
Change subject: change vdsm to use multipolicy mom
..
change vdsm to use multipolicy mom
To support multipolicy, all policies will be placed
in directory '/etc/vdsm/mom-policy-dir'
Royce Lv has uploaded a new change for review.
Change subject: Add basic ballooning policy to vdsm
..
Add basic ballooning policy to vdsm
Change-Id: Ieffd589dbe524091d84c53cdf109a933b8a3eb4d
Signed-off-by: Royce Lv
---
M vdsm.sp
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup:export priviledged launch for starting
supervdsm
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10706
To unsubscribe, visit http:/
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup: vdsm suicide when supervdsm framework
error
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10707
To unsubscribe, visit http://ger
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup: start supervdsm when startup
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10708
To unsubscribe, visit http://gerrit.ovirt.org/se
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup: seperate supervdsm logger from vdsm ones
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10709
To unsubscribe, visit http://gerrit.
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup:change address owner
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10710
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup:delete check for vdsm user
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/10711
To unsubscribe, visit http://gerrit.ovirt.org/setti
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup: temprary skill supervdsm tests
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/10712
To unsubscribe, visit http://gerrit.ovirt.org/
Royce Lv has posted comments on this change.
Change subject: [WIP]misc clean for supervdsmServer
..
Patch Set 3:
tested: start,stop service, kill vdsm,kill svdsm
Known BUGS: libvirt event loop not reply to keepalive message an
Royce Lv has abandoned this change.
Change subject: [WIP]make changes to init script
..
Patch Set 1: Abandoned
merged in other patches
--
To view, visit http://gerrit.ovirt.org/11197
To unsubscribe, visit http://gerrit.ovirt.o
Royce Lv has uploaded a new change for review.
Change subject: [WIP]make changes to init script
..
[WIP]make changes to init script
Change-Id: I8faed69248ebe56c392fadb9de9dcbd1c67e6264
Signed-off-by: Royce Lv
---
M tests/Makefil
Royce Lv has uploaded a new change for review.
Change subject: [WIP]remove launch and kill svdsm function from supervdsm.py
..
[WIP]remove launch and kill svdsm function from supervdsm.py
when vdsm lost priviledge, it should not
Royce Lv has uploaded a new change for review.
Change subject: [WIP]misc clean for supervdsmServer
..
[WIP]misc clean for supervdsmServer
Change-Id: I6a0cf4be2fc2637df36e2abc4a82ddc1a55f72cd
Signed-off-by: Royce Lv
---
M vdsm/su
Royce Lv has uploaded a new change for review.
Change subject: [WIP]clean authKey for managers
..
[WIP]clean authKey for managers
when authKey is omitted, it will use current_process().authKey,
and this key will be herited when
Royce Lv has uploaded a new change for review.
Change subject: [WIP]wait vdsm instead of poking it
..
[WIP]wait vdsm instead of poking it
wait vdsm the subprocess, handling signal and error flow
as to terminate the subprocess.
Royce Lv has uploaded a new change for review.
Change subject: [WIP]merge setIPCChannel and supervdsmProxy init
..
[WIP]merge setIPCChannel and supervdsmProxy init
Change-Id: I0c031b7becf2fe123cabe25c76237655364f735b
Signed-off-
Royce Lv has uploaded a new change for review.
Change subject: [WIP]start vdsm as subprocess in supervdsm server
..
[WIP]start vdsm as subprocess in supervdsm server
supervdsm will run as root, vdsm start needs to drop priviledg
Royce Lv has uploaded a new change for review.
Change subject: nit fix for _cleanOldFiles
..
nit fix for _cleanOldFiles
svdsm.sock will not be in filterd fileType
Change-Id: I8d37c524c1a2ad7aadf36a27f524c378f6a104d3
Signed-off-
Royce Lv has posted comments on this change.
Change subject: [WIP] creating supervdsm service
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
Generally I like this design.I noticed supervdsmd doe
Royce Lv has uploaded a new change for review.
Change subject: make misc.pgrep for general usage
..
make misc.pgrep for general usage
pgrep now just grep specific named process,
Make it accept other params(e.g.ppid, state, e
Royce Lv has posted comments on this change.
Change subject: Moving pidStat function to utils
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10932
To unsubscr
Royce Lv has posted comments on this change.
Change subject: [WIP]normalize startup:export priviledged launch for starting
supervdsm
..
Patch Set 2:
In module "vdsm", vdsm will kill and start svdsm ,then drop priviledge.
--
T
Royce Lv has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule(#891300)
..
Patch Set 1: I would prefer that you didn't submit this
1.I can't access the bugzilla.
2.As I have explained in
Royce Lv has posted comments on this change.
Change subject: [WIP]normalize startup:delete check for vdsm user
..
Patch Set 2:
Known BUGS: vdsm service started by:'/lib/systemd/systemd-vdsmd start', started
by:'service vdsmd s
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup: temprary skill supervdsm tests
..
[WIP]normalize startup: temprary skill supervdsm tests
To be added back after agreed on this startup propos
Royce Lv has posted comments on this change.
Change subject: [WIP]normalize startup:delete check for vdsm user
..
Patch Set 1:
Known BUGS:
vdsm service started by:'/lib/systemd/systemd-vdsmd start', started by:'service
vdsmd s
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup: seperate supervdsm logger from vdsm ones
..
[WIP]normalize startup: seperate supervdsm logger from vdsm ones
If supervdsm use same log config
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup: start supervdsm when startup
..
[WIP]normalize startup: start supervdsm when startup
start vdsm as root, after restart supervdsm,
drop previl
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup:delete check for vdsm user
..
[WIP]normalize startup:delete check for vdsm user
Change-Id: I6eb2c2f3ed9c4b72368716547e43bf839a319824
Signed-of
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup:change address owner
..
[WIP]normalize startup:change address owner
supervdsm server used to started by vdsm and it changed the address
user t
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup:export priviledged launch for starting
supervdsm
..
[WIP]normalize startup:export priviledged launch for starting supervdsm
Supervdsm will
Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup: vdsm suicide when supervdsm framework
error
..
[WIP]normalize startup: vdsm suicide when supervdsm framework error
Change-Id: I9eebf6dcaf55d
Royce Lv has abandoned this change.
Change subject: converge IPC file manipulation function in svdsm
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/10184
To unsubscribe, visit http://gerrit.ovirt.org/settin
Royce Lv has posted comments on this change.
Change subject: refactor supervdsm proxy call logic
..
Patch Set 2: Verified
Tested: vdsm killed, vdsm will restart and start new svdsm; supervdsm killed,
vdsm restart new supervdsm
Royce Lv has posted comments on this change.
Change subject: Starting svdsm on startup
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9691
To unsubscribe, visit http://
Royce Lv has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 11: (1 inline comment)
Commit Message
Line 5: CommitDate: 2012
Royce Lv has posted comments on this change.
Change subject: change startup process for vdsm and supervdsm
..
Patch Set 11: (4 inline comments)
File vdsm/supervdsm.py
Line 53
Royce Lv has posted comments on this change.
Change subject: add createVm support of cputune
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Royce Lv has posted comments on this change.
Change subject: add createVm support of cputune
..
Patch Set 7: Verified
past unittest of generate xml and functional of create vm on local storage vm
tune and BC of cpuPinning
--
Royce Lv has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Royce Lv has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 11: Verified
past unittest of generate xml and functional of create vm on local storage
emulator pin
--
To view,
Royce Lv has abandoned this change.
Change subject: schema: Add tune element to vmparameter
..
Patch Set 1: Abandoned
included in tune patch
--
To view, visit http://gerrit.ovirt.org/8638
To unsubscribe, visit http://gerrit.ov
Royce Lv has abandoned this change.
Change subject: schema: nit fixes in vm definition
..
Patch Set 1: Abandoned
fixed
--
To view, visit http://gerrit.ovirt.org/8487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Royce Lv has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 4:
Sorry, haven't noticed this comment, will update immediately
--
To view, visit http://gerrit.ovirt.org/8412
To unsubs
Hello Zhou Zheng Sheng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/10236
to review the following change.
Change subject: change of the isRunning function
..
change of the isRunning function
is
Royce Lv has posted comments on this change.
Change subject: Starting svdsm on startup
..
Patch Set 2: I would prefer that you didn't submit this
On vdsm restart, __init__ it does not have member "_svdsm", "_svdsm" only
create
Royce Lv has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Royce Lv has uploaded a new change for review.
Change subject: converge IPC file manipulation function in svdsm
..
converge IPC file manipulation function in svdsm
Change-Id: Ic983da2043f09650fb63e06f4f1ac3d3e218bcc2
Signed-off-
Royce Lv has abandoned this change.
Change subject: general test framework to be compatible for xmlrpc and rest
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/5308
To unsubscribe, visit http://gerrit.ovirt.
Royce Lv has posted comments on this change.
Change subject: Starting svdsm on startup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9691
To unsubscribe, visit http://
Royce Lv has posted comments on this change.
Change subject: add createVm support of cputune
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Royce Lv has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Royce Lv has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/8411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Royce Lv has posted comments on this change.
Change subject: Nit fixes of supervdsmServer
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Royce Lv has posted comments on this change.
Change subject: integrate zombie reaper in supervdsmServer
..
Patch Set 5: Verified
Dan, sorry for the traffic, I rebased http://gerrit.ovirt.org/#/c/9354/ whole
branch so this one
Royce Lv has posted comments on this change.
Change subject: Add ut to supervdsmServer zombie reaper
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Royce Lv has posted comments on this change.
Change subject: cpu mode support for vdsm
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://
Royce Lv has posted comments on this change.
Change subject: xmlrpcTests: change skipNoKVM into a decorator
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9783
To unsub
Royce Lv has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 7:
Laszlo, if your 'host-mode'patch is ready, I'm glad to rebase on yours and
verify with you.
--
To view, visit
Royce Lv has posted comments on this change.
Change subject: cpu mode support for vdsm
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
File vds
Royce Lv has posted comments on this change.
Change subject: cpu mode support for vdsm
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
I like the concept, just minor comments
...
Royce Lv has abandoned this change.
Change subject: bz#849886 allow multilib in bootstrap when download package
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7383
To unsubscribe, visit http://gerrit.ovirt.
Royce Lv has posted comments on this change.
Change subject: fixing pep8 issues in supervdsm
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9672
To unsubscribe, visit h
Royce Lv has uploaded a new change for review.
Change subject: Exclude generated python files from pep8 list
..
Exclude generated python files from pep8 list
Generated files will raise pep8 error because of path substitution:
E5
Royce Lv has posted comments on this change.
Change subject: fix error handling for misc.NoIntrPoll
..
Patch Set 2: (3 inline comments)
File tests/miscTests.py
Line 1121:
Royce Lv has abandoned this change.
Change subject: Add a non-ascii charactor checker to vdsm
..
Patch Set 1: Abandoned
Not proper in the code structure.
--
To view, visit http://gerrit.ovirt.org/9321
To unsubscribe, visit htt
Royce Lv has uploaded a new change for review.
Change subject: remoteFileHandler.py: nit fix for poll mask
..
remoteFileHandler.py: nit fix for poll mask
poll() should use POLLERR/POLLHUP instead of EPOLLERR/EPOLLHUP
Change-Id:
Royce Lv has uploaded a new change for review.
Change subject: miscTests: using MACRO instead of string
..
miscTests: using MACRO instead of string
Change-Id: I005dee7f14e239c36cf1d8e6632406991e410ac5
Signed-off-by: Royce Lv
---
Royce Lv has posted comments on this change.
Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
..
Royce Lv has posted comments on this change.
Change subject: Remove Pool.isMember() function.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit
Royce Lv has uploaded a new change for review.
Change subject: fix error handling for misc.NoIntrPoll
..
fix error handling for misc.NoIntrPoll
when recieving signal, poll() raise select.error
fix this to misc.NoIntrPoll to avoi
())]
Yaniv, I checked path in supervdsmServer.py:
in sys.path there is a path like this '/home/lvroyce/vdsm/tests/$PYTHONPATH',
It is because we need to pass env through misc.execCmd(...,env=someenv)
Line 131: misc.execCmd(superVdsmCmd, sync=False, sudo=True)
Line 132: sle
1 - 100 of 271 matches
Mail list logo
