Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log also error codes of RPC calls
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59234/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59078
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: Adding report_stats to host.api
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58661
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Add hawkular reporter to reports
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58660
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Introduce reports package
..
Patch Set 38: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: schema: customizable hook name
..
Patch Set 1: Verified+1
The changed covered by unit test. Verification was done during build process.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: events: verify data before sending
..
Patch Set 24: Verified+1
Small changes required due to merge conflict. The code was rebased and fixed.
clientIFTests
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: customizable hook name
..
schema: customizable hook name
getCaps response contains hook names which by design can be any string.
We need to support
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events: do not send events on recovery
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59235
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events: do not send events on recovery
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59230
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57735
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57344
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: draft: Adding report_stats to host.api and to virt.stats
..
Patch Set 17:
I agree with Nir about dict approach.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/57623/4/lib/api/vdsm-api.yml
File lib/api/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 4: Verified+1
Only description changes, verified in previous patch set.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57710
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/57623/3/lib/api/vdsm-api.yml
File lib/api/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 3:
I love consistency we have :D
--
To view, visit https://gerrit.ovirt.org/57623
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/57623/3/lib/api/vdsm-api.yml
File lib/api/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getStats
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/57618/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 3: Verified+1
Verified with the running vdsm.
--
To view, visit https://gerrit.ovirt.org/57623
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/57623/2/lib/api/vdsmapi.py
File lib/api/vdsmapi.py
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57623/1/lib/api/vdsmapi.py
File lib/api/vdsmapi.py
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57641
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/55999/20/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 21: Verified+1
Removed print only. Verified in previous patch set.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: xmlrpc server timeout
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57559/1/tests/vdscliTests.py
File tests/vdscliTests.py:
Line 64
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 30: Verified+1
Verified by updating vdsm and seeing that there are no issues during
communication.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getStats
..
Patch Set 2: Verified+1
Verified in previous patch set
--
To view, visit https://gerrit.ovirt.org/57618
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 2: Verified+1
Verified in previous patch set
--
To view, visit https://gerrit.ovirt.org/57623
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/57623/1/lib/api/vdsm-api.yml
File lib/api/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 1: Verified+1
Verified by seeing no complains about the types from type verification logic
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: return type fixes for Host.getCapabilities
..
yml: return type fixes for Host.getCapabilities
Signed-off-by: pkliczewski <piotr.kliczew...@gmail.
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getStats
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57618/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getStats
..
Patch Set 1: Verified+1
Verified by seeing no complains about the types from type verification logic
during
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: return type fixes for Host.getStats
..
yml: return type fixes for Host.getStats
Change-Id: I87eb9c45371fd1c99d5d1a6645ebf51e2ab1e439
Signed-off
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/54754/29/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 317
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 29:
(4 comments)
https://gerrit.ovirt.org/#/c/54754/29/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 105
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add missing test for concurrent.thread
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57208
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: xmlrpc server timeout
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57559/1/tests/vdscliTests.py
File tests/vdscliTests.py:
Line 64
Piotr Kliczewski has posted comments on this change.
Change subject: test: xmlrpc server timeout
..
Patch Set 1: Verified+1
Verified by running local build several times.
--
To view, visit https://gerrit.ovirt.org/57559
Piotr Kliczewski has uploaded a new change for review.
Change subject: test: xmlrpc server timeout
..
test: xmlrpc server timeout
We noticed that during CI build there are occurrences when testTimeout
hangs forever. We want
Piotr Kliczewski has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 18: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56874
Piotr Kliczewski has posted comments on this change.
Change subject: Move hoststats code to host package
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56879
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57547
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 17: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56874/17
Piotr Kliczewski has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit h
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 32:
Rebase only, no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 29: Verified+1
Verified by updating vdsm and seeing that there are no communication issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 32: Verified+1
Verified by updating vdsm and seeing that there are no communication issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Code-Review+2
Raising Francesco's score
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 11: Code-Review+2
Raising score
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 11: Code-Review+1
API changes looks good.
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/56738/10/lib/api/vdsmapi-gluster-schema.json
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57541
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Move hoststats code to host package
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56879
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 35:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/35/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 145
Piotr Kliczewski has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 16: Code-Review+1
Looks good to me but give +1 and waiting
Piotr Kliczewski has posted comments on this change.
Change subject: Move hoststats code to host package
..
Patch Set 12: Code-Review+1
I would give +2 but I need an ack from Francesco so +1 for now.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Move hoststats code to host package
..
Patch Set 11:
(4 comments)
https://gerrit.ovirt.org/#/c/56879/11/lib/vdsm/host/stats.py
File lib/vdsm/host/stats.py
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57463
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 28: Verified+1
test fix backported from top patch in this thread. Verification done as for
previous patch sets
Piotr Kliczewski has posted comments on this change.
Change subject: Revert "tests: Mark new bridge test as broken"
..
Patch Set 2: Verified+1
Verified by CI that the test passes now.
--
To view, v
Piotr Kliczewski has reverted this change.
Change subject: Revert "tests: Mark new bridge test as broken"
..
Uploaded patch set 1.
--
To view, visit https://gerrit.ovirt.org/57504
To unsubscribe, v
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert "tests: Mark new bridge test as broken"
..
Revert "tests: Mark new bridge test as broken"
There was a patch pending to be merg
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 4:
The change looks good, let's wait on CI to finish.
--
To view, visit https://gerrit.ovirt.org/57463
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 34: Verified+1
This patch uses six instead of providing py3 support for Queue. This patch set
verified by running
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 33:
(2 comments)
https://gerrit.ovirt.org/#/c/53919/33/lib/vdsm/compat.py
File lib/vdsm/compat.py:
Line 54: from
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 13: Verified+1
Verified by updating existing env and seeing that there are no communication
issues
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 25:
Verified by updating existing env and seeing that there are no communication
issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 15: Verified+1
Verified by updating existing env and seeing that there are no communication
issues
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 28: Verified+1
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 28:
Verified by updating existing env and seeing that there are no communication
issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 32: Verified+1
Verified by updating existing env and seeing that there are no communication
issues.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 31: Verified+1
Verified by updating existing env and seeing that there are no communication
issues.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 26: Verified+1
Verified by updating existing env and seeing that there are no communication
issues.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/30/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS30, Line 37
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 30:
(3 comments)
https://gerrit.ovirt.org/#/c/53919/30/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS30, Line 37
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/54528/25/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
PS25
Piotr Kliczewski has posted comments on this change.
Change subject: migration: dynamic setting of {in,out}bound limits
..
Patch Set 33: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/29/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS29, Line 180
Piotr Kliczewski has posted comments on this change.
Change subject: schema: yml: fix virt glitches
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57314
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 30: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29:
(7 comments)
https://gerrit.ovirt.org/#/c/53919/29/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS29, Line 32
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 24:
(2 comments)
https://gerrit.ovirt.org/#/c/54528/24/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS24, Line
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 28: Verified+1
(1 comment)
api looks good.
https://gerrit.ovirt.org/#/c/42747/28/lib/api/vdsm-api.yml
File
Piotr Kliczewski has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 10: Code-Review+1
(1 comment)
Api change looks good.
https://gerrit.ovirt.org/#/c/56574/10/lib/api/vdsm-api.yml
Piotr Kliczewski has posted comments on this change.
Change subject: spec: change python-yaml to PyYAML
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57286
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29:
CI failure not related to this patch.
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit
Piotr Kliczewski has abandoned this change.
Change subject: m2c: use custom certificate validation function
..
Abandoned
We do not need this patch anymore.
--
To view, visit https://gerrit.ovirt.org/53398
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 4: Verified+1
Simone can you please verify?
--
To view, visit https://gerrit.ovirt.org/56288
Piotr Kliczewski has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/56874/9/lib/vdsm/host.py
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 22: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 12: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 25: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing that there
are no communication
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29: Verified+1
Code changes as Dan requested. Verified by updating vdsm and seeing that there
are no communication
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 24: Verified+1
Code changes as Dan requested. Verified by updating vdsm and seeing that there
are no communication
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/28/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 160
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 23:
(3 comments)
https://gerrit.ovirt.org/#/c/54528/23/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS23, Line
501 - 600 of 2901 matches
Mail list logo
