Change in vdsm[master]: dump the core of a VM

2014-01-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 14: Adam, I'm very glad that you can pick this up. This patch pending so long time. -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: Detect optional parameter syntax errors in JSON schema

2013-11-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Detect optional parameter syntax errors in JSON schema .. Patch Set 2: (5 comments) Commit Message Line 3: Au

Change in vdsm[master]: define qemu process user and group in configure.ac for Ubunt...

2013-03-11 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: define qemu process user and group in configure.ac for Ubuntu .. Patch Set 1: (1 inline comment) File configur

Change in vdsm[master]: split config file for HSM service standalone

2013-03-07 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: split config file for HSM service standalone .. Patch Set 2: Abandoned Shu Ming have summit another patch which vdsm and hsm depend on the same python lib. http://gerrit.o

Change in vdsm[master]: add JsonPpcClientAPI class

2013-03-07 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: add JsonPpcClientAPI class .. Patch Set 1: Abandoned jsonrpc/client.py have been moved to yajsonrpc and the implement serve and client has changed. -- To view, visit http

Change in vdsm[master]: make compression type configurable, support gzip and xz

2013-03-07 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 5: Abandoned It does not make sense to support both gzip and xz. -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: gluster: add task support

2013-02-28 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: gluster: add task support .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments) File

Change in vdsm[master]: Make HSM service self containted

2013-02-26 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Make HSM service self containted .. Patch Set 4: (1 inline comment) It make things easy that normal VDSM service and the storage service depend on the same vdsm-p

Change in vdsm[master]: Make HSM service self containted

2013-02-26 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Make HSM service self containted .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments) after this patch, will both HSM service and vdsm s

Change in vdsm[master]: add a json rpc funtional test which sets up a VM

2013-02-25 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: add a json rpc funtional test which sets up a VM .. Patch Set 4: (1 inline comment) File tests/functional/json

Change in vdsm[master]: dump the core of a VM

2013-02-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 14: watchdog dump will generate the dump file at auto_dump_path defined in /etc/libvirt/qemu.conf. auto_dump_path is defined i

Change in vdsm[master]: fix Exception message error in apiTests module

2013-02-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11289 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: check the syntaxs of optional parameters in json schema

2013-02-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: check the syntaxs of optional parameters in json schema .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10446 To unsubscribe, visit http://gerri

Change in vdsm[master]: add JsonPpcClientAPI class

2013-02-07 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: add JsonPpcClientAPI class .. add JsonPpcClientAPI class This new class will parse the json schema and generate the json API dynamically Change-Id: Iaa825e7fed1e

Change in vdsm[master]: removing the use of zombie reaper from supervdsm

2013-01-30 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: removing the use of zombie reaper from supervdsm .. Patch Set 2: I would prefer that you didn't submit this yes, we should not workaround for the master branch. W

Change in vdsm[master]: cancel the core dump of a VM

2013-01-29 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 7: I would prefer that you didn't submit this (3 inline comments) F

Change in vdsm[master]: get the status of core dump

2013-01-29 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: get the status of core dump .. Patch Set 7: I would prefer that you didn't submit this (3 inline comments) Fi

Change in vdsm[master]: fix schemaTests test error

2013-01-29 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix schemaTests test error .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11490 To unsubscribe, visit ht

Change in vdsm[master]: fix schemaTests test error

2013-01-29 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix schemaTests test error .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) File

Change in vdsm[master]: migrateStatus() progress report

2013-01-28 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: migrateStatus() progress report .. Patch Set 18: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, vis

Change in vdsm[master]: migrateStatus() progress report

2013-01-28 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: migrateStatus() progress report .. Patch Set 16: (1 inline comment) File vdsm/libvirtvm.py Line 428:

Change in vdsm[master]: dump the core of a VM

2013-01-27 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 10: (3 inline comments) File vdsm/vm.py Line 357: try: Line 358:

Change in vdsm[master]: dump the core of a VM

2013-01-25 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 10: (16 inline comments) File vdsm/API.py Line 257: :param to: a st

Change in vdsm[master]: fix Exception message error in apiTests module

2013-01-24 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 2: I have check the jenkins error report. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/45/c

Change in vdsm[master]: add a json rpc funtional test which sets up a VM

2013-01-24 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: add a json rpc funtional test which sets up a VM .. Patch Set 1: Maybe it should still reduce the reduplicated code of xml test. -- To view, visit http://gerrit.o

Change in vdsm[master]: add a json rpc funtional test which sets up a VM

2013-01-24 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: add a json rpc funtional test which sets up a VM .. add a json rpc funtional test which sets up a VM This test create a VM and destroy it. It take full advantage

Change in vdsm[master]: move kernelBootImages to a new file functionalUtils.py

2013-01-24 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: move kernelBootImages to a new file functionalUtils.py .. move kernelBootImages to a new file functionalUtils.py There is already a good functional test for xmlrp

Change in vdsm[master]: add a jsonrpcSeverClient for jsonRPC Server functional test

2013-01-24 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test .. Patch Set 2: (6 inline comments) File tests/fun

Change in vdsm[master]: Bridge: Fix the specification of the getAllTasks return valu...

2013-01-23 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Bridge: Fix the specification of the getAllTasks return value .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://ge

Change in vdsm[master]: add a jsonrpcSeverClient for jsonRPC Server functional test

2013-01-23 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test .. Patch Set 2: (4 inline comments) Commit Message

Change in vdsm[master]: dump the core of a VM

2013-01-22 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 10: (2 inline comments) File vdsm/API.py Line 283: Line 284: dumpP

Change in vdsm[master]: fix Exception message error in apiTests module

2013-01-22 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: fix Exception message error in apiTests module .. fix Exception message error in apiTests module Change-Id: Ic51b141047dc0490e50a050fd667f63d30f121f2 Signed-off-b

Change in vdsm[master]: add a jsonrpcSeverClient for jsonRPC Server functional test

2013-01-22 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test .. Patch Set 1: (1 inline comment) Commit Message

Change in vdsm[master]: vdsm: Refactoring libvirtvm & vm

2013-01-22 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: vdsm: Refactoring libvirtvm & vm .. Patch Set 2: Vinzenz: a question about my patch. http://gerrit.ovirt.org/#/c/7329/ my patch should be in /vm/vm.py ? -- To

Change in vdsm[master]: add a jsonrpcSeverClient for jsonRPC Server functional test

2013-01-22 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test .. add a jsonrpcSeverClient for jsonRPC Server functional test This jsonrpcSeverClient is easy to call

Change in vdsm[master]: vdsm: Refactoring libvirtvm & vm

2013-01-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: vdsm: Refactoring libvirtvm & vm .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) just reviewed the first ten files. ..

Change in vdsm[master]: vdsm: Refactoring libvirtvm & vm

2013-01-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: vdsm: Refactoring libvirtvm & vm .. Patch Set 1: (2 inline comments) File Makefile.am Line 87:vdsm/sto

Change in vdsm[master]: BindingXMLRPC: flowID for Irs calls

2013-01-18 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: BindingXMLRPC: flowID for Irs calls .. Patch Set 5: (1 inline comment) File vdsm/BindingXMLRPC.py Line 166:

Change in vdsm[master]: migrateStatus() progress report

2013-01-18 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: migrateStatus() progress report .. Patch Set 16: I would prefer that you didn't submit this (2 inline comments) ..

Change in vdsm[master]: dump the core of a VM

2013-01-18 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 8: (3 inline comments) File vdsm/API.py Line 278: try: Line 279

Change in vdsm[master]: get the status of core dump

2013-01-17 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: get the status of core dump .. Patch Set 2: (2 inline comments) File vdsm/API.py Line 306: return v.du

Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

2013-01-17 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add a flag to libvirtvm's status to report watchdog event .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/9429 To unsubscribe, visit http://gerr

Change in vdsm[master]: fix the optional parameters error of api schema file

2013-01-17 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix the optional parameters error of api schema file .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10447 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: fix two parameters of VmParameters in vdsmapi schema

2013-01-17 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix two parameters of VmParameters in vdsmapi schema .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: cancel the core dump of a VM

2013-01-16 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: cancel the core dump of a VM .. cancel the core dump of a VM Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Signed-off-by: ShaoHe Feng --- M vdsm/API.py M

Change in vdsm[master]: get the status of core dump

2013-01-16 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: get the status of core dump .. get the status of core dump Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8 Signed-off-by: ShaoHe Feng --- M vdsm/API.py M vd

Change in vdsm[master]: dump the core of a VM

2013-01-16 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 6: (12 inline comments) File vdsm/API.py Line 276: 'r

Change in vdsm[master]: dump the core of a VM

2013-01-16 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 5: (6 inline comments) test this patch. http://www.ovirt.org/Vdsm_Standalone after the vm is create and start. dumpPath = '/t

Change in vdsm[master]: dump the core of a domain

2013-01-10 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a domain .. Patch Set 4: (4 inline comments) File vdsm_api/vdsmapi-schema.json Line 4873: # @

Change in vdsm[master]: tests/functional: Add GlusterSD functional test

2013-01-08 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests/functional: Add GlusterSD functional test .. Patch Set 3: (1 inline comment) File tests/functional/xmlrp

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

2013-01-08 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm .. Patch Set 7: Looks good to me, but someone else must approve a question: will the vdsm-gluster rpm

Change in vdsm[master]: Added a support for a guest hibernate command.

2013-01-08 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 15: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: tests: add iscsi storage functional test

2013-01-07 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests: add iscsi storage functional test .. Patch Set 6: (1 inline comment) File tests/functional/xmlrpcTests.

Change in vdsm[master]: tests: add iscsi storage functional test

2013-01-06 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests: add iscsi storage functional test .. Patch Set 6: test on fc17 -- To view, visit http://gerrit.ovirt.org/9842 To unsubscribe, visit http://gerrit.ovirt.org

Change in vdsm[master]: tests: add iscsi storage functional test

2013-01-06 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests: add iscsi storage functional test .. Patch Set 6: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9842 T

Change in vdsm[master]: Add a router to multiplex port 54321 and serve HTTP request

2013-01-04 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add a router to multiplex port 54321 and serve HTTP request .. Patch Set 3: thank you for your explanation -- To view, visit http://gerrit.ovirt.org/9605 To unsub

Change in vdsm[master]: tests: Test schema validity

2013-01-03 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests: Test schema validity .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) ...

Change in vdsm[master]: [WIP] remote serial console via HTTP virtual server

2012-12-31 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: [WIP] remote serial console via HTTP virtual server .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: [WIP] Add virtual HTTP(s) server multiplexing port 54321

2012-12-31 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: [WIP] Add virtual HTTP(s) server multiplexing port 54321 .. Patch Set 2: (2 inline comments) have read the UrlRouter code to can dispatch HTTP request by url. but

Change in vdsm[master]: fix the optional parameters error of api schema file

2012-12-27 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix the optional parameters error of api schema file .. Patch Set 2: (2 inline comments) Adam, can you check the comments in the patch? ..

Change in vdsm[master]: fix the optional parameters error of api schema file

2012-12-27 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: fix the optional parameters error of api schema file .. fix the optional parameters error of api schema file some discrptions of optional parameters miss #optiona

Change in vdsm[master]: check the syntaxs of optional parameters in json schema

2012-12-27 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: check the syntaxs of optional parameters in json schema .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10446 To unsubscribe, visit http://gerri

Change in vdsm[master]: check the syntaxs of optional parameters in json schema

2012-12-27 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: check the syntaxs of optional parameters in json schema .. Patch Set 1: yes. jenkins report errors means my patch is right. there are so many optional parameters

Change in vdsm[master]: check the syntaxs of optional parameters in json schema

2012-12-27 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: check the syntaxs of optional parameters in json schema .. check the syntaxs of optional parameters in json schema There are so many syntaxs error of optional par

Change in vdsm[master]: Improve dom xml gereration

2012-12-27 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 3: (1 inline comment) File vdsm/libvirtvm.py Line 552: class XMLElem(o

Change in vdsm[master]: split config file for HSM service standalone

2012-12-25 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: split config file for HSM service standalone .. Patch Set 2: (1 inline comment) File vdsm/libvirtvm.py Line 10

Change in vdsm[master]: split config file for HSM service standalone

2012-12-25 Thread shaohef
Hello Shu Ming, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/10363 to review the following change. Change subject: split config file for HSM service standalone .. split config file for HSM servic

Change in vdsm[master]: Add qemu's memory usage to VM statistics.

2012-12-21 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add qemu's memory usage to VM statistics. .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) ..

Change in vdsm[master]: migrateStatus() progress report

2012-12-20 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: migrateStatus() progress report .. Patch Set 11: Looks good to me, but someone else must approve (1 inline comment) ..

Change in vdsm[master]: api: Report CPU thread info in getVdsCapabilities

2012-12-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: api: Report CPU thread info in getVdsCapabilities .. Patch Set 4: No score -- To view, visit http://gerrit.ovirt.org/10144 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: api: Report CPU thread info in getVdsCapabilities

2012-12-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: api: Report CPU thread info in getVdsCapabilities .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .

Change in vdsm[master]: Improvement of the GuestAgent class memory usage

2012-12-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Improvement of the GuestAgent class memory usage .. Patch Set 9: (2 inline comments) File tests/guestIFTests.p

Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

2012-12-18 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add a flag to libvirtvm's status to report watchdog event .. Patch Set 5: (3 inline comments) File vdsm_api/vd

Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

2012-12-17 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add a flag to libvirtvm's status to report watchdog event .. Patch Set 4: Verified add a watchdog device option when create a VM. Verified 1. get status of VM, no

Change in vdsm[master]: tests: Test schema validity

2012-12-13 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tests: Test schema validity .. Patch Set 1: (1 inline comment) File tests/schemaTests.py Line 43: self

Change in vdsm[master]: fix two parameters of VmParameters in vdsmapi schema

2012-12-13 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: fix two parameters of VmParameters in vdsmapi schema .. Patch Set 1: I have update my git repository. This is not fixed yet. there are two places that define "smp

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-12-12 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Vinzenz: you can have a look at this patch: http://gerrit.ovirt.org/#/c/5640/ Gal Hamme

Change in vdsm[master]: Add qemu's memory usage to VM statistics.

2012-12-12 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add qemu's memory usage to VM statistics. .. Patch Set 4: (1 inline comment) File vdsm/libvirtvm.py Line 177:

Change in vdsm[master]: improve the readability of prefix2netmask

2012-12-12 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: improve the readability of prefix2netmask .. Patch Set 1: (1 inline comment) File vdsm/netinfo.py Line 169: L

Change in vdsm[master]: improve the readability of prefix2netmask

2012-12-12 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: improve the readability of prefix2netmask .. improve the readability of prefix2netmask Change-Id: I42519c4d67c0b4cf6415160ca051583dddb0efd2 Signed-off-by: ShaoHe

Change in vdsm[master]: Checking accessibility to vdsm log file

2012-12-12 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Checking accessibility to vdsm log file .. Patch Set 6: (1 inline comment) File vdsm/vdsmd.init.in Line 88: L

Change in vdsm[master]: Checking accessibility to vdsm log file

2012-12-12 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Checking accessibility to vdsm log file .. Patch Set 6: Fails; I would prefer that you didn't submit this the shell of vdswm user is /sbin/nologin. I'm not sure th

Change in vdsm[master]: Fix flake8 warnings for network code.

2012-12-11 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Fix flake8 warnings for network code. .. Patch Set 1: (1 inline comment) the comment is not related with pep8

Change in vdsm[master]: Fix flake8 warnings for network code.

2012-12-11 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Fix flake8 warnings for network code. .. Patch Set 1: I would prefer that you didn't submit this toni, can you add these file to the PEP8_WHITELIST of Makefile.am?

Change in vdsm[master]: netwiring: [4/4] Add API definitions.

2012-12-10 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [4/4] Add API definitions. .. Patch Set 33: (1 inline comment) File vdsm/netinfo.py Line 174:

Change in vdsm[master]: netwiring: [4/4] Add API definitions.

2012-12-10 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [4/4] Add API definitions. .. Patch Set 33: Looks good to me, but someone else must approve (3 inline comments) just a minor suggestion. .

Change in vdsm[master]: vdsm_reg/define.py: drop unused file

2012-12-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: vdsm_reg/define.py: drop unused file .. Patch Set 1: yes, i have not found than define module are imported from the vdsm_reg -- To view, visit http://gerrit.ovi

Change in vdsm[master]: pep8: fix E241

2012-12-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: pep8: fix E241 .. Patch Set 1: Looks good to me, but someone else must approve check and no E241 error. -- To view, visit http://gerrit.ovirt.org/9807 To unsubscr

Change in vdsm[master]: style: drop trailing backslash per Zhou's request

2012-12-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: style: drop trailing backslash per Zhou's request .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9809 To

Change in vdsm[master]: Adding check of os.access to vdsm log file during startup

2012-12-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Adding check of os.access to vdsm log file during startup .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: Add callback to the plethora of retry halting possibilities

2012-12-09 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add callback to the plethora of retry halting possibilities .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

Change in vdsm[master]: remove redundant import misc

2012-12-06 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: remove redundant import misc .. Patch Set 2: rebase to the latest commit. -- To view, visit http://gerrit.ovirt.org/9372 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: remove redundant import misc

2012-12-06 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: remove redundant import misc .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) sorry, -1 for I did not find "updateDevice" de

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9560 To unsubscribe

Change in vdsm[master]: [WIP] Add virtual HTTP(s) server multiplexing port 54321

2012-12-03 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: [WIP] Add virtual HTTP(s) server multiplexing port 54321 .. Patch Set 1: (1 inline comment) Commit Message Lin

Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

2012-12-03 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Add a flag to libvirtvm's status to report watchdog event .. Patch Set 4: Doron: yes, engine can get watchdog event by checking the 'watchdogEvent' key in the

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-03 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9561 To unsubscribe

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-03 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Hopefully, my patch can be merged. http://gerr

  1   2   3   4   >