ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 14:
Adam, I'm very glad that you can pick this up.
This patch pending so long time.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: Detect optional parameter syntax errors in JSON schema
..
Patch Set 2:
(5 comments)
Commit Message
Line 3:
ShaoHe Feng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
..
Patch Set 1: (1 inline comment)
File
ShaoHe Feng has abandoned this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 5: Abandoned
It does not make sense to support both gzip and xz.
--
To view, visit
ShaoHe Feng has abandoned this change.
Change subject: add JsonPpcClientAPI class
..
Patch Set 1: Abandoned
jsonrpc/client.py have been moved to yajsonrpc and the implement serve and
client has changed.
--
To view, visit
ShaoHe Feng has abandoned this change.
Change subject: split config file for HSM service standalone
..
Patch Set 2: Abandoned
Shu Ming have summit another patch which vdsm and hsm depend on the same python
lib.
ShaoHe Feng has posted comments on this change.
Change subject: gluster: add task support
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: Make HSM service self containted
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
after this patch, will both HSM service and vdsm
ShaoHe Feng has posted comments on this change.
Change subject: Make HSM service self containted
..
Patch Set 4: (1 inline comment)
It make things easy that normal VDSM service and the storage service depend on
the same
ShaoHe Feng has posted comments on this change.
Change subject: add a json rpc funtional test which sets up a VM
..
Patch Set 4: (1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: check the syntaxs of optional parameters in json schema
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10446
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix Exception message error in apiTests module
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11289
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 14:
watchdog dump will generate the dump file at auto_dump_path defined in
/etc/libvirt/qemu.conf.
auto_dump_path is defined
ShaoHe Feng has uploaded a new change for review.
Change subject: add JsonPpcClientAPI class
..
add JsonPpcClientAPI class
This new class will parse the json schema and generate the json API
dynamically
Change-Id:
ShaoHe Feng has posted comments on this change.
Change subject: removing the use of zombie reaper from supervdsm
..
Patch Set 2: I would prefer that you didn't submit this
yes, we should not workaround for the master branch.
ShaoHe Feng has posted comments on this change.
Change subject: fix schemaTests test error
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: fix schemaTests test error
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11490
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: cancel the core dump of a VM
..
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 18: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe,
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 10: (3 inline comments)
File vdsm/vm.py
Line 357: try:
Line 358:
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 10: (16 inline comments)
File vdsm/API.py
Line 257: :param to: a
ShaoHe Feng has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 2: (6 inline comments)
File
ShaoHe Feng has uploaded a new change for review.
Change subject: move kernelBootImages to a new file functionalUtils.py
..
move kernelBootImages to a new file functionalUtils.py
There is already a good functional test for
ShaoHe Feng has uploaded a new change for review.
Change subject: add a json rpc funtional test which sets up a VM
..
add a json rpc funtional test which sets up a VM
This test create a VM and destroy it.
It take full advantage
ShaoHe Feng has posted comments on this change.
Change subject: add a json rpc funtional test which sets up a VM
..
Patch Set 1:
Maybe it should still reduce the reduplicated code of xml test.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix Exception message error in apiTests module
..
Patch Set 2:
I have check the jenkins error report.
ShaoHe Feng has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 2: (4 inline comments)
Commit
ShaoHe Feng has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has uploaded a new change for review.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
add a jsonrpcSeverClient for jsonRPC Server functional test
This jsonrpcSeverClient is easy to
ShaoHe Feng has posted comments on this change.
Change subject: vdsm: Refactoring libvirtvm vm
..
Patch Set 2:
Vinzenz:
a question about my patch. http://gerrit.ovirt.org/#/c/7329/
my patch should be in /vm/vm.py ?
--
To
ShaoHe Feng has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 1: (1 inline comment)
Commit Message
ShaoHe Feng has uploaded a new change for review.
Change subject: fix Exception message error in apiTests module
..
fix Exception message error in apiTests module
Change-Id: Ic51b141047dc0490e50a050fd667f63d30f121f2
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 10: (2 inline comments)
File vdsm/API.py
Line 283:
Line 284:
ShaoHe Feng has posted comments on this change.
Change subject: vdsm: Refactoring libvirtvm vm
..
Patch Set 1: (2 inline comments)
File Makefile.am
Line 87:
ShaoHe Feng has posted comments on this change.
Change subject: vdsm: Refactoring libvirtvm vm
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
just reviewed the first ten files.
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 8: (3 inline comments)
File vdsm/API.py
Line 278: try:
Line
ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 16: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: BindingXMLRPC: flowID for Irs calls
..
Patch Set 5: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 166:
ShaoHe Feng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9112
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix the optional parameters error of api schema file
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10447
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/9429
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 2: (2 inline comments)
File vdsm/API.py
Line 306: return
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 5: (6 inline comments)
test this patch.
http://www.ovirt.org/Vdsm_Standalone
after the vm is create and start.
dumpPath =
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 6: (12 inline comments)
File vdsm/API.py
Line 276:
ShaoHe Feng has uploaded a new change for review.
Change subject: get the status of core dump
..
get the status of core dump
Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8
Signed-off-by: ShaoHe Feng
ShaoHe Feng has uploaded a new change for review.
Change subject: cancel the core dump of a VM
..
cancel the core dump of a VM
Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Signed-off-by: ShaoHe Feng
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 4: (4 inline comments)
File vdsm_api/vdsmapi-schema.json
Line 4873: #
ShaoHe Feng has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 15: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
..
Patch Set 7: Looks good to me, but someone else must approve
a question:
will the vdsm-gluster
ShaoHe Feng has posted comments on this change.
Change subject: tests: add iscsi storage functional test
..
Patch Set 6: (1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: tests: add iscsi storage functional test
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9842
ShaoHe Feng has posted comments on this change.
Change subject: tests: add iscsi storage functional test
..
Patch Set 6:
test on fc17
--
To view, visit http://gerrit.ovirt.org/9842
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Add a router to multiplex port 54321 and serve HTTP request
..
Patch Set 3:
thank you for your explanation
--
To view, visit http://gerrit.ovirt.org/9605
To
ShaoHe Feng has posted comments on this change.
Change subject: tests: Test schema validity
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] Add virtual HTTP(s) server multiplexing port 54321
..
Patch Set 2: (2 inline comments)
have read the UrlRouter code to can dispatch HTTP request by url.
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] remote serial console via HTTP virtual server
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Improve dom xml gereration
..
Patch Set 3: (1 inline comment)
File vdsm/libvirtvm.py
Line 552: class
ShaoHe Feng has uploaded a new change for review.
Change subject: check the syntaxs of optional parameters in json schema
..
check the syntaxs of optional parameters in json schema
There are so many syntaxs error of optional
ShaoHe Feng has posted comments on this change.
Change subject: check the syntaxs of optional parameters in json schema
..
Patch Set 1:
yes. jenkins report errors means my patch is right.
there are so many optional parameters
ShaoHe Feng has posted comments on this change.
Change subject: check the syntaxs of optional parameters in json schema
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10446
To unsubscribe, visit
ShaoHe Feng has uploaded a new change for review.
Change subject: fix the optional parameters error of api schema file
..
fix the optional parameters error of api schema file
some discrptions of optional parameters miss
ShaoHe Feng has posted comments on this change.
Change subject: fix the optional parameters error of api schema file
..
Patch Set 2: (2 inline comments)
Adam, can you check the comments in the patch?
Hello Shu Ming,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/10363
to review the following change.
Change subject: split config file for HSM service standalone
..
split config file for HSM
ShaoHe Feng has posted comments on this change.
Change subject: split config file for HSM service standalone
..
Patch Set 2: (1 inline comment)
File vdsm/libvirtvm.py
Line
ShaoHe Feng has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 11: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Improvement of the GuestAgent class memory usage
..
Patch Set 9: (2 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: api: Report CPU thread info in getVdsCapabilities
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: api: Report CPU thread info in getVdsCapabilities
..
Patch Set 4: No score
--
To view, visit http://gerrit.ovirt.org/10144
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
..
Patch Set 5: (3 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
..
Patch Set 4: Verified
add a watchdog device option when create a VM.
Verified
1. get status of VM,
ShaoHe Feng has posted comments on this change.
Change subject: tests: Test schema validity
..
Patch Set 1: (1 inline comment)
File tests/schemaTests.py
Line 43:
ShaoHe Feng has posted comments on this change.
Change subject: Checking accessibility to vdsm log file
..
Patch Set 6: Fails; I would prefer that you didn't submit this
the shell of vdswm user is /sbin/nologin.
I'm not sure
ShaoHe Feng has posted comments on this change.
Change subject: Checking accessibility to vdsm log file
..
Patch Set 6: (1 inline comment)
File vdsm/vdsmd.init.in
Line 88:
ShaoHe Feng has uploaded a new change for review.
Change subject: improve the readability of prefix2netmask
..
improve the readability of prefix2netmask
Change-Id: I42519c4d67c0b4cf6415160ca051583dddb0efd2
Signed-off-by: ShaoHe
ShaoHe Feng has posted comments on this change.
Change subject: improve the readability of prefix2netmask
..
Patch Set 1: (1 inline comment)
File vdsm/netinfo.py
Line 169:
ShaoHe Feng has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 4: (1 inline comment)
File vdsm/libvirtvm.py
Line 177:
ShaoHe Feng has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 3:
Vinzenz:
you can have a look at this patch: http://gerrit.ovirt.org/#/c/5640/
Gal
ShaoHe Feng has posted comments on this change.
Change subject: Fix flake8 warnings for network code.
..
Patch Set 1: I would prefer that you didn't submit this
toni, can you add these file to the PEP8_WHITELIST of
ShaoHe Feng has posted comments on this change.
Change subject: Fix flake8 warnings for network code.
..
Patch Set 1: (1 inline comment)
the comment is not related with pep8
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [4/4] Add API definitions.
..
Patch Set 33: Looks good to me, but someone else must approve
(3 inline comments)
just a minor suggestion.
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [4/4] Add API definitions.
..
Patch Set 33: (1 inline comment)
File vdsm/netinfo.py
Line 174:
ShaoHe Feng has posted comments on this change.
Change subject: Add callback to the plethora of retry halting possibilities
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: style: drop trailing backslash per Zhou's request
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9809
ShaoHe Feng has posted comments on this change.
Change subject: pep8: fix E241
..
Patch Set 1: Looks good to me, but someone else must approve
check and no E241 error.
--
To view, visit http://gerrit.ovirt.org/9807
To
ShaoHe Feng has posted comments on this change.
Change subject: vdsm_reg/define.py: drop unused file
..
Patch Set 1:
yes, i have not found than define module are imported from the vdsm_reg
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: remove redundant import misc
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit http://gerrit.ovirt.org/settings
ShaoHe Feng has posted comments on this change.
Change subject: remove redundant import misc
..
Patch Set 2:
rebase to the latest commit.
--
To view, visit http://gerrit.ovirt.org/9372
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9560
To
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
sorry, -1 for I did not find updateDevice
Hello Bing Bu Cao,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/9655
to review the following change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Add shutdown based
ShaoHe Feng has posted comments on this change.
Change subject: add a Makefile command to generate vdsm-api.html
..
Patch Set 4:
Now when some one edits the vdsmapi-schema.json and brings some schema syntax
error, then make
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Hopefully, my patch can be merged.
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9561
To
ShaoHe Feng has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
..
Patch Set 4:
Doron:
yes, engine can get watchdog event by checking the 'watchdogEvent' key in the
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] Add virtual HTTP(s) server multiplexing port 54321
..
Patch Set 1: (1 inline comment)
Commit Message
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/3] Add API definitions.
..
Patch Set 3:
this is jenkins report of pep8 check for your patch set1
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] netwiring: [3/3] Add API definitions.
..
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
1 - 100 of 355 matches
Mail list logo