Mark Wu has posted comments on this change.
Change subject: Fix assert bug in testBrokenBridgelessNetReplacement
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22710
To unsubscribe, visit http://gerrit.ov
Mark Wu has posted comments on this change.
Change subject: Fix assert bug in testBrokenBridgelessNetReplacement
..
Patch Set 1:
I am fine for both resolution. I just find that it's very bad to not closely
follow the update o
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 13:
Thanks a lot for the help!!
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visi
Mark Wu has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 13:
Dan, I didn't notice you have helped to update it. Please merge patch v12. I
don't include other
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 13:
Dan, I didn't notice you have helped to update it.
Please merge patch v12. I don't include other c
Mark Wu has uploaded a new change for review.
Change subject: Fix assert bug in testBrokenBridgelessNetReplacement
..
Fix assert bug in testBrokenBridgelessNetReplacement
If the underlying device is missing, vdsm will not report
Mark Wu has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 11:
IIRC, I was asked to move it to lib/vdsm before.
I agree with you thought. I am going to move it
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 11:
Hi Dan,
Yes, 5 test cases can't pass with iproute2 configurator, including the case you
pointed o
Mark Wu has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://gerrit.ov
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visit http://gerrit.ov
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 25: Verified+1
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Mark Wu has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://gerrit.ov
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visit http://gerrit.ov
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 24: Verified+1
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Mark Wu has abandoned this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Abandoned
Resolved in Toni's series.
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http:
Mark Wu has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21702
To unsubscribe, visit http://gerrit.o
Mark Wu has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 4:
it needs a rebase on d4737dd40 to resolve the 'defaultdict' regression.
--
To view, visit http:
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 19:
It can pass all the tests except followings:
testAddVlanedBridgeless
testAddVla
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 6:
(1 comment)
File vdsm/netconf/__init__
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 6:
(1 comment)
File vdsm/netconf/__init__
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://ger
Mark Wu has abandoned this change.
Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..
Abandoned
It should be done on engine side
--
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visi
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 3:
(4 comments)
Thanks a lot for your insightful review! I will post a new patch in a few day
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://ger
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://ger
Mark Wu has abandoned this change.
Change subject: Fix vm block stats lost after recovery
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/6056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Mark Wu has posted comments on this change.
Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20674
To unsubscribe, visit http://
Mark Wu has posted comments on this change.
Change subject: drop unused checkPathStat
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 18:
Sorry for no update on this patch in a long period.
Actually, this patch is pending on two problems:
1, a race problem in th
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://ger
Mark Wu has uploaded a new change for review.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
netconf: Improve unified persistence's rollback in memory.
This patch removes the dependency on ifcfg's
Mark Wu has posted comments on this change.
Change subject: Bump kernel requires version to pass testSetupNetworksMtus on
F19
..
Patch Set 1:
It looks the jekins failure is caused by missing dependency of glusterfs, not
relev
Mark Wu has posted comments on this change.
Change subject: Bump kernel requires version to pass testSetupNetworksMtus on
F19
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19974
To unsubscribe, visit ht
Mark Wu has uploaded a new change for review.
Change subject: Bump kernel requires version to pass testSetupNetworksMtus on
F19
..
Bump kernel requires version to pass testSetupNetworksMtus on F19
It's found that testSetupNetwo
Mark Wu has abandoned this change.
Change subject: tests: Let dummy interfaces destroied after cleaning up
networks.
..
Abandoned
fixed in http://gerrit.ovirt.org/19650
--
To view, visit http://gerrit.ovirt.org/19609
To unsu
Mark Wu has posted comments on this change.
Change subject: netconf: Sort bond's slave when objectivizing
..
Patch Set 3:
(1 comment)
File vdsm/netmodels.py
Line 389: to
Mark Wu has abandoned this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/19541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mark Wu has posted comments on this change.
Change subject: tests: Let dummy interfaces destroied after cleaning up
networks.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19609
To unsubscribe, visit ht
Mark Wu has uploaded a new change for review.
Change subject: tests: Let dummy interfaces destroied after cleaning up
networks.
..
tests: Let dummy interfaces destroied after cleaning up networks.
If dummy interfaces are destro
Mark Wu has posted comments on this change.
Change subject: netconf: Sort bond's slave when objectivizing
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19591
To unsubscribe, visit http://gerrit.ovirt.org
Mark Wu has posted comments on this change.
Change subject: netconf: Sort bond's slave when objectivizing
..
Patch Set 1:
Toni, thanks for the quick response! Actually I thought fixing in iproute2, but
we need sort the nic obj
Mark Wu has posted comments on this change.
Change subject: netconf: Sort bond's slave when objectivizing
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19591
To unsubscribe, visit http://gerrit.ovirt.org
Mark Wu has uploaded a new change for review.
Change subject: netconf: Sort bond's slave when objectivizing
..
netconf: Sort bond's slave when objectivizing
To make iproute2 configurator pass testBondHwAddress, we need keep
the
Mark Wu has posted comments on this change.
Change subject: tests: Fix testBondHwAddress for fedora kernel
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19590
To unsubscribe, visit http://gerrit.ovirt.or
Mark Wu has uploaded a new change for review.
Change subject: tests: Fix testBondHwAddress for fedora kernel
..
tests: Fix testBondHwAddress for fedora kernel
In relatively new kernel, the hwaddr of bonding will be set to a
rand
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 1: Code-Review-1
(1 comment)
File vdsm/vd
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 18:
(1 comment)
File vdsm/netconf/iproute2.py
Line 121: if toBeRem
Mark Wu has uploaded a new change for review.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
netconf: Improve unified persistence's rollback in memory.
This patch removes the dependency on ifcfg's
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 24: Code-Review+1
(1 comment)
File lib/vdsm/
Mark Wu has posted comments on this change.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Patch Set 1: Code-Review-1
(4 comments)
File
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 22: Code-Review-1
(2 comments)
File lib/vdsm
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 18:
(4 comments)
File vdsm/netconf/iproute2.py
Line 39: def __init__(s
Mark Wu has posted comments on this change.
Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17640
To unsubscribe, visit http://ger
Mark Wu has posted comments on this change.
Change subject: netconf: Fix the mtu of bond and nic can't be set for new
network
..
Patch Set 2:
Saggi, this patch just follow the pattern of existing test cases. So I would
like
Mark Wu has posted comments on this change.
Change subject: netconf: Fix the mtu of bond and nic can't be set for new
network
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18966
To unsubscribe, visit ht
Mark Wu has posted comments on this change.
Change subject: netconf: Fix the mtu of bond and nic can't be set for new
network
..
Patch Set 2:
Saggi, thanks for the review!
I will resolve your comments in next patch.
--
To vi
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Mark Wu has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visit http://gerrit.ovi
Mark Wu has posted comments on this change.
Change subject: netconf: Fix the mtu of bond and nic can't be set for new
network
..
Patch Set 1: Verified+1
It's verified on RHEL6. But the test case fails on Fedora19 because of bu
Mark Wu has uploaded a new change for review.
Change subject: netconf: Fix the mtu of bond and nic can't be set for new
network
..
netconf: Fix the mtu of bond and nic can't be set for new network
The configuring should not be
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 20: Code-Review-1
(5 comments)
File vdsm/con
Mark Wu has posted comments on this change.
Change subject: vdsm: Add tuneBlockDevIo interface
..
Patch Set 14: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/14394
To unsubscribe, visit http://gerrit.ovirt.org/settin
Mark Wu has posted comments on this change.
Change subject: fix testDelNetworkWithMTU
..
Patch Set 2: Code-Review+1
Thanks for the fix! This is what I am going to fix with the same idea :)
--
To view, visit http://gerrit.ovi
Mark Wu has posted comments on this change.
Change subject: vdsm: Add tuneBlockDevIo interface
..
Patch Set 13: Code-Review-1
(16 comments)
I am sorry for not pointing out those problems in previous reviews.
.
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 17:
(7 comments)
Ayal,
Thanks a lot for the insightful review! Some problems doesn't exist in the
patch 16, which should be th
Mark Wu has posted comments on this change.
Change subject: Remove vdsm directories on uninstallation
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/16764
To unsubscribe, visit http://gerrit.ovirt.org/set
Mark Wu has posted comments on this change.
Change subject: Added required ipwrapper functions for iproute2 configurator
..
Patch Set 1:
(2 comments)
File lib/vdsm/ipwrapper
Mark Wu has posted comments on this change.
Change subject: Added required ipwrapper functions for iproute2 configurator
..
Patch Set 1: Code-Review-1
(1 comment)
File lib/v
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 18: Code-Review-1
(5 comments)
Besides the comments inline, I would like to suggest implement th
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [3/3] - Restore network
configuration
..
Patch Set 3: Code-Review-1
(4 comments)
Fil
Mark Wu has posted comments on this change.
Change subject: Allow configurators to be used as context managers
..
Patch Set 3: Code-Review+1
(1 comment)
File vdsm/netconf/if
Mark Wu has posted comments on this change.
Change subject: Fix the 'MTU' option in networkTests
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 16:
it can pass all network functional tests.
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://ger
Mark Wu has uploaded a new change for review.
Change subject: Fix the 'MTU' option in networkTests
..
Fix the 'MTU' option in networkTests
The 'mtu' option should be in lower case. It doesn't fail with ifcfg
configurator, becaus
Mark Wu has posted comments on this change.
Change subject: Unified network persistence [3/3] - Restore network
configuration
..
Patch Set 2:
(1 comment)
File vdsm/vdsm-res
Mark Wu has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17491
To unsubscribe, visit http://ger
Mark Wu has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 12: Code-Review+1
(1 comment)
File tests/func
Mark Wu has posted comments on this change.
Change subject: vdsm: Add tuneBlockDevIo interface
..
Patch Set 10: Code-Review-1
(6 comments)
File client/vdsClient.py
Line 1745
Mark Wu has posted comments on this change.
Change subject: tests: setupNetworks add net bond breaking and resizing.
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17634
To unsubscribe, visit http://ge
Mark Wu has posted comments on this change.
Change subject: netconf: enable multiple gateways for iproute2 configurator
..
Patch Set 4:
(1 comment)
File vdsm/sourceRoute.py
Mark Wu has posted comments on this change.
Change subject: netconf: enable multiple gateways for iproute2 configurator
..
Patch Set 4: Code-Review-1
(1 comment)
it misses the interface tracking when removing interface. Then t
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 8:
(7 comments)
Thanks a lot for the review!
File lib/vdsm/ipwrapper.py
L
Mark Wu has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 5:
(3 comments)
Thanks for the good comments!
F
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 7:
(2 comments)
File lib/vdsm/netinfo.py
Line 46: PROC_NET_VLAN = '/proc/n
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 6:
(2 comments)
File lib/vdsm/netinfo.py
Line 46: PROC_NET_VLAN = '/proc/n
Mark Wu has uploaded a new change for review.
Change subject: netconf: Add config option for network configurator
..
netconf: Add config option for network configurator
Change-Id: I426a38f229131ce6d32568387be7a809b09ae0c1
Signed
Mark Wu has posted comments on this change.
Change subject: vdsm: Add tuneBlockDevIo interface
..
Patch Set 9: Code-Review-1
(7 comments)
File vdsm/vm.py
Line 4341:
Mark Wu has posted comments on this change.
Change subject: Introducing hidden_vlans configurable.
..
Patch Set 4:
how about using a unified config, like hidden_interfaces? Then we can add a
unified filter to all devices.
--
Mark Wu has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 10:
(5 comments)
File tests/functional/networ
Mark Wu has posted comments on this change.
Change subject: netmodels: Improve getIpConfig using namedtuple
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18167
To unsubscribe, visit http://gerrit.ovirt.o
Mark Wu has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 10: Code-Review-1
(7 comments)
File tests/fun
Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/13156
To unsubscribe, visit http://gerr
Mark Wu has posted comments on this change.
Change subject: netmodels: Improve getIpConfig using namedtuple
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18167
To unsubscribe, visit http://gerrit.ovirt.o
Mark Wu has posted comments on this change.
Change subject: netconf: Simplify addSourceRoute arguments
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18168
To unsubscribe, visit http://gerrit.ovirt.org/se
Mark Wu has uploaded a new change for review.
Change subject: netmodels: Improve getIpConfig using namedtuple
..
netmodels: Improve getIpConfig using namedtuple
Change-Id: I53eb3c4b00f33285a1b299ca0adc6611eb99a989
Signed-off-by:
Mark Wu has uploaded a new change for review.
Change subject: netconf: Simplify addSourceRoute arguments
..
netconf: Simplify addSourceRoute arguments
Change-Id: I1bf06f865abbed8cf1fdcca909cbf78c6e5f66f4
Signed-off-by: Mark Wu
Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 10:
(3 comments)
File tests/functional/momTest
Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 10: Code-Review-1
(4 comments)
File tests/func
Mark Wu has posted comments on this change.
Change subject: tests: setupNetworks add net bond breaking and resizing.
..
Patch Set 4: Code-Review-1
all the three new added test cases have the code of create network over bond
de
1 - 100 of 970 matches
Mail list logo
