Dan Kenigsberg has submitted this change and it was merged.
Change subject: Supervdsm as external service
..
Supervdsm as external service
Creating supervdsmd and set dependencies between vdsm and supervdsm
services
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16: Looks good to me, approved
my hand is shaking a bit, but I think it's time! thanks!
--
To view, visit http://ger
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11051
To un
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2456/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1625/ (1/3)
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2456/ (3/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 16:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2526/ (2/3)
--
To view, visit http://
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 15: I would prefer that you didn't submit this
(2 inline comments)
minor comments about the functional test.
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2451/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 15:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2521/ (3/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 15:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2451/ (2/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 15:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1620/ (1/3)
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2438/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 14:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2508/ (3/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 14:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2438/ (2/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 14:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1607/ (1/3)
--
To view, visit http
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13: (2 inline comments)
File tests/Makefile.am
Line 55
Line 56
L
Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13: (1 inline comment)
File tests/Makefile.am
Line 55
Line 56
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1591/ (3/3)
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2424/ (1/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2424/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 13:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2493/ (2/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 12: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2421/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 12:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2490/ (3/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 12:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2421/ (1/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 12:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1588/ (2/3)
--
To view, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11: I would prefer that you didn't submit this
(7 inline comments)
mostly minor comments. I like the spirit.
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2416/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1583/ (3/3)
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2416/ (2/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2484/ (1/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2415/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1582/ (3/3)
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2483/ (2/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2415/ (1/3)
--
To view, visit http://gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (2 inline comments)
File vdsm/supervdsmd.init.in
Line 1: #! /
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (1 inline comment)
File vdsm/supervdsmd.init.in
Line 39:
Lin
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (2 inline comments)
File vdsm.spec.in
Line 517: %if 0%{?with_
Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (2 inline comments)
File configure.ac
Line 189: AC_PATH_PRO
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (1 inline comment)
File configure.ac
Line 189: AC_PATH_PROG([
Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (1 inline comment)
File configure.ac
Line 189: AC_PATH_PROG
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (3 inline comments)
File configure.ac
Line 189: AC_PATH_PROG(
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: I would prefer that you didn't submit this
(6 inline comments)
Incomplete review, sorry.
...
Mark Wu has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2297/ : SUCCESS
http://jenkins.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1458/ (3/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2362/ (1/3)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2297/ (2/3)
--
To view, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (1 inline comment)
File vdsm/supervdsm.py
Line 30: _g_singlet
Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (2 inline comments)
File vdsm/supervdsm.py
Line 30: _g_sing
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (1 inline comment)
File vdsm/supervdsmd.init.in
Line 107:
Ohad Basan has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (1 inline comment)
File vdsm/supervdsmd.init.in
Line 107: $
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (8 inline comments)
Thanks for the reviews! Please continue until the feature is ready, it helps a
lot.
I'll upda
Ohad Basan has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (1 inline comment)
File vdsm/supervdsm.py
Line 126:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (3 inline comments)
File vdsm/supervdsmd.init.in
Line 66:
Ohad Basan has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (1 inline comment)
File vdsm/supervdsmd.init.in
Line 107: $
Mark Wu has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8: (3 inline comments)
File vdsm/supervdsm.py
Line 31:
Line 32:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2261/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2261/ (1/3)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1361/ (3/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2200/ (2/3)
--
To view, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2199/ (1/3)
--
To view, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2260/ (3/3)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1360/ (2/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2256/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2256/ (2/3)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1356/ (1/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2195/ (3/3)
--
To view, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2101/ : SUCCESS
http://jenkins.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2161/ (2/2)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2101/ (1/2)
--
To view, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 4: (2 inline comments)
File vdsm/supervdsm.py
Line 121:
Line 12
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 4: Verified
works much better than before.
still working on restart supervdsmd service by using vdsm-tool
(http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2056/ : SUCCESS
http://jenkins.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2056/ (1/2)
--
To view, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2114/ (2/2)
--
To view, visit http://g
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 3: Verified
"""While we at it... I've done major cleanup to the engine service, so maybe
you would like to take some
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2043/ : SUCCESS
http://jenkins.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2101/ (2/2)
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2: (1 inline comment)
Nice! this is the right solution, I am glad we reached that conclusion...
While we at it... I've
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2100/ : FAILURE
http://jenkins.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2100/ (2/2)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2043/ (1/2)
--
To view, visit http://gerrit.
85 matches
Mail list logo
