Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Using pkgutil instead of redundant private funcs in configurator
Change-Id: Iec710e795aeaf5
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, vi
Dan Kenigsberg has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/53214/2/lib/vdsm/tool/c
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, vi
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/3/tests/toolTests.py
File tes
Dan Kenigsberg has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53214/3/lib/vdsm/tool/c
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in
configurator added dynamic module import module to be used wherever modules are
loaded to avoid code duplication also changed relative imports to absolute
imports as importlib ca
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
Jenkins CI has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 7: Continuous-Integration-1
Propagate review hook: Continuous Integration value inheri
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 7: Code-Review-1
(10 comments)
https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py
File
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py
File li
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py
File
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py
Fil
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 10:
(6 comments)
https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py
File
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool/configurato
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 11: Code-Review-1
please remove redundant newline. -1 for visibility
--
To view,
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool/configurator.py
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
(3 comments)
except some minor notes its +1
https://gerrit.ovirt.org/#/c/532
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py
Fil
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in
File vdsm.sp
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 14:
(3 comments)
https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15: Verified+1
(6 comments)
https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_l
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15:
(2 comments)
btw, in vdsm-tool/vdsm-tool (the executable) there is another us
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/15/vdsm.spec.in
File vdsm.spec
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/c
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15:
(5 comments)
https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/configurator.p
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/18/tests/Makefile.am
File test
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/20/lib/vdsm/tool/configurator.py
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/20/lib/vdsm/tool/configurator.py
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, v
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, vis
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 23:
the error is not related to the patch - we should fix the usage in
NOSE_COVER
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 23:
sorry, does not exist in python-nose 1.3.0 that we have in epel7 ..
--
To vi
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 25: Verified+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, v
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Nir Soffer has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/27/lib/vdsm/module_loader.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 27: Code-Review-1
please address nir's comment.. its nicer
--
To view, visit htt
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/27/lib/vdsm/module_loader.py
Fil
Nir Soffer has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/28/lib/vdsm/Makefile.am
File lib/v
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/28/lib/vdsm/Makefile.am
File lib
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 30: Code-Review+1 Verified+1
copying score after rebase
--
To view, visit https:
Dan Kenigsberg has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 30: Code-Review+2
rebase
--
To view, visit https://gerrit.ovirt.org/53214
To uns
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Using pkgutil instead of redundant private funcs in configurator
Added dynamic modu
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url fo
75 matches
Mail list logo
