Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10: Code-Review-1
so sorry:
CONFLICT (content): Merge conflict in lib/vdsm/config.py.in
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 11: Verified+1
Rebase only, no code changes. Copying verification flag from previous patch set.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 12: Code-Review+2
copying score
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 12: Verified+1
Rebase glitch in previous patch. Copying verification flag.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/10/vdsm/rpc/bindingjsonrpc.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/10/vdsm/rpc/bindingjsonrpc.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 8: Code-Review+1
we add a bit of state to clientIF, but this seems a necessary evil.
Overall I like this
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 8: Verified+1
Verified by host deploying and seeing that communication works.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 8: Code-Review+1
Lets get Francesco opinion.
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7: Code-Review-1
(1 comment)
-1 for visibility
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 6: Verified+1
Verified by host deploying vdsm and seeing that there are no issues with
communication.
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4: Code-Review-1
Need to update config.py.in.
--
To view, visit https://gerrit.ovirt.org/43759
To
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
Will fix Nir's comments
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
Seems fine once Nir's comments in v2 are addressed
--
To view, visit https://gerrit.ovirt.org/43759
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py
File
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/1/vdsm/rpc/bindingjsonrpc.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py
File
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/1/vdsm/rpc/bindingjsonrpc.py
File
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/1/vdsm/rpc/bindingjsonrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2: Verified+1
Fixed comments. Patch split into 2. Verified by installing new host and adding
NFS storage
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py
File
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/43759/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/1/vdsm/rpc/bindingjsonrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
(8 comments)
https://gerrit.ovirt.org/#/c/43759/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1: Verified+1
Verified by using the latest engine and vdsm. Steps include:
installing new host,
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we introduce
45 matches
Mail list logo
