Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 35: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-25 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: v2v: externalVMList Xen+Kvm support .. v2v: externalVMList Xen+Kvm support Not all new methods are supported in older version of libvirt under RHEL 5.x-7.x

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-25 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 34: Code-Review+2 very nice job Shahar! -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, vi

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-24 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 34: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-24 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 34: Code-Review+1 Waiting for Francesco approval. -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 34: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 33: (1 comment) Nice, one little can is missing for the new code. https://gerrit.ovirt.org/#/c/48672/33/vdsm/v2v.

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-21 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 33: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-20 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (2 comments) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 80:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: Code-Review-1 (2 comments) few tests are missing. Codewise looks good. https://gerrit.ovirt.org/#/c/486

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 31: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 30: (10 comments) https://gerrit.ovirt.org/#/c/48672/30/tests/v2vTests.py File tests/v2vTests.py: Line 191 Line 1

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 30: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/48672/27/tests/v2vTests.py File tests/v2vTests.py: Line 62 Line 63 L

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 28: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (5 comments) https://gerrit.ovirt.org/#/c/48672/27/tests/v2vTests.py File tests/v2vTests.py: Line 62 Line

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/48672/27/tests/v2vTests.py File tests/v2vTests.py: Line 109 Line 110

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (2 comments) https://gerrit.ovirt.org/#/c/48672/27/tests/v2vTests.py File tests/v2vTests.py: Line 51 Line

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/48672/27/tests/v2vTests.py File tests/v2vTests.py: Line 51 Line 5

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/48672/27/vdsm/v2v.py File vdsm/v2v.py: Line 659:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: Code-Review-1 (7 comments) The current mocks are too messed up to add new features. Please send another patch

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/48672/27/vdsm/v2v.py File vdsm/v2v.py: Line 659: log

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 27: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-07 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 26: (1 comment) https://gerrit.ovirt.org/#/c/48672/26/tests/v2vTests.py File tests/v2vTests.py: Line 130:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 26: (2 comments) https://gerrit.ovirt.org/#/c/48672/26/tests/v2vTests.py File tests/v2vTests.py: Line 130: de

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 26: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/48672/25/tests/v2vTests.py File tests/v2vTests.py: Line 133:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/48672/25/tests/v2vTests.py File tests/v2vTests.py: Line 133:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 25: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48672/25/vdsm/v2v.py File vdsm/v2v.py: Line 646:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/48672/25/tests/v2vTests.py File tests/v2vTests.py: Line 133:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 24: (2 comments) https://gerrit.ovirt.org/#/c/48672/24/tests/v2vTests.py File tests/v2vTests.py: Line 134:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 24: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-06 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/48672/23/tests/v2vTests.py File tests/v2vTests.py: Line 132:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2016-01-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: Code-Review-1 (1 comment) Looks fine except for one point: please avoid raising strings as exception. S

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: -Verified -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: Code-Review+1 Looks good to me, waiting for Francesco review. -- To view, visit https://gerrit.ovirt.org/4867

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-27 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-27 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/48672/22/vdsm/v2v.py File vdsm/v2v.py: Line 638: try: Line 63

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-24 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 22: (3 comments) https://gerrit.ovirt.org/#/c/48672/22/vdsm/v2v.py File vdsm/v2v.py: Line 636: Line 637: def _li

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 22: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-24 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/48672/21/vdsm/v2v.py File vdsm/v2v.py: Line 667: params = {} Lin

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-24 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 21: (3 comments) https://gerrit.ovirt.org/#/c/48672/21/vdsm/v2v.py File vdsm/v2v.py: Line 667: params = {}

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 21: (5 comments) https://gerrit.ovirt.org/#/c/48672/21/vdsm/v2v.py File vdsm/v2v.py: Line 648: for name i

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-23 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/48672/20/vdsm/v2v.py File vdsm/v2v.py: Line 648: for nam

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/48672/20/vdsm/v2v.py File vdsm/v2v.py: Line 648: for name i

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 20: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/48672/17/vdsm/v2v.py File vdsm/v2v.py: Line 646: raise L

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/48672/17/vdsm/v2v.py File vdsm/v2v.py: Line 647: seen = set

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Code-Review-1 (2 comments) Fake libvirt connection looks wrong. https://gerrit.ovirt.org/#/c/48672/17/tests/v

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Verified with Xen, KVM and vCenter hypervisors -- To view, visit https://gerrit.ovirt.org/48672 To unsubsc

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-13 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: Code-Review+2 seems OK, but I have this feeling I seen some similar changes elsewhere :\ Maybe I'm just

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-09 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/48672/16/vdsm/v2v.py File vdsm/v2v.py: Line 642: for vm

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 16: Code-Review+1 (2 comments) looks OK, could be improved https://gerrit.ovirt.org/#/c/48672/16/vdsm/v2v.p

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py File vdsm/v2v.py: Line 657: con

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py File vdsm/v2v.py: Line 647: if e.ge

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py File vdsm/v2v.

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py File vdsm/v2v.py: Line 657:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: Francesco? -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/48672/13//COMMIT_MSG Commit Message: Line 11: We want to use one

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 13: Code-Review+1 (4 comments) Please fix the typos, otherwise fine for me. https://gerrit.ovirt.org/#/c/48672

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/48672/12/vdsm/v2v.py File vdsm/v2v.py: Line 647: if e.ge

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 155: for name

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 155: for name in c

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 154: # u

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 154:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 6: > (1 comment) The different between the old and the new api is: 1. the new return all up and down VMs in one

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/48672/6//COMMIT_MSG Commit Message: Line 9: Not all new methods are s

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48672/5/vdsm/v2v.py File vdsm/v2v.py: Line 699:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-18 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-18 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/s

  1   2   >