Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56836/2//COMMIT_MSG
Commit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: report additional information in 'scsi' device
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56038
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't set connected attribute in if already set
..
virt: Don't set connected attribute in if already set
Currently, we unconditionally set
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Set timeout on boot menu
..
virt: Set timeout on boot menu
The default timeout for boot menu (3 s) is too short for some scenarios,
e.g. with network
Milan Zamazal has posted comments on this change.
Change subject: tests/functional: Remove storage tests references from virtTests
..
Patch Set 2: Verified+1
> Few leftovers spotted.
Removed, thanks for pointing this out.
--
Milan Zamazal has posted comments on this change.
Change subject: migration: validate progress fields from libvirt
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56378/2//COMMIT_MSG
Commit Message:
Line 12: use
Milan Zamazal has posted comments on this change.
Change subject: travis: Add missing packages to Dockerfile
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55738
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55949/1/build-aux/Makefile.subs
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 3: Verified+1
Verified by enabling boot menu and checking the menu prompt remains on the VM
startup for about the
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56393/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS2, Line
Milan Zamazal has posted comments on this change.
Change subject: vm: rename event for clarity
..
Patch Set 1: Code-Review+1
Good idea.
--
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56188
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: validate progress fields from libvirt
..
Patch Set 4: Code-Review+1
Fine, I just still suggest adding a notice to the commit message why we need to
Milan Zamazal has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56313
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: schema: yml: sync existingConnAction with json
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57235/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Milan Zamazal has posted comments on this change.
Change subject: schema: yml: sync existingConnAction with json
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57235
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Verified+1
Verified that DEBUG messages are no longer present in the log and the higher
level messages are
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 7: Code-Review+1
(4 comments)
It looks fine to me, I just suggest improving the commit message.
Milan Zamazal has posted comments on this change.
Change subject: jsonrpc: Log RPC call arguments
..
Patch Set 1:
Proof of the concept. Let's see how it works.
--
To view, visit https://gerrit.ovirt.org/60572
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/57754/20/tests/executorTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG
Commit Message:
Line 33:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/61603/2/static/Makefile.am
File static/Makefile.am:
Line 39:
Milan Zamazal has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61601/1/static/Makefile.am
File static/Makefile.am:
Milan Zamazal has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61631
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: configs: move mom
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61602/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-07-28
Milan Zamazal has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 2: Code-Review+1
Thanks for handling this problem.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: configs: introduce static dir
..
Patch Set 1: Code-Review+1
I'm not sure `static' is a good name, otherwise OK.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61685/2/tests/periodicTests.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix of Executor._active_workers crash on modification
Executor._active_workers doesn't use
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61690/1/lib/vdsm/executor.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Verified+1
Verified by running ExecutorTests.test_discarded_workers (where this bug
Milan Zamazal has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 8:
> Commit message was updated.
It's better now, thanks!
--
To view, visit https://gerrit.ovirt.org/61310
Milan Zamazal has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG
Commit Message:
Line 7: virt:
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/5/README.logging
File README.logging:
Line 23:
Milan Zamazal has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61770
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: vmdisk hook: add support for booting from image file
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58748
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 1: Code-Review-1
(1 comment)
-1 for visibility: Just a documentation issue to avoid future mistakes
Milan Zamazal has posted comments on this change.
Change subject: vm: drop legacy device config support
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60326
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60322
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60320
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57958
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58011
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57956
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57963
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57960
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/60639/4/lib/vdsm/utils.py
File
Milan Zamazal has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61106/2//COMMIT_MSG
Commit Message:
Line 6:
Milan Zamazal has uploaded a new change for review.
Change subject: tests: Set vars/ssl to true in graphics tests
..
tests: Set vars/ssl to true in graphics tests
In 8a7479c, support for graphics defaultMode was added and
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log calls of API methods with possibly large results
..
Patch Set 1: Verified+1
Verified that getAllVmStats is logged now, with suppressed result.
--
To
Milan Zamazal has posted comments on this change.
Change subject: rpc: Lower logging priority just for getAllVmStats
..
Patch Set 1: Verified+1
Verified that getAllVmStats is still not logged.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: Set vars/ssl to true in graphics tests
..
Patch Set 2:
Yes, Jenkins verification + my verification that the change indeed fixes the
problem described in
Milan Zamazal has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1: Verified+1
Verified that
vdsClient localhost fenceNode 192.168.121.102 54321 drac5 gozo foobar
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 1: Verified+1
Verified that (suppressed) is still logged as getAllVmStats response and
Milan Zamazal has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in vmdevices/common.py
..
Patch Set 5:
Sure, I'll check test coverage and add what's missing once reviewers are
basically satisfied
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1: Verified+1
Verified that expected getAllVmStats info is logged at expected interval.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: Introduce throttledlog
..
Patch Set 1: Verified+1
Verified by running tests.
--
To view, visit https://gerrit.ovirt.org/60100
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log RPC call summary on info level
..
Patch Set 2: Verified+1
Verified that RPC calls are logged as expected.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log also error codes of RPC calls
..
Patch Set 2: Verified+1
Verified that the error codes are logged as expected.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 2:
Probably a good idea, better than the class name check. Done.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 2: Verified+1
Verified as previously.
--
To view, visit https://gerrit.ovirt.org/60099
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 2: Verified+1
Verified as previously.
--
To view, visit https://gerrit.ovirt.org/60101
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: vmdisk hook: add support for booting from image file
..
Patch Set 6:
Dmitry, would you like to clarify (in README or here) the ordering requirement?
Should
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 3: Verified+1
Tests updated after moving code from logUtils.py to utils.py.
No runtime code change, so
Milan Zamazal has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in storage devices
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/56102/6/vdsm/virt/vmdevices/storage.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm disk device handling
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56108/6/vdsm/virt/domain_descriptor.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56107/6/vdsm/virt/vm.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Return first child from vmxml.xml_to_dom
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/58194/5//COMMIT_MSG
Commit Message:
PS5, Line 9:
Milan Zamazal has posted comments on this change.
Change subject: virt: Switch to etree in vmxml.py
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/58196/5/tests/deviceTests.py
File tests/deviceTests.py:
PS5, Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Introduce MutableDomainDescriptor
..
Patch Set 1:
Tests and documentation will be added once the patch is basically OK to
reviewers.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm.setLinkAndNetwork
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/58190/5/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60323
To unsubscribe, visit
Milan Zamazal has abandoned this change.
Change subject: api: Move after_get_all_vm_stats hook from API to clientIF
..
Abandoned
Abandoned in favor of https://gerrit.ovirt.org/60583
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4:
Great, thanks. Would you like to check also places in deviceTests.py where
isLegacy is used?
Milan Zamazal has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Verified+1
Verified by running `make check' in a Vdsm tree with .ropeproject and checking
that it
Milan Zamazal has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60608
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 3:
(1 comment)
There are some tests in deviceTests and functional virtTests mentioning legacy
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4: Code-Review+1
I see, it's removed in the followup patches.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: doc: Typo fixes and other doc improvements in periodic.py
..
Patch Set 2: Verified+1
Documentation only changes, so Jenkins is enough.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 7:
I like this idea.
--
To view, visit https://gerrit.ovirt.org/57963
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: client: use representation object
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: client: use representation object
..
Patch Set 2: Verified+1
Verified that together with https://gerrit.ovirt.org/#/c/59720/3 migrations
work for me on master
Milan Zamazal has posted comments on this change.
Change subject: vm: Introduce drive monitoring concept
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59765
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: Avoid useless drive monitoring
..
Patch Set 2: Code-Review+1
(1 comment)
Looks like a good idea to me.
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 28: Verified+1
Just rebased.
Verified at the end of the patch series that everything works as expected after
Milan Zamazal has posted comments on this change.
Change subject: virt: Improve thread safety of discarding executor workers
..
Patch Set 11:
> Can you rebase this on master?
Done.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Improve thread safety of discarding executor workers
..
Patch Set 11: Verified+1
Verified by:
- Running `make check-all' and checking that the reported
501 - 600 of 805 matches
Mail list logo
