Re: Odd behavior of vim 8.0.1203 in a wide xterm -- solution found

2017-11-02 Fir de Conversatie Gary Johnson
On 2017-11-02, Gary Johnson wrote: > So the funny behavior does seem related to the old addressing > style, but why is it happening on an xterm-318 with 'ttymouse' > automatically set to "sgr"? I tried finding the problem by bisecting the repository and found that my build of 7.4.160 failed,

Re: [doc][patch] Update documents

2017-11-02 Fir de Conversatie Ken Takata
Hi Bram, 2017/10/28 Sat 4:19:49 UTC+9 Bram Moolenaar wrote: > Ken Takata wrote: > > > The following help items describe similar things: > > > > :help gui-w32-cmdargs > > :help win32-quotes > > > > I think they can be merged. Moreover, they doesn't reflect the change by > > the patch

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Marvin Renich
* Christian Brabandt [171102 16:50]: > > On Do, 02 Nov 2017, z...@z5t1.com wrote: > > > > > However, there is another problem with the swap file permissions > > that has not yet been discussed: when Vim creates swap files, the > > .swp file is created with the owner and

Re: Odd behavior of vim 8.0.1203 in a wide xterm

2017-11-02 Fir de Conversatie Gary Johnson
Yet another experiment: This Linux distribution comes with vim 7.4.160 in /usr/bin/vim, so I repeated the experiments I tried before and it worked just fine in all cases. So the problem is with vim, not its environment, and it was introduced sometime between 7.4.160 and 8.0.1203. Regards, Gary

Re: Odd behavior of vim 8.0.1203 in a wide xterm

2017-11-02 Fir de Conversatie Gary Johnson
I tried another experiment. This time I just opened vim with a single window and filled a couple of lines with text. Then I used the mouse to position the cursor. I could move the cursor as far right as column 223, but moving the mouse pointer any further to the right and clicking the mouse

Re: Odd behavior of vim 8.0.1203 in a wide xterm

2017-11-02 Fir de Conversatie Gary Johnson
On 2017-11-02, James McCoy wrote: > On Thu, Nov 02, 2017 at 04:03:32PM -0700, Gary Johnson wrote: > > I opened an xterm and dragged it to the full width of my two > > monitors. > > > > $ echo $LINES $COLUMNS > > 50 370 > > Vim must not be detecting that your terminal can support newer

Re: Odd behavior of vim 8.0.1203 in a wide xterm

2017-11-02 Fir de Conversatie James McCoy
On Thu, Nov 02, 2017 at 04:03:32PM -0700, Gary Johnson wrote: > I opened an xterm and dragged it to the full width of my two > monitors. > > $ echo $LINES $COLUMNS > 50 370 Vim must not be detecting that your terminal can support newer mouse addressing modes like urxvt or sgr. See :help

Odd behavior of vim 8.0.1203 in a wide xterm

2017-11-02 Fir de Conversatie Gary Johnson
I opened an xterm and dragged it to the full width of my two monitors. $ echo $LINES $COLUMNS 50 370 Then I opened vim with four vertical windows: $ vim -N -u NONE -i NONE -O4 -c 'set mouse=a' There are several problems with the resulting display. Problem 1: I cannot drag the

Patch 8.0.1257

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1257 (after 8.0.1254) Problem:No test for fix of undefined behavior. Solution: Add a test. (closes #2255) Files: src/testdir/test_search.vim *** ../vim-8.0.1256/src/testdir/test_search.vim 2017-11-02 19:08:39.741514601 +0100 --- src/testdir/test_search.vim 2017-11-02

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Z5T1
Thank you Christian; I'm tweaking my configuration as you suggested. On 11/02/17 16:50, Christian Brabandt wrote: > > What is with files that are edited by several users possibly at the same > time? They won't get a warning message now. I thought about this. As I said, my fix has some issues.

Patch 8.0.1256

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1256 Problem:Typo in configure variable vim_cv_tgent. (Matthieu Guillard) Solution: Rename the variable. (closes #2281) Files: src/configure.ac, src/auto/configure *** ../vim-8.0.1255/src/configure.ac2017-10-28 21:08:38.975457036 +0200 --- src/configure.ac2017-11-02

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Bram Moolenaar
z5t1 (???) wrote: > Hi, I'd like to add my two cents to this. > > I have reproduced this on Centos 6 and Cucumber Linux 1.0. We have > established that the umask plays no role in the permissions on swap files; > Vim creates its swap files with the same permissions as the file being edited. >

Re: Patch 8.0.1248

2017-11-02 Fir de Conversatie Bram Moolenaar
Dominique wrote: > > Patch 8.0.1248 (after 8.0.1247) > > Problem:Stray + in README file. > > Solution: Remove the +. Add a line break. > > Files: README.md > > > The debian badge was put twice somehow in README.md > Sorry about that. Fixed in attached patch. I also missed it. --

Patch 8.0.1255

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1255 (after 8.0.1248) Problem:duplicate badge README file. Solution: Remove one. (Dominique Pelle) Files: README.md *** ../vim-8.0.1254/README.md 2017-11-02 18:12:56.097119507 +0100 --- README.md 2017-11-02 22:37:01.921530987 +0100 *** *** 5,11

Patch 8.0.1254

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1254 Problem:Undefined left shift in gethexchrs(). (geeknik) Solution: Use unsigned long. (idea by Christian Brabandt, closes #2255) Files: src/regexp.c, src/regexp_nfa.c *** ../vim-8.0.1253/src/regexp.c2017-10-24 21:49:32.234837736 +0200 --- src/regexp.c

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Christian Brabandt
On Do, 02 Nov 2017, z...@z5t1.com wrote: > > However, there is another problem with the swap file permissions that has not > yet been discussed: when Vim creates swap files, the .swp file is created > with the owner and group set to the user who is editing the file (hereafter > referred to

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie z5t1
On Thursday, November 2, 2017 at 9:09:49 AM UTC-4, Bram Moolenaar wrote: > Ken Takata wrote: > > > 2017/11/1 Wed 6:20:27 UTC+9 Bram Moolenaar wrote: > > > Hanno Böck wrote: > > > > > > > I wanted to point out an issue here with vim swap files that make them > > > > a security problem. > > > > >

Patch 8.0.1253

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1253 Problem:Still too many old style tests. Solution: Convert a few more tests to new style. (Yegappan Lakshmanan, closes #2272) Files: src/Makefile, src/testdir/Make_all.mak, src/testdir/Make_amiga.mak, src/testdir/Make_dos.mak,

Re: Patch 8.0.1248

2017-11-02 Fir de Conversatie Dominique Pellé
Bram Moolenaar wrote: > > Patch 8.0.1248 (after 8.0.1247) > Problem:Stray + in README file. > Solution: Remove the +. Add a line break. > Files: README.md The debian badge was put twice somehow in README.md Sorry about that. Fixed in attached patch. Regards

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Marvin Renich
* zdoh...@redhat.com [171102 10:36]: > can VIm provide a way how to set permissions for swap files? So users > which consider this VIm behavior as security risk can set permissions > differently? Would that be possible for VIm (like setting set > swap_file_perm=775 in vimrc

Re: [patch] Update makefiles in src/po/

2017-11-02 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > There are some problems in src/po/Make_*.mak. > > * Make_ming.mak doesn't work well when it is executed on msys2's bash. > * Some source files are missing from the makefiles. > > Attached patches fix them. Thanks! -- Men may not be seen publicly in any kind of strapless

Patch 8.0.1252

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1252 Problem:Incomplete translations makefile for MinGW/Cygwin. Solution: Add missing source files. Make it work with msys2's bash. (Ken Takata) Files: src/po/Make_cyg.mak, src/po/Make_ming.mak, src/po/Make_mvc.mak *** ../vim-8.0.1251/src/po/Make_cyg.mak

Patch 8.0.1251

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1251 (after 8.0.1249) Problem:Invalid expressin passed to WaitFor(). Solution: Check if the variable exists. Files: src/testdir/test_clientserver.vim *** ../vim-8.0.1250/src/testdir/test_clientserver.vim 2017-09-09 18:10:56.707952547 +0200 ---

Patch 8.0.1250

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1250 Problem:'hlsearch' highlighting not removed after incsearch (lacygoill) Solution: Redraw all windows. Start search at the end of the match. Improve how CTRL-G works with incremental search. Add tests. (Christian Brabandt, Hirohito Higashi, haya14busa,

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Matěj Cepl
On 2017-11-02, 11:16 GMT, Dominique Pellé wrote: > For Fedora, I see this link: > https://koji.fedoraproject.org/koji/buildinfo?buildID=992971 > … but it only seems to have compilation logs, not test logs > which it less useful than the debian page. Testsuite is not run while building Fedora/RHEL

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Matěj Cepl
On 2017-11-02, 11:16 GMT, Dominique Pellé wrote: > For Fedora, I see this link: > https://koji.fedoraproject.org/koji/buildinfo?buildID=992971 > ... but it only seems to have compilation logs, not test logs > which it less useful than the debian page. I can also do build on the internal systems

Patch 8.0.1249

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1249 Problem:No error when WaitFor() gets an invalid wrong expression. Solution: Do not ignore errors in evaluationg the expression. Fix places where the expression was wrong. Files: src/testdir/shared.vim, src/testdir/test_netbeans.vim ***

Patch 8.0.1248

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1248 (after 8.0.1247) Problem:Stray + in README file. Solution: Remove the +. Add a line break. Files: README.md *** ../vim-8.0.1247/README.md 2017-11-02 18:09:55.898177904 +0100 --- README.md 2017-11-02 18:11:31.889614167 +0100 *** *** 1,10

Patch 8.0.1247

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1247 Problem:Not easy to find Debian build info. Solution: Add a badge in the README file. (Dominique Pelle) Files: README.md *** ../vim-8.0.1246/README.md 2017-03-25 18:10:26.867248943 +0100 --- README.md 2017-11-02 18:07:28.403043806 +0100 *** *** 4,9

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Bram Moolenaar
Dominique wrote: > I see that the neovim github page has a > debian CI badge. See: > https://github.com/neovim/neovim > > How about adding a similar badge in the vim > github page? I attach a patch to do that (not tested) > which links to: > https://buildd.debian.org/status/package.php?p=vim >

Patch 8.0.1246

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1246 Problem:Popup test has an arbitrary delay. Solution: Wait for the ruler to show. (James McCoy) Files: src/testdir/test_popup.vim *** ../vim-8.0.1245/src/testdir/test_popup.vim 2017-10-31 22:19:54.732086180 +0100 --- src/testdir/test_popup.vim 2017-11-02

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Christian Brabandt
On Mi, 01 Nov 2017, Ken Takata wrote: > This makes Vim to respect umask when creating a swapfile. > (I'm not sure this is actually needed, though.) I am also not sure if this is needed. However it makes sense to have the swap file with the same permissions of the original file. Think of a

Re: Patch 8.0.1241

2017-11-02 Fir de Conversatie Bram Moolenaar
James McCoy wrote: > On Wed, Nov 01, 2017 at 09:22:45PM +0100, Bram Moolenaar wrote: > > That's defenitely better than an arbitrary delay. However, I think your > > check just never matches and causes a delay of one second. > > That's surprising that WaitFor() silently fails, but you are

Re: Patch 8.0.1238

2017-11-02 Fir de Conversatie Christian Brabandt
On Do, 02 Nov 2017, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > On Di, 31 Okt 2017, Christian Brabandt wrote: > > > > > > > > On So, 29 Okt 2017, Bram Moolenaar wrote: > > > > > > > Patch 8.0.1238 > > > > Problem:Incremental search only shows one match. > > > > Solution:

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Matěj Cepl
On 2017-11-02, 11:16 GMT, Dominique Pellé wrote: > I don't think it's silly. It helps to find bugs in Vim on > platforms that are rarely used. I was not aware of vim crashes > on alpha or hurd x86 until I saw those debian test logs of > vim-8.0.1241. If someone has the time they could be >

Patch 8.0.1245

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1245 Problem:When WaitFor() has a wrong expression it just waits a second, which goes unnoticed. (James McCoy) Solution: When WaitFor() times out throw an exception. Fix places where the expression was wrong. Files: src/testdir/shared.vim,

Re: Patch 8.0.1238

2017-11-02 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Di, 31 Okt 2017, Christian Brabandt wrote: > > > > > On So, 29 Okt 2017, Bram Moolenaar wrote: > > > > > Patch 8.0.1238 > > > Problem:Incremental search only shows one match. > > > Solution: When 'incsearch' and and 'hlsearch' are both set highlight all >

Patch 8.0.1244

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1244 Problem:Search test does not work correctly on MS-Windows. Solution: Put text in a file instead of sending it to the terminal. (Christian Brabandt) Files: src/testdir/test_search.vim *** ../vim-8.0.1243/src/testdir/test_search.vim 2017-11-02

Re: Patch 8.0.1227

2017-11-02 Fir de Conversatie Christian Brabandt
On Do, 02 Nov 2017, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > On So, 29 Okt 2017, Christian Brabandt wrote: > > > > > On Sa, 28 Okt 2017, Bram Moolenaar wrote: > > > > Feel free to make one. > > > > > > I kind of knew that this answer would come :) > > > > > > Okay, will

Patch 8.0.1243

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1243 Problem:No test for what 8.0.1227 fixes. Solution: Add a test that triggers the problem. (Christian Brabandt) Files: src/testdir/test_normal.vim, src/testdir/test_search.vim *** ../vim-8.0.1242/src/testdir/test_normal.vim 2017-10-15 22:07:35.211683156 +0200 ---

Re: Patch 8.0.1227

2017-11-02 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On So, 29 Okt 2017, Christian Brabandt wrote: > > > On Sa, 28 Okt 2017, Bram Moolenaar wrote: > > > Feel free to make one. > > > > I kind of knew that this answer would come :) > > > > Okay, will look into that one and the other undefined behaviour patches. > >

Patch 8.0.1242

2017-11-02 Fir de Conversatie Bram Moolenaar
Patch 8.0.1242 Problem:Function argument with only dash is seen as number zero. (Wang Shidong) Solution: See a dash as a string. (Christian Brabandt) Files: src/testdir/test_ins_complete.vim, src/Makefile, src/eval.c *** ../vim-8.0.1241/src/testdir/test_ins_complete.vim

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie zdohnal
Hi Bram, can VIm provide a way how to set permissions for swap files? So users which consider this VIm behavior as security risk can set permissions differently? Would that be possible for VIm (like setting set swap_file_perm=775 in vimrc file)? -- -- You received this message from the

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Tony Mechelynck
Well, if you decide to add more links for other distros, openSUSE does distribute a Vim package (at the moment at version 7.4.326 without, for some reason, patch 7.4.208). Bugs are reported via https://bugzilla.opensuse.org in Product "openSUSE Distribution" and, AFAICT, component "Other". But I

Re: Security risk of vim swap files

2017-11-02 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2017/11/1 Wed 6:20:27 UTC+9 Bram Moolenaar wrote: > > Hanno Böck wrote: > > > > > I wanted to point out an issue here with vim swap files that make them > > > a security problem. > > > > > > By default vim creates a file with the name .filename.swp in the same > > >

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie James McCoy
On Thu, Nov 02, 2017 at 06:40:35AM +0100, Dominique Pellé wrote: > Debian builds on many platforms which is useful > to have a look at. It's currently using vim-8.0.1226. > Glancing at those builds logs, I see: > > - failures in Test_popup_and_window_resize() on at least mips > hppa, and

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Dominique Pellé
Matěj Cepl wrote: > On 2017-11-02, 05:40 GMT, Dominique Pellé wrote: >> I see that the neovim github page has a >> debian CI badge. See: >> https://github.com/neovim/neovim > > That seems like pretty silly thing to do (speaking me as user of > Fedora/RHEL). Should vim carry some

Re: [patch] added debian build badge

2017-11-02 Fir de Conversatie Matěj Cepl
On 2017-11-02, 05:40 GMT, Dominique Pellé wrote: > I see that the neovim github page has a > debian CI badge. See: > https://github.com/neovim/neovim That seems like pretty silly thing to do (speaking me as user of Fedora/RHEL). Should vim carry some kind of badges for all (how many it is?)

Re: [vim/vim] 'set showcmd' messes up mappings when the {rhs} is longer than the screen width (#2268)

2017-11-02 Fir de Conversatie Christian Brabandt
On Do, 02 Nov 2017, Tony Mechelynck wrote: > On Thu, Nov 2, 2017 at 9:54 AM, Christian Brabandt > wrote: > > Okay, could finally reproduce it. This is really a subtle bug popping up. > > This happens, because when executing your function, the command will be put > >

Re: [vim/vim] 'set showcmd' messes up mappings when the {rhs} is longer than the screen width (#2268)

2017-11-02 Fir de Conversatie Tony Mechelynck
On Thu, Nov 2, 2017 at 9:54 AM, Christian Brabandt wrote: > Okay, could finally reproduce it. This is really a subtle bug popping up. > This happens, because when executing your function, the command will be put > on the commandline, which causes a scroll. Vim then