Re: awk indentation

2011-11-14 Fir de Conversatie erik
                                                *local-variable* *l:var* Inside functions local variables are accessed without prepending anything. But you can also prepend l: if you like.  However, without prepending l: you may run into reserved variable names.  For example count.  By

Re: awk indentation

2011-11-12 Fir de Conversatie Thilo Six
Peter Odding wrote the following on 12.11.2011 16:25 Hello Peter, It would also be nice if the script would either 'unlet' the variables again, or limit their scope ':h internal-variables'. See attached patch as example. I thought variables inside functions were implicitly in function

Re: awk indentation

2011-11-11 Fir de Conversatie erik
Jakson, Thanks for pointing that one out again. I have applied your patch Erik. On 10 nov, 01:53, Jakson Alves de Aquino jalve...@gmail.com wrote: On Wed, Oct 26, 2011 at 5:19 PM, erik ejans...@itmatters.nl wrote: New version on the same location:http://dl.dropbox.com/u/26176183/awk.vim

Re: awk indentation

2011-11-09 Fir de Conversatie erik
I'm so sorry, but I just could not find the time to test. No problem! I have been doing other things too. Searching the net for 'awk' and 'vim' surfaces some unhappiness though, and it feels a bit I did that... so now that I finally have a good-enough fix I want it out Erik. -- You

Re: awk indentation

2011-11-09 Fir de Conversatie Jakson Alves de Aquino
On Wed, Oct 26, 2011 at 5:19 PM, erik ejans...@itmatters.nl wrote: New version on the same location: http://dl.dropbox.com/u/26176183/awk.vim The attached patch fix a minor bug in the script. -- Jakson -- You received this message from the vim_dev maillist. Do not top-post! Type your reply

Re: awk indentation

2011-11-08 Fir de Conversatie Zvezdan Petkovic
On Nov 7, 2011, at 5:05 PM, erik wrote: Though I lack feedback on the final version ... Eric, I'm so sorry, but I just could not find the time to test. I promise, as soon as I get some free time, I'll look into it. It may take another week or two. Zvezdan -- You received this

Re: awk indentation

2011-11-07 Fir de Conversatie erik
Bram, Though I lack feedback on the final version I think the indenter is now worth committing How should I proceed, I find no info on vim.org (or I am overlooking it like indent errors :( ) Erik. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below

Re: awk indentation

2011-10-26 Fir de Conversatie erik
New version on the same location: http://dl.dropbox.com/u/26176183/awk.vim I fixed the issues you mentioned as well as the fact that the indenter ignored else if (if it worked before it was accidental) And the code gets smaller every update, I assume that is a good sign Greetz Erik -- You

Re: awk indentation

2011-10-25 Fir de Conversatie erik
You're quick. Consider a career as beta tester :) I don't need to look in the code to confirm this is indeed the case. I'll extend my testcases and rework. be patient. Erik. On 25 okt, 07:10, Zvezdan Petkovic zpetko...@acm.org wrote: On Oct 24, 2011, at 6:06 PM, erik wrote: Can you have a

Re: awk indentation

2011-10-24 Fir de Conversatie erik
All, Finally had time to look at it again. I put an updated version here: http://dl.dropbox.com/u/26176183/awk.vim Sorry it took so long, it took me three evenings to fix and I don't have many for the purpose. Still tidying up to do but imho it indents correctly all the code I have now,

Re: awk indentation

2011-10-24 Fir de Conversatie Zvezdan Petkovic
On Oct 24, 2011, at 6:06 PM, erik wrote: Can you have a look again. Let's see what surprises will pop up. The indent now works perfectly on several of my large scripts including the one I sent you. The only difference is the alignment of continuation lines in the original. I personally

Re: awk indentation

2011-10-12 Fir de Conversatie erik
Does it never stop... :) Thanks Zvezdan and Jakson for supplying all the reference code Schedule doesn't really permit all the work, so it'll be silent again for at least a week. I'll be back Erik. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below

Re: awk indentation

2011-10-12 Fir de Conversatie Donald Allen
On Wed, Oct 12, 2011 at 3:22 PM, erik ejans...@itmatters.nl wrote: Does it never stop... :) Thanks Zvezdan and Jakson for supplying all the reference code Schedule doesn't really permit all the work, so it'll be silent again for at least a week. I've been away for a bit, unable to pay

Re: awk indentation

2011-10-10 Fir de Conversatie erik
All, A new attempt. It is a near-rewrite It handles correctly now all cases from Zvezdan as well as some more code of my own. May I ask for volunteers for testing again. You can find the indenter here: http://dl.dropbox.com/u/26176183/awk.vim Fingers crossed :) Erik. -- You received this

Re: awk indentation

2011-10-10 Fir de Conversatie Jakson Alves de Aquino
On Mon, Oct 10, 2011 at 6:41 PM, erik ejans...@itmatters.nl wrote: A new attempt. It is a near-rewrite It handles correctly now all cases from Zvezdan as well as some more code of my own. May I ask for volunteers for testing again. You can find the indenter here:

Re: awk indentation

2011-10-02 Fir de Conversatie erik
Zvezdan, Thanks for your time to make your elaborate reply. This makes a valuable set of code for regression testing. 1.During the work this item was bothering me as well. My preference goes to option (a), so that's what I'll do. 2. :) I like this one. A continued statement, type 1, inside

Re: awk indentation

2011-09-30 Fir de Conversatie erik
All, I think I have this issue is fixed, as well as every other pending complaint. May I ask all involved in this thread to evaluate? You can find the indenter here: http://dl.dropbox.com/u/26176183/awk.vim Tested with vim 7.3 and 6.3, on several awk programs. It works fine on 7.3. It fails on

Re: awk indentation

2011-09-30 Fir de Conversatie Zvezdan Petkovic
On Sep 30, 2011, at 8:45 AM, erik wrote: I think I have this issue is fixed, as well as every other pending complaint. Not all issues yet. :-) May I ask all involved in this thread to evaluate? Gladly. You can find the indenter here: http://dl.dropbox.com/u/26176183/awk.vim Thanks

Re: awk indentation

2011-09-26 Fir de Conversatie erik
Hi Don, To prevent any misunderstanding, I see this point where it goes wrong: for (j=1; jM; j++) if (iperiods_per_field[fields[j]]) printf ,\n\t%s, field_to_SI_field[fields[j],i] load_pivoted.sql else

Re: awk indentation

2011-09-25 Fir de Conversatie erik
Hi Don, I didn't attach the script (knowingly) to the 'I think good news' posting on vim_dev. I sent it by e-mail directly to you and Zvezdan. That's the one to use. I keep my fingers crossed Erik. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below

Re: awk indentation

2011-09-25 Fir de Conversatie Donald Allen
On Sun, Sep 25, 2011 at 3:27 PM, erik ejans...@itmatters.nl wrote: Hi Don, I didn't attach the script (knowingly) to the 'I think good news' posting on vim_dev. I sent it by e-mail directly to you and Zvezdan. That's the one to use. I keep my fingers crossed It works on the example I gave

Re: awk indentation

2011-09-23 Fir de Conversatie Donald Allen
On Wed, Sep 21, 2011 at 4:29 PM, erik ejans...@itmatters.nl wrote: No, I should correct myself, I overlooked one diff. The latest official one is missing an essential change suggested by Philipp Edelmann a few months ago, it may still miscount braces. I will send you another one to test. Erik

Re: awk indentation

2011-09-21 Fir de Conversatie erik
All, I think good news, bit frustrating though. I have done my work and I was finding out how to commit my patches when I noted Bram has already applied several patches from this thread and also others. The version in Mercurial is essentially the same as my version. I tested on awk scripts from

Re: awk indentation

2011-09-21 Fir de Conversatie erik
No, I should correct myself, I overlooked one diff. The latest official one is missing an essential change suggested by Philipp Edelmann a few months ago, it may still miscount braces. I will send you another one to test. Erik. -- You received this message from the vim_dev maillist. Do not

Re: awk indentation

2011-09-17 Fir de Conversatie erik
Hello all, I will take a look at the problems with the original indenter, plz allow a few days I have to go through the learning curve again. Some example code using the aho kerninghan weinberger style appreciated. I am no big fan but I agree it should work. I joined vim_dev for the purpose,

Re: awk indentation

2011-09-17 Fir de Conversatie Donald Allen
will observe that I've found problems with the emacs/viper awk indentation. They took awhile to turn up, but there are problems there, too. Your indenter, slow though it may be, is the most consistently correct of any of them and I'm now using it, which allows me to return to vim, which, as I said

Re: awk indentation

2011-09-17 Fir de Conversatie Donald Allen
On Sat, Sep 17, 2011 at 7:21 AM, erik ejans...@itmatters.nl wrote: Hello all, I will take a look at the problems with the original indenter, plz allow a few days I have to go through the learning curve again. Some example code using the aho  kerninghan weinberger style appreciated. I am no

Re: awk indentation

2011-09-15 Fir de Conversatie Donald Allen
On Thu, Sep 15, 2011 at 4:18 PM, Gary Johnson garyj...@spocom.com wrote: On 2011-09-15, Donald Allen wrote: If you have following in a vim buffer, file named, say, foo.awk /some test/ { if (foo != bar) { if (baz != ){ array1[xyz] = N if (N max_N) max_N = N } xyz = temp[1] # Create

Re: awk indentation

2011-09-15 Fir de Conversatie Donald Allen
On Thu, Sep 15, 2011 at 10:43 PM, Zvezdan Petkovic zpetko...@acm.org wrote: On Thu, Sep 15, 2011 at 4:18 PM, Gary Johnson garyj...@spocom.com wrote: Vim's indentation of most languages (except C) is done by plugins. These reside in $VIMRUNTIME/indent and are contributed and maintained by a

Re: awk indentation

2011-09-15 Fir de Conversatie Zvezdan Petkovic
On Sep 16, 2011, at 12:05 AM, Donald Allen wrote: If I have a chance, I will send examples tomorrow, but I need to get my work done (as opposed to fighting with an editor) No hurry. The work is more important. FWIW, I'll be at a conference the next two days. I probably will not be able to

Re: Infinite loop in awk indentation

2011-04-05 Fir de Conversatie Philipp Edelmann
Dear Bram, On Sat, Apr 02, 2011 at 06:25:17PM +0200, Bram Moolenaar wrote: Yes, always contact the original author or current maintainer. If there is no response we can think of other solutions. Erik just replied to me. In the next couple of days he is going to send you a fixed version along

Re: Infinite loop in awk indentation

2011-04-02 Fir de Conversatie Bram Moolenaar
Philipp Edelmann wrote: Dear Vim developers, I noticed certain cases which cause Vim's indentation for awk to go into an infinite loop. The problem appears when there is a negative brace balance, i.e. more closing braces than opening braces. This can easily happen if one uses a regexp to

Re: Infinite loop in awk indentation

2011-04-02 Fir de Conversatie Philipp Edelmann
Dear Bram, On Sat, Apr 02, 2011 at 03:10:46PM +0200, Bram Moolenaar wrote: Have you tried contacting the author, Erik Janssen? No, I haven't. The history in the file shows only two entries back in 2002 and the repository shows no activity since the initial commit in 2004, so I figured there is

Re: Infinite loop in awk indentation

2011-04-02 Fir de Conversatie Bram Moolenaar
Philipp Edelmann wrote: On Sat, Apr 02, 2011 at 03:10:46PM +0200, Bram Moolenaar wrote: Have you tried contacting the author, Erik Janssen? No, I haven't. The history in the file shows only two entries back in 2002 and the repository shows no activity since the initial commit in 2004, so

Infinite loop in awk indentation

2011-04-01 Fir de Conversatie Philipp Edelmann
Dear Vim developers, I noticed certain cases which cause Vim's indentation for awk to go into an infinite loop. The problem appears when there is a negative brace balance, i.e. more closing braces than opening braces. This can easily happen if one uses a regexp to match a closing brace. Vim then

Re: Infinite loop in awk indentation

2011-04-01 Fir de Conversatie Jakson A. Aquino
On Fri, Apr 1, 2011 at 8:53 PM, Philipp Edelmann edelm...@fs.tum.de wrote: Additionally, I think that strings and computed regexps should not be scanned for matching braces at all when it comes to determining the indentation. I changed the Get_brace_balance function to strip ... and /.../