Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ian Hickson
On Fri, 12 Apr 2013, Filip Pizlo wrote: > > There is a possibility of deadlock. You can have one task waiting for a > message from another, and that other waiting for a message from the > first. Actually, you can't. We very specifically designed workers (and even more importantly the API on th

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Rik Cabanier
On Fri, Apr 12, 2013 at 10:34 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 9:46 PM, Rik Cabanier wrote: > > > > On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg > wrote: > >> > A message passing model a la Web Workers has some advantages compared to >> > threads with shared mutable state and l

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 11:07 PM, Ryosuke Niwa wrote: > On Fri, Apr 12, 2013 at 10:44 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 10:43 PM, Ryosuke Niwa wrote: > >> On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo wrote: >> >> On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: >> >>> On Fri, Ap

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 10:44 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 10:43 PM, Ryosuke Niwa wrote: > > On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo wrote: > >> >> On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: >> >> On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: >> >>> >>> On A

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Arunprasad Rajkumar
Hi Darin, >>Is this for debug builds or for production builds? It is for production build. >>If it is for debug builds, then adding file and line seems fine; we should do it in a way that shares code with assertion macros. So in-case of calling CRASH from ASSERT then it shouldn't print __FILE__ a

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Patrick Gansterer
Am 13.04.2013 um 03:22 schrieb Benjamin Poulain: > On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak wrote: > On Apr 12, 2013, at 4:09 PM, Karen Shaeffer wrote: > > As others have said, we are definitely eager to use C++11 across the board > but are limited by compiler support requirements. >

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 7:03 PM, Dirk Pranke wrote: > On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: > I'm curious: would you want to use ParallelArray, if you had the flexibility > of building a different abstraction? > > I find ParallelArray to be an awkward abstraction to begin with. I l

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 10:43 PM, Ryosuke Niwa wrote: > On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: > >> On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: >> >> On Apr 12, 2013, at 1:39 PM, Jarred Nicholls >> wrote: >> >>> On Fr

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: > > On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: > >> >> On Apr 12, 2013, at 1:39 PM, Jarred Nicholls >> wrote: >> >> On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: >> >> >> Fo

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 9:46 PM, Rik Cabanier wrote: > > > On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg wrote: > > A message passing model a la Web Workers has some advantages compared to > > threads with shared mutable state and locks: > > - No possibility of deadlock > > - No possibility of

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 6:35 PM, Maciej Stachowiak wrote: > > On Apr 12, 2013, at 2:13 PM, Filip Pizlo wrote: > >> >> On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: >> >>> On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: >>> >>> On Apr 12, 2013, at 1:39 PM, Jarred Nicholls >>> wrote:

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Rik Cabanier
On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg wrote: > > A message passing model a la Web Workers has some advantages compared to > > threads with shared mutable state and locks: > > - No possibility of deadlock > > - No possibility of corrupting data structures due to races > > - No performanc

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Zoltan Herczeg
> A message passing model a la Web Workers has some advantages compared to > threads with shared mutable state and locks: > - No possibility of deadlock > - No possibility of corrupting data structures due to races > - No performance penalty from correctly supporting fine-grained concurrent > acces

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Dirk Pranke
On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: > I'm curious: would you want to use ParallelArray, if you had the > flexibility of building a different abstraction? > > I find ParallelArray to be an awkward abstraction to begin with. I like > work queues and such. The whole idea that the o

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Roger Fong
> From the CMake thread, I got that MSVC 2010 will soon be the oldest version > supported. Is that correct? > It looks like that might be the case although I still need to test cmake on the AppleWin port to confirm that’s it’s okay. Assuming that we do make use of cmake I’m still not quite su

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Maciej Stachowiak
On Apr 12, 2013, at 2:13 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: > >> On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: >> >> On Apr 12, 2013, at 1:39 PM, Jarred Nicholls >> wrote: >> >>> On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: >>> >>>

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak wrote: > > On Apr 12, 2013, at 4:09 PM, Karen Shaeffer > wrote: > > As others have said, we are definitely eager to use C++11 across the board > but are limited by compiler support requirements. > > One thing that it would be useful to know: what

[webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Maciej Stachowiak
On Apr 12, 2013, at 4:09 PM, Karen Shaeffer wrote: > > Of course, I understand that. But there is a huge opportunity cost to webkit. > The c++11 standard also rewrites the entire standard library. I have been > using > g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have tested

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Alexey Proskuryakov
12 апр. 2013 г., в 13:58, Benjamin Poulain написал(а): > In https://bugs.webkit.org/show_bug.cgi?id=114379 I add this for WK2 and for > WK1 mac/win. > > Are other ports interested in this behavior? If not, I'd just skip the > corresponding tests. > > I am confused. > Why do you want to add s

Re: [webkit-dev] on coding-style

2013-04-12 Thread Darin Adler
On Apr 12, 2013, at 3:33 PM, Karen Shaeffer wrote: > Shouldn't the coding-style documentation be updated to use nullptr? We may want to update the guidelines to tell people to use nullptr where it works. We definitely put some effort into making it usable in certain contexts; we originally add

Re: [webkit-dev] on coding-style

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 4:09 PM, Karen Shaeffer wrote: > On Fri, Apr 12, 2013 at 03:41:17PM -0700, Benjamin Poulain wrote: > > On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer < > shaef...@neuralscape.com>wrote: > > > > > > Was reading the coding-style documentation. Have just one question > > > co

Re: [webkit-dev] on coding-style

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 4:09 PM, Karen Shaeffer wrote: > Of course, I understand that. But there is a huge opportunity cost to > webkit. > The c++11 standard also rewrites the entire standard library. I have been > using > g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have > test

Re: [webkit-dev] on coding-style

2013-04-12 Thread Karen Shaeffer
On Fri, Apr 12, 2013 at 03:41:17PM -0700, Benjamin Poulain wrote: > On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer > wrote: > > > > Was reading the coding-style documentation. Have just one question > > concerning > > C++ null pointer value. Quoting the coding-style docs, "In C++, the null > > po

Re: [webkit-dev] on coding-style

2013-04-12 Thread Allan Sandfeld Jensen
On Saturday 13 April 2013, Karen Shaeffer wrote: > Hello, > Was reading the coding-style documentation. Have just one question > concerning C++ null pointer value. Quoting the coding-style docs, "In C++, > the null pointer value should be written as 0." > > My question is: Doesn't xcode clang now

Re: [webkit-dev] on coding-style

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer wrote: > > Was reading the coding-style documentation. Have just one question > concerning > C++ null pointer value. Quoting the coding-style docs, "In C++, the null > pointer > value should be written as 0." > > My question is: Doesn't xcode clang no

[webkit-dev] on coding-style

2013-04-12 Thread Karen Shaeffer
Hello, Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, "In C++, the null pointer value should be written as 0." My question is: Doesn't xcode clang now support features like nullptr? Shouldn't the coding-style doc

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa wrote: > On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 1:39 PM, Jarred Nicholls > wrote: > >> On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: >> >> For as little worth as it is, I agree with you Filip that providi

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
On Fri, Apr 12, 2013 at 10:58 PM, Benjamin Poulain wrote: > On Fri, Apr 12, 2013 at 5:05 AM, Jochen Eisinger wrote: >> >> currently, WebKit allows for an arbitrary number of new windows to be >> created in response to a single user gesture. This is "used" for example to >> create pop-unders. >> >>

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
On Fri, Apr 12, 2013 at 10:40 PM, Brady Eidson wrote: > > On Apr 12, 2013, at 5:05 AM, Jochen Eisinger wrote: > > Hi, > > currently, WebKit allows for an arbitrary number of new windows to be > created in response to a single user gesture. This is "used" for example to > create pop-unders. > > I

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 1:39 PM, Jarred Nicholls > wrote: > > On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: > > > For as little worth as it is, I agree with you Filip that providing > low-level primitives would be best in terms of a foun

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 5:05 AM, Jochen Eisinger wrote: > > currently, WebKit allows for an arbitrary number of new windows to be > created in response to a single user gesture. This is "used" for example to > create pop-unders. > > In order to restrict the number of new windows to one per user ges

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 1:39 PM, Jarred Nicholls wrote: > On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: > > On Apr 12, 2013, at 8:36 AM, "Hudson, Rick" wrote: > > > I'm assuming that we agree that JavaScript must evolve to leverage the > > hardware's power stingy parallelism. > > True, b

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Jarred Nicholls
Argh, sending from the right address this time. On Fri, Apr 12, 2013 at 4:39 PM, Jarred Nicholls wrote: > On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo wrote: > >> >> On Apr 12, 2013, at 8:36 AM, "Hudson, Rick" >> wrote: >> >> > I'm assuming that we agree that JavaScript must evolve to leverage

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Brady Eidson
On Apr 12, 2013, at 5:05 AM, Jochen Eisinger wrote: > Hi, > > currently, WebKit allows for an arbitrary number of new windows to be created > in response to a single user gesture. This is "used" for example to create > pop-unders. > > In order to restrict the number of new windows to one per

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 11:59 AM, Sergio Villar Senin wrote: > En 12/04/13 19:00, Ryosuke Niwa escribiu: > > On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin > Well, I have a pretty compact patch more or less ready to be > uploaded to > > bz that in the case of the caret being placed

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Sergio Villar Senin
En 12/04/13 19:00, Ryosuke Niwa escribiu: > On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin Well, I have a pretty compact patch more or less ready to be uploaded to > bz that in the case of the caret being placed at (3) just draws the > classical 1px width bar (it also draws the t

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 8:36 AM, "Hudson, Rick" wrote: > I'm assuming that we agree that JavaScript must evolve to leverage the > hardware's power stingy parallelism. True, but there is also the question of how high of a priority we should give to this relative to other project goals, and also wh

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 10:07 AM, Shezan Baig wrote: > On Fri, Apr 12, 2013 at 6:01 PM, Ryosuke Niwa wrote: > > On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa wrote: > >> > >> On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin < > svil...@igalia.com> > >> wrote: > >>> > >>> I know that WK fol

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Shezan Baig
On Fri, Apr 12, 2013 at 6:01 PM, Ryosuke Niwa wrote: > On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa wrote: >> >> On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin >> wrote: >>> >>> I know that WK follows the NSTextView implementation but FF for example >>> does not show the remote insert is

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa wrote: > On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin > wrote: > >> I know that WK follows the NSTextView implementation but FF for example >> does not show the remote insert issue. >> > > Yes, it does. Firefox simply uses heuristics to gue

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin wrote: > I know that WK follows the NSTextView implementation but FF for example > does not show the remote insert issue. > Yes, it does. Firefox simply uses heuristics to guess which type of character LTR/RTL you're about to type. They still

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Sergio Villar Senin
En 12/04/13 18:17, Ryosuke Niwa escribiu: > On Fri, Apr 12, 2013 at 4:40 AM, Sergio Villar Senin For example consider the strongly LTR letters > "abc" inside a RTL block, which will be rendered as "abc". If we either > place the caret at the beginning (before 'a') or at the end (after

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 4:40 AM, Sergio Villar Senin wrote: > En 12/03/13 18:31, > - R. Niwa > escribiu: > > That doesn't work. At a bidi-level boundary, offset can jump from one > > place to another. Consider a much simpler example; the same sequence of > > letters, in logical order, ABC123 in a

[webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Hudson, Rick
I'm assuming that we agree that JavaScript must evolve to leverage the hardware's power stingy parallelism. For completeness there seems to be the following approaches. 1) Add nothing to the language and rely on increasingly sophisticated compilers to detect opportunities to safely paral

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Darin Adler
Is this for debug builds or for production builds? If it is for debug builds, then adding file and line seems fine; we should do it in a way that shares code with assertion macros. If it is for production builds, then how do you debug other crashes? -- Darin

Re: [webkit-dev] StyleBuilder vs StyleResolver

2013-04-12 Thread Antti Koivisto
On Fri, Apr 12, 2013 at 4:50 PM, Dirk Schulze wrote: > > On Apr 12, 2013, at 1:08 AM, Antti Koivisto wrote: > > > On Fri, Apr 12, 2013 at 7:36 AM, Dirk Schulze > wrote: > > Hi, > > > > The style of CSS properties is either set in StyleBuilder/CSSProperty or > in StyleResolver (alias CSSStyleSel

Re: [webkit-dev] StyleBuilder vs StyleResolver

2013-04-12 Thread Dirk Schulze
On Apr 12, 2013, at 1:08 AM, Antti Koivisto wrote: > On Fri, Apr 12, 2013 at 7:36 AM, Dirk Schulze wrote: > Hi, > > The style of CSS properties is either set in StyleBuilder/CSSProperty or in > StyleResolver (alias CSSStyleSelector). > > StyleResolver has a giant switch statement to handle a

[webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is "used" for example to create pop-unders. In order to restrict the number of new windows to one per user gesture, a port needs to invoke UserGestureIndicator::consumeUser

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Sergio Villar Senin
En 12/03/13 18:31, Ryosuke Niwa escribiu: > That doesn't work. At a bidi-level boundary, offset can jump from one > place to another. Consider a much simpler example; the same sequence of > letters, in logical order, ABC123 in a RTL block, which will be rendered as: > 123CBA > with logical/DOM offs

[webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Arunprasad Rajkumar
(Hope this is the proper mailing list to ask, Sorry in-case of not) Hello Folks, In embedded platforms(mostly debugger is missing) it very difficult(for us) to debug the issues without proper prints in CRASH macro. Though it has "WTFReportBacktrace();" due to some constraints we are not getting p

Re: [webkit-dev] StyleBuilder vs StyleResolver

2013-04-12 Thread Antti Koivisto
On Fri, Apr 12, 2013 at 7:36 AM, Dirk Schulze wrote: > Hi, > > The style of CSS properties is either set in StyleBuilder/CSSProperty or > in StyleResolver (alias CSSStyleSelector). > > StyleResolver has a giant switch statement to handle all CSS property > values and set the style. It is the hist