Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

I mentioned a few months ago that I had similar struggles with the gcc 4.9 requirement. I've been trying to build JavaScriptCore in a way that it is redistributable for Steam Linux/SteamOS (aka "Steam Runtime"). For those that don't know, building redistributable binaries is a nightmare in the

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 19, 2016, at 12:55 PM, Konstantin Tokarev wrote: > > > > 19.04.2016, 18:23, "Filip Pizło" >: >>> On Apr 19, 2016, at 5:50 AM, Carlos Alberto Lopez Perez >> > wrote: >>>

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 18:23, "Filip Pizło" : >>  On Apr 19, 2016, at 5:50 AM, Carlos Alberto Lopez Perez >> wrote: >> >>>  On 18/04/16 21:50, Filip Pizlo wrote: >>>  I don't want a buildbot for MIPS. It's not a relevant architecture >>>  anymore. I don't think that

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 22:22, "Anders Carlsson" : >> On Apr 19, 2016, at 12:21 PM, Konstantin Tokarev wrote: >> >> 19.04.2016, 22:11, "Anders Carlsson" :  On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev wrote:

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 19, 2016, at 12:21 PM, Konstantin Tokarev wrote: > > > > 19.04.2016, 22:11, "Anders Carlsson" : >>> On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev wrote: >>> >>> 19.04.2016, 21:38, "Anders Carlsson" :

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 22:11, "Anders Carlsson" : >>  On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev wrote: >> >>  19.04.2016, 21:38, "Anders Carlsson" : >>>  I’d like us to switch over to using C++14 in WebKit2 so we can get the new >>>

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev wrote: > > > > 19.04.2016, 21:38, "Anders Carlsson" : >> I’d like us to switch over to using C++14 in WebKit2 so we can get the new >> generalized lambda capture

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 21:38, "Anders Carlsson" : > I’d like us to switch over to using C++14 in WebKit2 so we can get the new > generalized lambda capture (https://isocpp.org/files/papers/N3648.html), so > we can capture move-only types in lambdas. According to  >

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 21:34, "Filip Pizlo" : >> On Apr 19, 2016, at 11:33 AM, Konstantin Tokarev wrote: >> >> 19.04.2016, 21:15, "Filip Pizlo" : >>> I did a quick look over the trac query of GCC 4.8 changes that you >>> provided. None of the ones I

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

I’d like us to switch over to using C++14 in WebKit2 so we can get the new generalized lambda capture (https://isocpp.org/files/papers/N3648.html ), so we can capture move-only types in lambdas. According to

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 19, 2016, at 11:33 AM, Konstantin Tokarev wrote: > > > > 19.04.2016, 21:15, "Filip Pizlo" >: >> I did a quick look over the trac query of GCC 4.8 changes that you provided. >> None of the ones I looked at were scary but

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

19.04.2016, 21:15, "Filip Pizlo" : > I did a quick look over the trac query of GCC 4.8 changes that you provided. > None of the ones I looked at were scary but they were annoying. They seemed > to be things like: > > - Sometimes saying { } to initialize a variable doesn’t

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

I did a quick look over the trac query of GCC 4.8 changes that you provided. None of the ones I looked at were scary but they were annoying. They seemed to be things like: - Sometimes saying { } to initialize a variable doesn’t work. - Sometimes you need to say “const”. - Sometimes you need

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

Hi, On Mon, 2016-04-18 at 17:27 -0700, Filip Pizlo wrote: > I am sympathetic to the principle that we should support the > compilers that ship on the most popular versions of Linux. Great. :) > I’d like to understand if that argument is sufficient to support GCC > 4.8. > > Can you clarify, is

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

On Mon, 2016-04-18 at 17:26 -0700, Filip Pizlo wrote: > Yeah.  If we allow GCC 4.8 then I think we should make all of our > code compile with it.  If that proves too difficult (like if we had > to get rid of all lambdas), then I think we need to not allow GCC > 4.8. Agreed. And don't worry, we

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 19, 2016, at 5:50 AM, Carlos Alberto Lopez Perez > wrote: > >> On 18/04/16 21:50, Filip Pizlo wrote: >> I don't want a buildbot for MIPS. It's not a relevant architecture >> anymore. I don't think that JSC developers should have to expend >> effort towards keeping

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS [WARNING - NOT VIRUS SCANNED]

I think that this is probably OK for the purposes of not creating obligations but I don't see it as a viable strategy for making WebKit work of MIPS. For example, you guys haven't even shown that JSC can pass all WebKit tests on MIPS. You haven't shown that the MIPS JIT produces a speed up

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS [WARNING - NOT VIRUS SCANNED]

19.04.2016, 15:24, "Osztrogonác Csaba" : > Hi, > > now the #error macro in Compiler.h is the only one blocker to > be able to build JSCOnly port with GCC 4.8 (without FTL JIT): > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Compiler.h#L73 > > The existance of a

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

On 18/04/16 21:50, Filip Pizlo wrote: > I don't want a buildbot for MIPS. It's not a relevant architecture > anymore. I don't think that JSC developers should have to expend > effort towards keeping this architecture working. > MIPS is still relevant on embedded devices (mainly set-top boxes).

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS [WARNING - NOT VIRUS SCANNED]

Hi, now the #error macro in Compiler.h is the only one blocker to be able to build JSCOnly port with GCC 4.8 (without FTL JIT): http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Compiler.h#L73 The existance of a buildbot doesn't mean any obligation for anybody. We have many bots which are

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 18, 2016, at 4:43 PM, Michael Catanzaro wrote: > > On Mon, 2016-04-18 at 15:01 -0700, Geoffrey Garen wrote: >> GCC 4.8 is three years old. > > Yeah, unfortunately no Linux distros are ever willing to do major > compiler upgrades, even Fedora is only willing to

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

Yeah. If we allow GCC 4.8 then I think we should make all of our code compile with it. If that proves too difficult (like if we had to get rid of all lambdas), then I think we need to not allow GCC 4.8. -Filip > On Apr 18, 2016, at 12:54 PM, Anders Carlsson wrote: > >

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

On Mon, 2016-04-18 at 15:01 -0700, Geoffrey Garen wrote: > GCC 4.8 is three years old. Yeah, unfortunately no Linux distros are ever willing to do major compiler upgrades, even Fedora is only willing to take minor compiler upgrades, so our willingness to support old compilers is proportional to

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

> On Apr 18, 2016, at 2:08 PM, Michael Catanzaro wrote: > > On Mon, 2016-04-18 at 22:36 +0300, Konstantin Tokarev wrote: >> Are there any objections for lowering GCC requirement from 4.9.0 to >> 4.8.4 (only for JavaScriptCore without B3)? I'm going to fix arising >>

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

18.04.2016, 22:56, "Geoffrey Garen" : >>>   Are there any objections for lowering GCC requirement from 4.9.0 to 4.8.4 >>> (only for JavaScriptCore without B3)? I'm going to fix arising compilation >>> errors myself. > >  Yes. > >  We want to move forward in C++ language

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

On Mon, 2016-04-18 at 22:36 +0300, Konstantin Tokarev wrote: > Are there any objections for lowering GCC requirement from 4.9.0 to > 4.8.4 (only for JavaScriptCore without B3)? I'm going to fix arising > compilation errors myself. I've been kinda hoping to do this regardless, since you started

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

>> Are there any objections for lowering GCC requirement from 4.9.0 to 4.8.4 >> (only for JavaScriptCore without B3)? I'm going to fix arising compilation >> errors myself. Yes. We want to move forward in C++ language support, not backward. Any platform not worthy of native compiler

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

I also don’t think we should require different versions of GCC for different projects. - Anders > On Apr 18, 2016, at 12:50 PM, Filip Pizlo wrote: > > I don't want a buildbot for MIPS. It's not a relevant architecture anymore. I > don't think that JSC developers should

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

I don't want a buildbot for MIPS. It's not a relevant architecture anymore. I don't think that JSC developers should have to expend effort towards keeping this architecture working. -Filip > On Apr 18, 2016, at 12:36 PM, Konstantin Tokarev wrote: > > Hello, > > I'd like

[webkit-dev] Build slave for JSCOnly Linux MIPS

Hello, I'd like to run build slave for MIPS port of JSC (with JSCOnly port on Linux). On the first iteration it will just ensure that compilation is not broken, afterwards I'm planning to add running tests on target. However, I'm planning to use cross-toolchain based on GCC 4.8.4 (for now, the